From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: ego@linux.vnet.ibm.com
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linuxppc-dev@ozlabs.org, Linux PM list <linux-pm@vger.kernel.org>,
svaidy@linux.vnet.ibm.com
Subject: Re: [PATCH v3 5/5] powernv:cpufreq: Implement the driver->get() method
Date: Sat, 22 Mar 2014 09:56:30 +1100 [thread overview]
Message-ID: <1395442590.3460.85.camel@pasglop> (raw)
In-Reply-To: <20140321110445.GB2493@in.ibm.com>
On Fri, 2014-03-21 at 16:34 +0530, Gautham R Shenoy wrote:
> > >
> > > +/*
> > > + * Computes the current frequency on this cpu
> > > + * and stores the result in *ret_freq.
> > > + */
> > > +static void powernv_read_cpu_freq(void *ret_freq)
> > > +{
> > > + unsigned long pmspr_val;
> > > + s8 local_pstate_id;
> > > + int *cur_freq, freq, pstate_id;
> > > +
> > > + cur_freq = (int *)ret_freq;
> >
> > You don't need cur_freq variable at all..
>
> I don't like it either. But the compiler complains without this hack
> :-(
Casting integers into void * is a recipe for disaster... what is that
supposed to be about ? We lose all type checking and get exposed
to endian issues etc... the day somebody uses a different type on both
sides.
Also is "freq" a frequency ? In this case an int isn't big enough.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: ego@linux.vnet.ibm.com
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3 5/5] powernv:cpufreq: Implement the driver->get() method
Date: Sat, 22 Mar 2014 09:56:30 +1100 [thread overview]
Message-ID: <1395442590.3460.85.camel@pasglop> (raw)
In-Reply-To: <20140321110445.GB2493@in.ibm.com>
On Fri, 2014-03-21 at 16:34 +0530, Gautham R Shenoy wrote:
> > >
> > > +/*
> > > + * Computes the current frequency on this cpu
> > > + * and stores the result in *ret_freq.
> > > + */
> > > +static void powernv_read_cpu_freq(void *ret_freq)
> > > +{
> > > + unsigned long pmspr_val;
> > > + s8 local_pstate_id;
> > > + int *cur_freq, freq, pstate_id;
> > > +
> > > + cur_freq = (int *)ret_freq;
> >
> > You don't need cur_freq variable at all..
>
> I don't like it either. But the compiler complains without this hack
> :-(
Casting integers into void * is a recipe for disaster... what is that
supposed to be about ? We lose all type checking and get exposed
to endian issues etc... the day somebody uses a different type on both
sides.
Also is "freq" a frequency ? In this case an int isn't big enough.
Cheers,
Ben.
next prev parent reply other threads:[~2014-03-21 22:57 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 12:10 [PATCH v3 0/5] powernv: Enable Dynamic Frequency Gautham R. Shenoy
2014-03-20 12:10 ` Gautham R. Shenoy
2014-03-20 12:10 ` [PATCH v3 1/5] powernv: cpufreq driver for powernv platform Gautham R. Shenoy
2014-03-20 12:10 ` Gautham R. Shenoy
2014-03-21 8:41 ` Viresh Kumar
2014-03-21 8:41 ` Viresh Kumar
2014-03-21 10:43 ` Gautham R Shenoy
2014-03-21 10:43 ` Gautham R Shenoy
2014-03-21 10:54 ` Viresh Kumar
2014-03-21 10:54 ` Viresh Kumar
2014-03-21 11:40 ` Srivatsa S. Bhat
2014-03-21 11:40 ` Srivatsa S. Bhat
2014-03-21 13:23 ` Gautham R Shenoy
2014-03-21 13:23 ` Gautham R Shenoy
2014-03-21 13:34 ` Viresh Kumar
2014-03-21 13:34 ` Viresh Kumar
2014-03-21 14:54 ` Gautham R Shenoy
2014-03-21 14:54 ` Gautham R Shenoy
2014-03-22 3:43 ` Viresh Kumar
2014-03-22 3:43 ` Viresh Kumar
2014-03-21 14:48 ` Vaidyanathan Srinivasan
2014-03-21 14:48 ` Vaidyanathan Srinivasan
2014-03-22 3:43 ` Viresh Kumar
2014-03-22 3:43 ` Viresh Kumar
2014-03-21 11:45 ` Srivatsa S. Bhat
2014-03-21 11:45 ` Srivatsa S. Bhat
2014-03-21 11:47 ` Viresh Kumar
2014-03-21 11:47 ` Viresh Kumar
2014-03-20 12:10 ` [PATCH v3 2/5] powernv,cpufreq:Add per-core locking to serialize frequency transitions Gautham R. Shenoy
2014-03-20 12:10 ` [PATCH v3 2/5] powernv, cpufreq:Add " Gautham R. Shenoy
2014-03-21 6:24 ` [PATCH v3 2/5] powernv,cpufreq:Add " Gautham R Shenoy
2014-03-21 6:24 ` [PATCH v3 2/5] powernv, cpufreq:Add " Gautham R Shenoy
2014-03-21 8:42 ` Viresh Kumar
2014-03-21 8:42 ` Viresh Kumar
2014-03-21 9:56 ` [PATCH v3 2/5] powernv,cpufreq:Add " Srivatsa S. Bhat
2014-03-21 9:56 ` [PATCH v3 2/5] powernv, cpufreq:Add " Srivatsa S. Bhat
2014-03-20 12:10 ` [PATCH v3 3/5] powernv:cpufreq: Create pstate_id_to_freq() helper Gautham R. Shenoy
2014-03-20 12:10 ` Gautham R. Shenoy
2014-03-21 6:24 ` Gautham R Shenoy
2014-03-21 6:24 ` Gautham R Shenoy
2014-03-20 12:10 ` [PATCH v3 4/5] powernv:cpufreq: Export nominal frequency via sysfs Gautham R. Shenoy
2014-03-20 12:10 ` Gautham R. Shenoy
2014-03-21 8:47 ` Viresh Kumar
2014-03-21 8:47 ` Viresh Kumar
2014-03-21 9:55 ` Gautham R Shenoy
2014-03-21 9:55 ` Gautham R Shenoy
2014-03-21 9:57 ` Viresh Kumar
2014-03-21 9:57 ` Viresh Kumar
2014-03-20 12:11 ` [PATCH v3 5/5] powernv:cpufreq: Implement the driver->get() method Gautham R. Shenoy
2014-03-20 12:11 ` Gautham R. Shenoy
2014-03-21 6:25 ` Gautham R Shenoy
2014-03-21 6:25 ` Gautham R Shenoy
2014-03-21 9:31 ` Viresh Kumar
2014-03-21 9:31 ` Viresh Kumar
2014-03-21 11:04 ` Gautham R Shenoy
2014-03-21 11:04 ` Gautham R Shenoy
2014-03-21 11:45 ` Viresh Kumar
2014-03-21 11:45 ` Viresh Kumar
2014-03-21 12:01 ` David Laight
2014-03-21 12:01 ` David Laight
2014-03-21 12:31 ` Gautham R Shenoy
2014-03-21 12:31 ` Gautham R Shenoy
2014-03-21 12:34 ` Viresh Kumar
2014-03-21 12:34 ` Viresh Kumar
2014-03-21 15:01 ` David Laight
2014-03-21 15:01 ` David Laight
2014-03-21 13:04 ` Gautham R Shenoy
2014-03-21 13:04 ` Gautham R Shenoy
2014-03-21 13:12 ` Viresh Kumar
2014-03-21 13:12 ` Viresh Kumar
2014-03-21 14:25 ` Gautham R Shenoy
2014-03-21 14:25 ` Gautham R Shenoy
2014-03-21 22:56 ` Benjamin Herrenschmidt [this message]
2014-03-21 22:56 ` Benjamin Herrenschmidt
2014-03-22 7:53 ` Gautham R Shenoy
2014-03-22 7:53 ` Gautham R Shenoy
2014-03-21 7:46 ` [PATCH v3 0/5] powernv: Enable Dynamic Frequency Viresh Kumar
2014-03-21 7:46 ` Viresh Kumar
2014-03-21 8:19 ` Gautham R Shenoy
2014-03-21 8:19 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395442590.3460.85.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=svaidy@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.