All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prasad Joshi <prasadjoshi.linux@gmail.com>
To: prasadjoshi.linux@gmail.com
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de,
	qemu-ppc@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-trivial] [PATCH] spapr_vscsi: remove duplicate condition check
Date: Mon, 24 Mar 2014 21:14:46 +0530	[thread overview]
Message-ID: <1395675886-3357-1-git-send-email-prasadjoshi.linux@gmail.com> (raw)

Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
---
 hw/scsi/spapr_vscsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
index 34478f0..d4ada4f 100644
--- a/hw/scsi/spapr_vscsi.c
+++ b/hw/scsi/spapr_vscsi.c
@@ -690,7 +690,7 @@ static void vscsi_inquiry_no_target(VSCSIState *s, vscsi_req *req)
     int rc, len, alen;
 
     /* We dont do EVPD. Also check that page_code is 0 */
-    if ((cdb[1] & 0x01) || (cdb[1] & 0x01) || cdb[2] != 0) {
+    if ((cdb[1] & 0x01) || cdb[2] != 0) {
         /* Send INVALID FIELD IN CDB */
         vscsi_makeup_sense(s, req, ILLEGAL_REQUEST, 0x24, 0);
         vscsi_send_rsp(s, req, CHECK_CONDITION, 0, 0);
-- 
1.8.1.2



WARNING: multiple messages have this Message-ID (diff)
From: Prasad Joshi <prasadjoshi.linux@gmail.com>
To: prasadjoshi.linux@gmail.com
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de,
	qemu-ppc@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH] spapr_vscsi: remove duplicate condition check
Date: Mon, 24 Mar 2014 21:14:46 +0530	[thread overview]
Message-ID: <1395675886-3357-1-git-send-email-prasadjoshi.linux@gmail.com> (raw)

Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
---
 hw/scsi/spapr_vscsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
index 34478f0..d4ada4f 100644
--- a/hw/scsi/spapr_vscsi.c
+++ b/hw/scsi/spapr_vscsi.c
@@ -690,7 +690,7 @@ static void vscsi_inquiry_no_target(VSCSIState *s, vscsi_req *req)
     int rc, len, alen;
 
     /* We dont do EVPD. Also check that page_code is 0 */
-    if ((cdb[1] & 0x01) || (cdb[1] & 0x01) || cdb[2] != 0) {
+    if ((cdb[1] & 0x01) || cdb[2] != 0) {
         /* Send INVALID FIELD IN CDB */
         vscsi_makeup_sense(s, req, ILLEGAL_REQUEST, 0x24, 0);
         vscsi_send_rsp(s, req, CHECK_CONDITION, 0, 0);
-- 
1.8.1.2

             reply	other threads:[~2014-03-24 15:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 15:44 Prasad Joshi [this message]
2014-03-24 15:44 ` [Qemu-devel] [PATCH] spapr_vscsi: remove duplicate condition check Prasad Joshi
2014-03-24 15:45 ` [Qemu-trivial] " Paolo Bonzini
2014-03-24 15:45   ` [Qemu-devel] " Paolo Bonzini
2014-03-24 17:19   ` [Qemu-trivial] " Prasad Joshi
2014-03-24 17:19     ` [Qemu-devel] " Prasad Joshi
2014-03-24 17:50     ` [Qemu-trivial] " Paolo Bonzini
2014-03-24 17:50       ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395675886-3357-1-git-send-email-prasadjoshi.linux@gmail.com \
    --to=prasadjoshi.linux@gmail.com \
    --cc=agraf@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.