* [Qemu-trivial] [PATCH] qemu-img: Release refernece to BlockDriverState
@ 2014-03-25 20:25 ` Prasad Joshi
0 siblings, 0 replies; 6+ messages in thread
From: Prasad Joshi @ 2014-03-25 20:25 UTC (permalink / raw)
To: prasadjoshi.linux
Cc: kwolf, qemu-trivial, pl, qemu-devel, stefanha, pbonzini, eblake
Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
---
qemu-img.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-img.c b/qemu-img.c
index 2e40cc1..3d110d9 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1809,6 +1809,7 @@ static ImageInfoList *collect_image_info_list(const char *filename,
if (err) {
error_report("%s", error_get_pretty(err));
error_free(err);
+ bdrv_unref(bs);
goto err;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] qemu-img: Release refernece to BlockDriverState
@ 2014-03-25 20:25 ` Prasad Joshi
0 siblings, 0 replies; 6+ messages in thread
From: Prasad Joshi @ 2014-03-25 20:25 UTC (permalink / raw)
To: prasadjoshi.linux; +Cc: kwolf, qemu-trivial, pl, qemu-devel, stefanha, pbonzini
Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
---
qemu-img.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-img.c b/qemu-img.c
index 2e40cc1..3d110d9 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1809,6 +1809,7 @@ static ImageInfoList *collect_image_info_list(const char *filename,
if (err) {
error_report("%s", error_get_pretty(err));
error_free(err);
+ bdrv_unref(bs);
goto err;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-trivial] for 2.0: Re: [PATCH] qemu-img: Release refernece to BlockDriverState
2014-03-25 20:25 ` [Qemu-devel] " Prasad Joshi
@ 2014-03-25 21:19 ` Eric Blake
-1 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2014-03-25 21:19 UTC (permalink / raw)
To: Prasad Joshi; +Cc: kwolf, qemu-trivial, pl, qemu-devel, stefanha, pbonzini
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On 03/25/2014 02:25 PM, Prasad Joshi wrote:
s/refernece/reference/ in the subject
This is worth including in 2.0
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
> ---
> qemu-img.c | 1 +
> 1 file changed, 1 insertion(+)
With subject line fixed:
Reviewed-by: Eric Blake <eblake@redhat.com>
Appears to have been introduced in commit 43526ec
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] for 2.0: Re: [PATCH] qemu-img: Release refernece to BlockDriverState
@ 2014-03-25 21:19 ` Eric Blake
0 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2014-03-25 21:19 UTC (permalink / raw)
To: Prasad Joshi; +Cc: kwolf, qemu-trivial, pl, qemu-devel, stefanha, pbonzini
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On 03/25/2014 02:25 PM, Prasad Joshi wrote:
s/refernece/reference/ in the subject
This is worth including in 2.0
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
> ---
> qemu-img.c | 1 +
> 1 file changed, 1 insertion(+)
With subject line fixed:
Reviewed-by: Eric Blake <eblake@redhat.com>
Appears to have been introduced in commit 43526ec
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] qemu-img: Release refernece to BlockDriverState
2014-03-25 20:25 ` [Qemu-devel] " Prasad Joshi
@ 2014-03-26 8:57 ` Stefan Hajnoczi
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2014-03-26 8:57 UTC (permalink / raw)
To: Prasad Joshi; +Cc: kwolf, qemu-trivial, pl, qemu-devel, pbonzini, eblake
On Wed, Mar 26, 2014 at 01:55:53AM +0530, Prasad Joshi wrote:
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
> ---
> qemu-img.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-img: Release refernece to BlockDriverState
@ 2014-03-26 8:57 ` Stefan Hajnoczi
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2014-03-26 8:57 UTC (permalink / raw)
To: Prasad Joshi; +Cc: kwolf, qemu-trivial, pl, qemu-devel, pbonzini
On Wed, Mar 26, 2014 at 01:55:53AM +0530, Prasad Joshi wrote:
> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
> ---
> qemu-img.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-26 8:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-25 20:25 [Qemu-trivial] [PATCH] qemu-img: Release refernece to BlockDriverState Prasad Joshi
2014-03-25 20:25 ` [Qemu-devel] " Prasad Joshi
2014-03-25 21:19 ` [Qemu-trivial] for 2.0: " Eric Blake
2014-03-25 21:19 ` [Qemu-devel] " Eric Blake
2014-03-26 8:57 ` [Qemu-trivial] " Stefan Hajnoczi
2014-03-26 8:57 ` [Qemu-devel] " Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.