All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Bächler" <thomas@archlinux.org>
To: tj@kernel.org
Cc: d@falconindy.com, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, P@draigbrady.com,
	alexandre.f.demers@gmail.com,
	"Thomas Bächler" <thomas@archlinux.org>,
	"3.14" <stable@vger.kernel.org>
Subject: [PATCH] fs: Don't return 0 from get_anon_bdev
Date: Thu,  3 Apr 2014 21:49:55 +0200	[thread overview]
Message-ID: <1396554595-11796-1-git-send-email-thomas@archlinux.org> (raw)
In-Reply-To: <20140403191617.GB2472@mtj.dyndns.org>

Commit 9e30cc9595303b27b48 removed an internal mount. This
has the side-effect that rootfs now has FSID 0. Many
userspace utilities assume that st_dev in struct stat
is never 0, so this change breaks a number of tools in
early userspace.

Since we don't know how many userspace programs are affected,
make sure that FSID is at least 1.

References: http://article.gmane.org/gmane.linux.kernel/1666905
References: http://permalink.gmane.org/gmane.linux.utilities.util-linux-ng/8557
Cc: 3.14 <stable@vger.kernel.org>
Signed-off-by: Thomas Bächler <thomas@archlinux.org>
---
 fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/super.c b/fs/super.c
index 80d5cf2..d9fddde 100644
--- a/fs/super.c
+++ b/fs/super.c
@@ -802,7 +802,7 @@ void emergency_remount(void)
 
 static DEFINE_IDA(unnamed_dev_ida);
 static DEFINE_SPINLOCK(unnamed_dev_lock);/* protects the above */
-static int unnamed_dev_start = 0; /* don't bother trying below it */
+static int unnamed_dev_start = 1; /* don't bother trying below it */
 
 int get_anon_bdev(dev_t *p)
 {
-- 
1.9.1


  parent reply	other threads:[~2014-04-03 19:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 17:57 Initramfs FSID altered in 3.14 Dave Reisner
2014-04-03 18:13 ` Thomas Bächler
2014-04-03 19:16   ` Tejun Heo
2014-04-03 19:20     ` Theodore Ts'o
2014-04-03 22:02       ` Alexandre Demers
2014-04-03 19:49     ` Thomas Bächler [this message]
2014-04-03 19:51       ` [PATCH] fs: Don't return 0 from get_anon_bdev Tejun Heo
2014-04-03 19:51         ` Tejun Heo
2014-04-03 19:55         ` [PATCHv2] " Thomas Bächler
2014-04-03 20:32           ` Greg KH
2014-04-03 20:32             ` Greg KH
2014-04-03 20:21       ` [PATCH] " H. Peter Anvin
2014-04-03 23:41       ` Alexandre Demers
2014-04-03 18:57 ` Initramfs FSID altered in 3.14 Pádraig Brady
2014-04-03 19:13 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396554595-11796-1-git-send-email-thomas@archlinux.org \
    --to=thomas@archlinux.org \
    --cc=P@draigbrady.com \
    --cc=alexandre.f.demers@gmail.com \
    --cc=d@falconindy.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.