From: "Pádraig Brady" <P@draigBrady.com>
To: Dave Reisner <d@falconindy.com>
Cc: linux-kernel@vger.kernel.org, tj@kernel.org
Subject: Re: Initramfs FSID altered in 3.14
Date: Thu, 03 Apr 2014 19:57:31 +0100 [thread overview]
Message-ID: <533DAF1B.1070502@draigBrady.com> (raw)
In-Reply-To: <20140403175744.GE585@rampage>
On 04/03/2014 06:57 PM, Dave Reisner wrote:
> Hi,
>
> [This is a repost of a G+ post at Tejun's request]
>
> With Linux 3.14, you might notice in /proc/self/mountinfo that your
> root's parent FSID is now 0, instead of the 1 that it's been for the
> last N years. Tejun wrote the change (9e30cc9595303b27b48) that caused
> this, but the change comes in a rather innocuous way. Instead of an
> internal kernel mount of sysfs being assigned 0, it's now the initramfs.
>
> So far, this has already caused switch_root and findmnt (from
> util-linux) to break, cp (from coreutils) to break when using the -x
> flag in early userspace, and it's also been pointed out that systemd's
> readahead code makes assumptions about a device number of 0.
For reference we've changed coreutils not to assume 0 is an invalid device ID:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commit;h=d0294ff3
> Are we now supposed to go and change all the assumptions in userspace
> about 0 being special? I'm conflicted. The kernel isn't supposed to
> break userspace, but it seems to me that FSIDs were never something to
> rely on -- similar to the block device numbering scheme.
I would say the kernel doesn't care what the value is,
so to ease compat worries just use >= 1.
cheers,
Pádraig
next prev parent reply other threads:[~2014-04-03 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 17:57 Initramfs FSID altered in 3.14 Dave Reisner
2014-04-03 18:13 ` Thomas Bächler
2014-04-03 19:16 ` Tejun Heo
2014-04-03 19:20 ` Theodore Ts'o
2014-04-03 22:02 ` Alexandre Demers
2014-04-03 19:49 ` [PATCH] fs: Don't return 0 from get_anon_bdev Thomas Bächler
2014-04-03 19:51 ` Tejun Heo
2014-04-03 19:51 ` Tejun Heo
2014-04-03 19:55 ` [PATCHv2] " Thomas Bächler
2014-04-03 20:32 ` Greg KH
2014-04-03 20:32 ` Greg KH
2014-04-03 20:21 ` [PATCH] " H. Peter Anvin
2014-04-03 23:41 ` Alexandre Demers
2014-04-03 18:57 ` Pádraig Brady [this message]
2014-04-03 19:13 ` Initramfs FSID altered in 3.14 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533DAF1B.1070502@draigBrady.com \
--to=p@draigbrady.com \
--cc=d@falconindy.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.