* [PATCH] ASoC: cs42l52: Fix mask for REVID
@ 2014-04-05 16:04 Axel Lin
2014-04-05 16:52 ` Austin, Brian
2014-04-07 9:48 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-04-05 16:04 UTC (permalink / raw)
To: Mark Brown; +Cc: Brian Austin, alsa-devel, Liam Girdwood, Paul Handrigan
BIT[0:2] of register 01h is REVID, so the mask for REVID should be 0x7.
Also updates the code to use CS42L52_CHIP_REV_MASK.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/cs42l52.c | 2 +-
sound/soc/codecs/cs42l52.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cs42l52.c b/sound/soc/codecs/cs42l52.c
index f0ca6be..460d355 100644
--- a/sound/soc/codecs/cs42l52.c
+++ b/sound/soc/codecs/cs42l52.c
@@ -1259,7 +1259,7 @@ static int cs42l52_i2c_probe(struct i2c_client *i2c_client,
}
dev_info(&i2c_client->dev, "Cirrus Logic CS42L52, Revision: %02X\n",
- reg & 0xFF);
+ reg & CS42L52_CHIP_REV_MASK);
/* Set Platform Data */
if (cs42l52->pdata.mica_diff_cfg)
diff --git a/sound/soc/codecs/cs42l52.h b/sound/soc/codecs/cs42l52.h
index 6fb8f00..ac445993 100644
--- a/sound/soc/codecs/cs42l52.h
+++ b/sound/soc/codecs/cs42l52.h
@@ -37,7 +37,7 @@
#define CS42L52_CHIP_REV_A0 0x00
#define CS42L52_CHIP_REV_A1 0x01
#define CS42L52_CHIP_REV_B0 0x02
-#define CS42L52_CHIP_REV_MASK 0x03
+#define CS42L52_CHIP_REV_MASK 0x07
#define CS42L52_PWRCTL1 0x02
#define CS42L52_PWRCTL1_PDN_ALL 0x9F
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cs42l52: Fix mask for REVID
2014-04-05 16:04 [PATCH] ASoC: cs42l52: Fix mask for REVID Axel Lin
@ 2014-04-05 16:52 ` Austin, Brian
2014-04-07 9:48 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Austin, Brian @ 2014-04-05 16:52 UTC (permalink / raw)
To: Axel Lin
Cc: alsa-devel@alsa-project.org, Mark Brown, Liam Girdwood,
Handrigan, Paul
> On Apr 5, 2014, at 11:04, "Axel Lin" <axel.lin@ingics.com> wrote:
>
> BIT[0:2] of register 01h is REVID, so the mask for REVID should be 0x7.
> Also updates the code to use CS42L52_CHIP_REV_MASK.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
Acked-by: Brian Austin <brian.austin@cirrus.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cs42l52: Fix mask for REVID
2014-04-05 16:04 [PATCH] ASoC: cs42l52: Fix mask for REVID Axel Lin
2014-04-05 16:52 ` Austin, Brian
@ 2014-04-07 9:48 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-04-07 9:48 UTC (permalink / raw)
To: Axel Lin; +Cc: Brian Austin, alsa-devel, Liam Girdwood, Paul Handrigan
[-- Attachment #1.1: Type: text/plain, Size: 204 bytes --]
On Sun, Apr 06, 2014 at 12:04:35AM +0800, Axel Lin wrote:
> BIT[0:2] of register 01h is REVID, so the mask for REVID should be 0x7.
> Also updates the code to use CS42L52_CHIP_REV_MASK.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-07 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-05 16:04 [PATCH] ASoC: cs42l52: Fix mask for REVID Axel Lin
2014-04-05 16:52 ` Austin, Brian
2014-04-07 9:48 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.