All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] GFS2: Pull request (merge window)
Date: Mon, 07 Apr 2014 10:31:54 +0100	[thread overview]
Message-ID: <1396863114.3770.7.camel@menhir> (raw)
In-Reply-To: <CA+55aFymkWynOvTurAy5savDSPXWL7AkS=5ax7HE_h3O0phwXw@mail.gmail.com>

Hi,

On Fri, 2014-04-04 at 14:52 -0700, Linus Torvalds wrote:
> On Tue, Apr 1, 2014 at 4:15 PM, Steven Whitehouse <swhiteho@redhat.com> wrote:
> >
> > Please consider pulling the following changes
> 
> This pull request is also missing shortlog and diffstat, like Jeff
> Layton's did. Did we have some tooling failure, or is it just
> coincidence?
> 
> Please, guys, make sure your pull requests are valid. I've pulled this
> one too, but..
> 
>                Linus

Sorry for the delay. I'd just been travelling for a few days and I
didn't have remote access to the box I used to generated the pull
request. Now that I've been able to have a look at the bash history, I
can see what has happened....

git request-pull gfs2-merge-window git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-nmw.git >my.pull

What what I'd used to generate the request. Which is incorrect in that
it should have been:

git request-pull master git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-nmw.git gfs2-merge-window >my.pull

but it seems by putting the arguments in the wrong order, I still got a
pull request generated, but without the diffstat, which is probably why
I didn't spot my mistake.

Anyway, apologies for having messed this up - I'll make a note to check
this in future,

Steve




WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	cluster-devel@redhat.com
Subject: Re: GFS2: Pull request (merge window)
Date: Mon, 07 Apr 2014 10:31:54 +0100	[thread overview]
Message-ID: <1396863114.3770.7.camel@menhir> (raw)
In-Reply-To: <CA+55aFymkWynOvTurAy5savDSPXWL7AkS=5ax7HE_h3O0phwXw@mail.gmail.com>

Hi,

On Fri, 2014-04-04 at 14:52 -0700, Linus Torvalds wrote:
> On Tue, Apr 1, 2014 at 4:15 PM, Steven Whitehouse <swhiteho@redhat.com> wrote:
> >
> > Please consider pulling the following changes
> 
> This pull request is also missing shortlog and diffstat, like Jeff
> Layton's did. Did we have some tooling failure, or is it just
> coincidence?
> 
> Please, guys, make sure your pull requests are valid. I've pulled this
> one too, but..
> 
>                Linus

Sorry for the delay. I'd just been travelling for a few days and I
didn't have remote access to the box I used to generated the pull
request. Now that I've been able to have a look at the bash history, I
can see what has happened....

git request-pull gfs2-merge-window git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-nmw.git >my.pull

What what I'd used to generate the request. Which is incorrect in that
it should have been:

git request-pull master git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-nmw.git gfs2-merge-window >my.pull

but it seems by putting the arguments in the wrong order, I still got a
pull request generated, but without the diffstat, which is probably why
I didn't spot my mistake.

Anyway, apologies for having messed this up - I'll make a note to check
this in future,

Steve



  reply	other threads:[~2014-04-07  9:31 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 23:15 [Cluster-devel] GFS2: Pull request (merge window) Steven Whitehouse
2014-04-01 23:15 ` Steven Whitehouse
2014-04-04 21:52 ` [Cluster-devel] " Linus Torvalds
2014-04-04 21:52   ` Linus Torvalds
2014-04-07  9:31   ` Steven Whitehouse [this message]
2014-04-07  9:31     ` Steven Whitehouse
     [not found] <2063498114.10752149.1552067836491.JavaMail.zimbra@redhat.com>
2019-03-08 17:58 ` [Cluster-devel] " Bob Peterson
     [not found] <180051537.56890898.1545229879645.JavaMail.zimbra@redhat.com>
2018-12-19 14:31 ` Bob Peterson
     [not found] <1929897739.23623737.1540322729596.JavaMail.zimbra@redhat.com>
2018-10-23 19:26 ` Bob Peterson
2018-10-24 16:35   ` Linus Torvalds
2018-10-24 16:41     ` Bob Peterson
     [not found] <1772901878.39899227.1528134744434.JavaMail.zimbra@redhat.com>
2018-06-04 17:53 ` Bob Peterson
     [not found] <242799785.15741010.1522776740239.JavaMail.zimbra@redhat.com>
2018-04-03 17:32 ` Bob Peterson
     [not found] <2035999397.5567269.1517410350526.JavaMail.zimbra@redhat.com>
2018-01-31 14:54 ` Bob Peterson
     [not found] <800692691.31850756.1510678641181.JavaMail.zimbra@redhat.com>
2017-11-14 16:57 ` Bob Peterson
2017-11-14 17:17   ` Bob Peterson
     [not found] <1332965725.6958432.1504544624096.JavaMail.zimbra@redhat.com>
2017-09-04 17:05 ` Bob Peterson
     [not found] <2018468119.28735933.1499259957760.JavaMail.zimbra@redhat.com>
2017-07-05 13:08 ` Bob Peterson
     [not found] <909713995.4565875.1494016018520.JavaMail.zimbra@redhat.com>
2017-05-05 20:28 ` Bob Peterson
2017-05-05 21:07   ` Linus Torvalds
     [not found] <1526627784.3659456.1493822813354.JavaMail.zimbra@redhat.com>
2017-05-03 16:41 ` Bob Peterson
     [not found] <468087826.25173671.1487684421990.JavaMail.zimbra@redhat.com>
2017-02-21 13:41 ` Bob Peterson
     [not found] <1872743029.687446.1475513532790.JavaMail.zimbra@redhat.com>
2016-10-03 16:52 ` Bob Peterson
     [not found] <404724578.17300814.1469208769730.JavaMail.zimbra@redhat.com>
2016-07-22 17:33 ` Bob Peterson
     [not found] <2074855986.8621406.1463772170266.JavaMail.zimbra@redhat.com>
2016-05-20 19:23 ` Bob Peterson
     [not found] <2094757318.39162844.1458219077321.JavaMail.zimbra@redhat.com>
2016-03-17 12:51 ` Bob Peterson
     [not found] <1243871936.8427302.1452623511952.JavaMail.zimbra@redhat.com>
2016-01-12 18:34 ` Bob Peterson
     [not found] <337313427.7367463.1447086799887.JavaMail.zimbra@redhat.com>
2015-11-09 16:45 ` Bob Peterson
     [not found] <987432592.26261269.1441889826020.JavaMail.zimbra@redhat.com>
2015-09-10 13:19 ` Bob Peterson
     [not found] <1946368926.25134466.1435330524247.JavaMail.zimbra@redhat.com>
2015-06-26 14:56 ` Bob Peterson
     [not found] <1305736412.15685734.1429033600005.JavaMail.zimbra@redhat.com>
2015-04-14 17:47 ` Bob Peterson
2015-04-14 23:16   ` Linus Torvalds
2015-04-15  7:34     ` Steven Whitehouse
2015-04-14 23:19   ` Linus Torvalds
2015-04-15 12:09     ` Bob Peterson
  -- strict thread matches above, loose matches on Subject: below --
2015-02-10 11:04 Steven Whitehouse
2014-12-08 18:26 Steven Whitehouse
2014-10-08 19:25 Steven Whitehouse
2014-06-04  9:33 Steven Whitehouse
2014-01-20 19:15 Steven Whitehouse
2013-11-05 15:39 Steven Whitehouse
2013-09-09  9:22 Steven Whitehouse
2013-07-01 15:20 Steven Whitehouse
2013-04-29 11:08 Steven Whitehouse
2013-02-19 16:38 Steven Whitehouse
2012-12-11 10:39 Steven Whitehouse
2012-09-13 13:42 [Cluster-devel] GFS2: Pull request (fixes) Steven Whitehouse
2012-10-01  9:09 ` [Cluster-devel] GFS2: Pull request (merge window) Steven Whitehouse
2012-07-23 14:59 Steven Whitehouse
2012-08-03  1:22 ` Linus Torvalds
2012-08-03 10:18   ` Steven Whitehouse
2012-08-03 16:16     ` Linus Torvalds
2012-05-21  8:17 Steven Whitehouse
2012-03-20 16:10 Steven Whitehouse
2012-01-06 12:09 Steven Whitehouse
2011-10-25  8:41 Steven Whitehouse
2011-07-22 12:08 Steven Whitehouse
2011-05-20  8:14 Steven Whitehouse
2011-03-16 13:55 Steven Whitehouse
2011-01-05 10:22 Steven Whitehouse
2010-10-21  9:43 Steven Whitehouse
2010-08-03  9:06 Steven Whitehouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396863114.3770.7.camel@menhir \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.