From: Mark Salter <msalter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: Leif Lindholm
<leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Catalin Marinas <Catalin.Marinas-5wv7dgnIgG8@public.gmane.org>,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 06/10] arm64: efi: add EFI stub
Date: Thu, 10 Apr 2014 08:54:02 -0400 [thread overview]
Message-ID: <1397134442.31272.38.camel@deneb.redhat.com> (raw)
In-Reply-To: <20140409142013.GC26210-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
On Wed, 2014-04-09 at 15:20 +0100, Mark Rutland wrote:
> >
> > +config EFI
> > + bool "UEFI firmware support"
> > + depends on OF
>
> I note we're not depending on !CPU_BIG_ENDIAN here, and it looks like
> the implementation is not endian-clean (I've pointed out a few issues
> below).
>
> We need to fix that up for CPU_BIG_ENDIAN. For the moment we could
> depend on !CPU_BIG_ENDIAN which would at least to make it clear we don't
> support EFI && CPU_BIG_ENDIAN yet. The commit message should be updated
> to mention that.
>
Yes, the !CPU_BIG_ENDIAN was there at one point but got lost along
the way. It may be best to put it back for now, but I'll take a
stab at getting the stub part sorted out based on your comments.
Full runtime services will be trickier and need a followup patch in
the future after the initial patch series goes in.
WARNING: multiple messages have this Message-ID (diff)
From: msalter@redhat.com (Mark Salter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 06/10] arm64: efi: add EFI stub
Date: Thu, 10 Apr 2014 08:54:02 -0400 [thread overview]
Message-ID: <1397134442.31272.38.camel@deneb.redhat.com> (raw)
In-Reply-To: <20140409142013.GC26210@e106331-lin.cambridge.arm.com>
On Wed, 2014-04-09 at 15:20 +0100, Mark Rutland wrote:
> >
> > +config EFI
> > + bool "UEFI firmware support"
> > + depends on OF
>
> I note we're not depending on !CPU_BIG_ENDIAN here, and it looks like
> the implementation is not endian-clean (I've pointed out a few issues
> below).
>
> We need to fix that up for CPU_BIG_ENDIAN. For the moment we could
> depend on !CPU_BIG_ENDIAN which would at least to make it clear we don't
> support EFI && CPU_BIG_ENDIAN yet. The commit message should be updated
> to mention that.
>
Yes, the !CPU_BIG_ENDIAN was there at one point but got lost along
the way. It may be best to put it back for now, but I'll take a
stab at getting the stub part sorted out based on your comments.
Full runtime services will be trickier and need a followup patch in
the future after the initial patch series goes in.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salter <msalter@redhat.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Matt Fleming <matt.fleming@intel.com>
Subject: Re: [PATCH v3 06/10] arm64: efi: add EFI stub
Date: Thu, 10 Apr 2014 08:54:02 -0400 [thread overview]
Message-ID: <1397134442.31272.38.camel@deneb.redhat.com> (raw)
In-Reply-To: <20140409142013.GC26210@e106331-lin.cambridge.arm.com>
On Wed, 2014-04-09 at 15:20 +0100, Mark Rutland wrote:
> >
> > +config EFI
> > + bool "UEFI firmware support"
> > + depends on OF
>
> I note we're not depending on !CPU_BIG_ENDIAN here, and it looks like
> the implementation is not endian-clean (I've pointed out a few issues
> below).
>
> We need to fix that up for CPU_BIG_ENDIAN. For the moment we could
> depend on !CPU_BIG_ENDIAN which would at least to make it clear we don't
> support EFI && CPU_BIG_ENDIAN yet. The commit message should be updated
> to mention that.
>
Yes, the !CPU_BIG_ENDIAN was there at one point but got lost along
the way. It may be best to put it back for now, but I'll take a
stab at getting the stub part sorted out based on your comments.
Full runtime services will be trickier and need a followup patch in
the future after the initial patch series goes in.
next prev parent reply other threads:[~2014-04-10 12:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 18:45 [PATCH v3 00/10] arm64: UEFI support Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` [PATCH v3 01/10] lib: add fdt_empty_tree.c Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` [PATCH v3 02/10] doc: efi-stub.txt updates for ARM Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` [PATCH v3 03/10] efi: add helper function to get UEFI params from FDT Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` [PATCH v3 04/10] arm64: Add function to create identity mappings Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
[not found] ` <1396637113-22790-1-git-send-email-leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-04-04 18:45 ` [PATCH v3 05/10] efi: Add shared FDT related functions for ARM/ARM64 Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` [PATCH v3 06/10] arm64: efi: add EFI stub Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-09 14:20 ` Mark Rutland
2014-04-09 14:20 ` Mark Rutland
2014-04-09 14:20 ` Mark Rutland
[not found] ` <20140409142013.GC26210-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-04-10 12:54 ` Mark Salter [this message]
2014-04-10 12:54 ` Mark Salter
2014-04-10 12:54 ` Mark Salter
2017-02-08 16:28 ` Timur Tabi
2017-02-08 16:28 ` Timur Tabi
2017-02-08 16:28 ` Timur Tabi
2017-02-08 16:29 ` Ard Biesheuvel
2017-02-08 16:29 ` Ard Biesheuvel
2017-02-08 16:35 ` Timur Tabi
2017-02-08 16:35 ` Timur Tabi
2017-02-08 16:35 ` Timur Tabi
2017-02-08 17:03 ` Mark Rutland
2017-02-08 17:03 ` Mark Rutland
2017-02-08 17:03 ` Mark Rutland
2017-02-08 17:22 ` Jeffrey Hugo
2017-02-08 17:22 ` Jeffrey Hugo
2017-02-08 17:22 ` Jeffrey Hugo
2017-02-08 17:30 ` Jeffrey Hugo
2017-02-08 17:30 ` Jeffrey Hugo
2017-02-08 17:30 ` Jeffrey Hugo
2017-02-08 17:34 ` Mark Rutland
2017-02-08 17:34 ` Mark Rutland
2017-02-08 17:34 ` Mark Rutland
2017-02-08 17:40 ` Ard Biesheuvel
2017-02-08 17:40 ` Ard Biesheuvel
2017-02-08 17:40 ` Ard Biesheuvel
2014-04-04 18:45 ` [PATCH v3 07/10] doc: arm64: add description of EFI stub support Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` [PATCH v3 08/10] arm64: add EFI runtime services Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` [PATCH v3 09/10] doc: arm: add UEFI support documentation Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
2014-04-04 18:45 ` [PATCH v3 10/10] efi/arm64: ignore dtb= when UEFI SecureBoot is enabled Leif Lindholm
2014-04-04 18:45 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397134442.31272.38.camel@deneb.redhat.com \
--to=msalter-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=Catalin.Marinas-5wv7dgnIgG8@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.