All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: xen-devel@lists.xen.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	ian.jackson@eu.citrix.com, ian.campbell@citrix.com
Subject: [PATCH RFC 2/9] libxl_json: introduce libx__object_from_json
Date: Thu, 10 Apr 2014 16:40:15 +0100	[thread overview]
Message-ID: <1397144422-18906-4-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1397144422-18906-1-git-send-email-wei.liu2@citrix.com>

Given a JSON string, we need to convert it to libxl_FOO struct.

The approach is:
JSON string -> libxl__json_object -> libxl_FOO struct

With this approach we can make use of libxl's infrastructure to do the
first half (JSON string -> libxl__json_object).

Second half is done by auto-generated code by libxl's IDL
infrastructure. IDL patch(es) will come later.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
 tools/libxl/libxl_internal.h |    9 +++++++++
 tools/libxl/libxl_json.c     |   34 ++++++++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+)

diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index b3a200d..34b6a26 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1494,6 +1494,15 @@ typedef yajl_gen_status (*libxl__gen_json_callback)(yajl_gen hand, void *);
 _hidden char *libxl__object_to_json(libxl_ctx *ctx, const char *type,
                                     libxl__gen_json_callback gen, void *p);
 
+typedef struct libxl__json_object libxl__json_object;
+typedef int (*libxl__parse_json_callback)(libxl_ctx *ctx,
+                                          libxl__json_object *o,
+                                          void *p);
+_hidden int libxl__object_from_json(libxl_ctx *ctx, const char *type,
+                                    libxl__parse_json_callback parse,
+                                    void *p,
+                                    const char *s);
+
   /* holds the CPUID response for a single CPUID leaf
    * input contains the value of the EAX and ECX register,
    * and each policy string contains a filter to apply to
diff --git a/tools/libxl/libxl_json.c b/tools/libxl/libxl_json.c
index 3ea56a4..002ae2d 100644
--- a/tools/libxl/libxl_json.c
+++ b/tools/libxl/libxl_json.c
@@ -794,6 +794,40 @@ out:
     return ret;
 }
 
+int libxl__object_from_json(libxl_ctx *ctx, const char *type,
+                            libxl__parse_json_callback parse,
+                            void *p, const char *s)
+{
+    GC_INIT(ctx);
+    libxl__json_object *o = NULL;
+    int ret;
+
+    o = libxl__json_parse(gc, s);
+
+    if (!o) {
+        LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
+                   "unable to generate libxl__json_object from JSON representation for %s.",
+                   type);
+        ret = -1;
+        goto out;
+    }
+
+    ret = parse(ctx, o, p);
+
+    if (ret) {
+        LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
+                   "unable to convert libxl__json_object to %s.",
+                   type);
+        ret = -1;
+        goto out;
+    }
+
+    ret = 0;
+out:
+    GC_FREE;
+    return ret;
+}
+
 /*
  * Local variables:
  * mode: C
-- 
1.7.10.4

  parent reply	other threads:[~2014-04-10 15:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 15:40 [PATCH RFC 0/9] libxl: JSON infrastructure improvement Wei Liu
2014-04-10 15:40 ` [PATCH RFC 1/9] libxl IDL: rename json_fn to json_gen_fn Wei Liu
2014-04-14 16:55   ` Ian Campbell
2014-04-10 15:40 ` [PATCH RFC 2/9] libxl_json: function to convert JSON object to libxl object Wei Liu
2014-04-10 15:40 ` Wei Liu [this message]
2014-04-14 16:59   ` [PATCH RFC 2/9] libxl_json: introduce libx__object_from_json Ian Campbell
2014-04-15  9:19     ` Wei Liu
2014-04-15  9:24       ` Ian Campbell
2014-04-10 15:40 ` [PATCH RFC 3/9] libxl_internal: make JSON_* types or-able Wei Liu
2014-04-14 17:03   ` Ian Campbell
2014-04-15  9:22     ` Wei Liu
2014-04-10 15:40 ` [PATCH RFC 4/9] libxl_internal: introduce libxl__json_object_is_{null, number, double} Wei Liu
2014-04-14 17:04   ` Ian Campbell
2014-04-15  9:29     ` Wei Liu
2014-04-15  9:35       ` Ian Campbell
2014-04-10 15:40 ` [PATCH RFC 5/9] libxl_json: introduce parser functions for builtin types Wei Liu
2014-04-10 15:40 ` [PATCH RFC 6/9] libxl_json: allow basic JSON type objects generation Wei Liu
2014-04-10 15:40 ` [PATCH RFC 7/9] libxl/gentypes.py: generate JSON object for keyed-union discriminator Wei Liu
2014-04-10 15:40 ` [PATCH RFC 8/9] libxl IDL: generate code to parse libxl__json_object to libxl_FOO struct Wei Liu
2014-04-10 15:40 ` [PATCH RFC 9/9] libxl/gentest.py: test JSON parser Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397144422-18906-4-git-send-email-wei.liu2@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.