From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH RFC 4/9] libxl_internal: introduce libxl__json_object_is_{null, number, double}
Date: Mon, 14 Apr 2014 18:04:27 +0100 [thread overview]
Message-ID: <1397495067.7802.29.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <1397144422-18906-6-git-send-email-wei.liu2@citrix.com>
On Thu, 2014-04-10 at 16:40 +0100, Wei Liu wrote:
> ... which return true if json object is valid and of type
> JSON_{NULL,NUMBER,DOUBLE}.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
But...
> +static inline bool libxl__json_object_is_null(const libxl__json_object *o)
> +{
> + return o != NULL && o->type == JSON_NULL;
Shouldn't these (new and existing) use the bit field stuff you just
introduced?
Ian.
next prev parent reply other threads:[~2014-04-14 17:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 15:40 [PATCH RFC 0/9] libxl: JSON infrastructure improvement Wei Liu
2014-04-10 15:40 ` [PATCH RFC 1/9] libxl IDL: rename json_fn to json_gen_fn Wei Liu
2014-04-14 16:55 ` Ian Campbell
2014-04-10 15:40 ` [PATCH RFC 2/9] libxl_json: function to convert JSON object to libxl object Wei Liu
2014-04-10 15:40 ` [PATCH RFC 2/9] libxl_json: introduce libx__object_from_json Wei Liu
2014-04-14 16:59 ` Ian Campbell
2014-04-15 9:19 ` Wei Liu
2014-04-15 9:24 ` Ian Campbell
2014-04-10 15:40 ` [PATCH RFC 3/9] libxl_internal: make JSON_* types or-able Wei Liu
2014-04-14 17:03 ` Ian Campbell
2014-04-15 9:22 ` Wei Liu
2014-04-10 15:40 ` [PATCH RFC 4/9] libxl_internal: introduce libxl__json_object_is_{null, number, double} Wei Liu
2014-04-14 17:04 ` Ian Campbell [this message]
2014-04-15 9:29 ` Wei Liu
2014-04-15 9:35 ` Ian Campbell
2014-04-10 15:40 ` [PATCH RFC 5/9] libxl_json: introduce parser functions for builtin types Wei Liu
2014-04-10 15:40 ` [PATCH RFC 6/9] libxl_json: allow basic JSON type objects generation Wei Liu
2014-04-10 15:40 ` [PATCH RFC 7/9] libxl/gentypes.py: generate JSON object for keyed-union discriminator Wei Liu
2014-04-10 15:40 ` [PATCH RFC 8/9] libxl IDL: generate code to parse libxl__json_object to libxl_FOO struct Wei Liu
2014-04-10 15:40 ` [PATCH RFC 9/9] libxl/gentest.py: test JSON parser Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397495067.7802.29.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.