* [PATCH] gpio: kempld: Fix autoloading of module
@ 2014-04-12 4:45 Axel Lin
2014-04-12 16:58 ` Guenter Roeck
2014-04-22 21:44 ` Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2014-04-12 4:45 UTC (permalink / raw)
To: Linus Walleij
Cc: Michael Brunner, Guenter Roeck, Alexandre Courbot, linux-gpio
Make the module alias match the platform device name, so gpio-kempld module
should now autoload correctly.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-kempld.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
index c6d8817..ebe1023 100644
--- a/drivers/gpio/gpio-kempld.c
+++ b/drivers/gpio/gpio-kempld.c
@@ -216,4 +216,4 @@ module_platform_driver(kempld_gpio_driver);
MODULE_DESCRIPTION("KEM PLD GPIO Driver");
MODULE_AUTHOR("Michael Brunner <michael.brunner@kontron.com>");
MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:gpio-kempld");
+MODULE_ALIAS("platform:kempld-gpio");
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: kempld: Fix autoloading of module
2014-04-12 4:45 [PATCH] gpio: kempld: Fix autoloading of module Axel Lin
@ 2014-04-12 16:58 ` Guenter Roeck
2014-04-15 23:46 ` Axel Lin
2014-04-22 21:44 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2014-04-12 16:58 UTC (permalink / raw)
To: Axel Lin, Linus Walleij; +Cc: Michael Brunner, Alexandre Courbot, linux-gpio
On 04/11/2014 09:45 PM, Axel Lin wrote:
> Make the module alias match the platform device name, so gpio-kempld module
> should now autoload correctly.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/gpio-kempld.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
> index c6d8817..ebe1023 100644
> --- a/drivers/gpio/gpio-kempld.c
> +++ b/drivers/gpio/gpio-kempld.c
> @@ -216,4 +216,4 @@ module_platform_driver(kempld_gpio_driver);
> MODULE_DESCRIPTION("KEM PLD GPIO Driver");
> MODULE_AUTHOR("Michael Brunner <michael.brunner@kontron.com>");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:gpio-kempld");
> +MODULE_ALIAS("platform:kempld-gpio");
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Wonder though if the module alias is necessary in the first place,
as the driver is instantiated from the mfd driver.
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gpio: kempld: Fix autoloading of module
2014-04-12 16:58 ` Guenter Roeck
@ 2014-04-15 23:46 ` Axel Lin
0 siblings, 0 replies; 4+ messages in thread
From: Axel Lin @ 2014-04-15 23:46 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linus Walleij, Michael Brunner, Alexandre Courbot,
linux-gpio@vger.kernel.org
2014-04-13 0:58 GMT+08:00 Guenter Roeck <linux@roeck-us.net>:
> On 04/11/2014 09:45 PM, Axel Lin wrote:
>>
>> Make the module alias match the platform device name, so gpio-kempld
>> module
>> should now autoload correctly.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> drivers/gpio/gpio-kempld.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
>> index c6d8817..ebe1023 100644
>> --- a/drivers/gpio/gpio-kempld.c
>> +++ b/drivers/gpio/gpio-kempld.c
>> @@ -216,4 +216,4 @@ module_platform_driver(kempld_gpio_driver);
>> MODULE_DESCRIPTION("KEM PLD GPIO Driver");
>> MODULE_AUTHOR("Michael Brunner <michael.brunner@kontron.com>");
>> MODULE_LICENSE("GPL");
>> -MODULE_ALIAS("platform:gpio-kempld");
>> +MODULE_ALIAS("platform:kempld-gpio");
>>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
> Wonder though if the module alias is necessary in the first place,
> as the driver is instantiated from the mfd driver.
The mfd driver calls mfd_add_devices() to add kempld-gpio device.
In the case if kempld-gpio driver is built as a module and not yet
be loaded to the system, the module alias is required to make module
autoloading work.
Regards,
Axel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gpio: kempld: Fix autoloading of module
2014-04-12 4:45 [PATCH] gpio: kempld: Fix autoloading of module Axel Lin
2014-04-12 16:58 ` Guenter Roeck
@ 2014-04-22 21:44 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2014-04-22 21:44 UTC (permalink / raw)
To: Axel Lin
Cc: Michael Brunner, Guenter Roeck, Alexandre Courbot,
linux-gpio@vger.kernel.org
On Sat, Apr 12, 2014 at 6:45 AM, Axel Lin <axel.lin@ingics.com> wrote:
> Make the module alias match the platform device name, so gpio-kempld module
> should now autoload correctly.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied with Günther's Review tag.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-22 21:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-12 4:45 [PATCH] gpio: kempld: Fix autoloading of module Axel Lin
2014-04-12 16:58 ` Guenter Roeck
2014-04-15 23:46 ` Axel Lin
2014-04-22 21:44 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.