From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
anton@samba.org
Subject: Re: [PATCH 1/1] powerpc: Increase COMMAND_LINE_SIZE to 2048 from 512.
Date: Tue, 15 Apr 2014 19:49:23 +1000 [thread overview]
Message-ID: <1397555363.14218.6.camel@pasglop> (raw)
In-Reply-To: <534C2FEB.2000803@canonical.com>
On Mon, 2014-04-14 at 14:58 -0400, Joseph Salisbury wrote:
>
> After further review, it appears ppc does not actually use the define
> in
> the ppc headers but uses the common generic
> default(include/uapi/asm-generic/setup.h). COMMAND_LINE_SIZE should
> probably become a kernel config option. Do folks agree that is the
> correct thing to do? If so, I can re-work the patch.
No objection on my side.
Make sure you remove any unused arch define while at it.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Joseph Salisbury <joseph.salisbury@canonical.com>
Cc: linux-kernel@vger.kernel.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org,
anton@samba.org
Subject: Re: [PATCH 1/1] powerpc: Increase COMMAND_LINE_SIZE to 2048 from 512.
Date: Tue, 15 Apr 2014 19:49:23 +1000 [thread overview]
Message-ID: <1397555363.14218.6.camel@pasglop> (raw)
In-Reply-To: <534C2FEB.2000803@canonical.com>
On Mon, 2014-04-14 at 14:58 -0400, Joseph Salisbury wrote:
>
> After further review, it appears ppc does not actually use the define
> in
> the ppc headers but uses the common generic
> default(include/uapi/asm-generic/setup.h). COMMAND_LINE_SIZE should
> probably become a kernel config option. Do folks agree that is the
> correct thing to do? If so, I can re-work the patch.
No objection on my side.
Make sure you remove any unused arch define while at it.
Cheers,
Ben.
next prev parent reply other threads:[~2014-04-15 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1397260361.git.joseph.salisbury@canonical.com>
2014-04-14 15:30 ` [PATCH 1/1] powerpc: Increase COMMAND_LINE_SIZE to 2048 from 512 Joseph Salisbury
2014-04-14 18:58 ` Joseph Salisbury
2014-04-14 18:58 ` Joseph Salisbury
2014-04-15 9:49 ` Benjamin Herrenschmidt [this message]
2014-04-15 9:49 ` Benjamin Herrenschmidt
2014-04-16 18:00 ` Joseph Salisbury
2014-04-16 18:00 ` Joseph Salisbury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397555363.14218.6.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=joseph.salisbury@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.