* [PATCH] ASoC: cs42l51: Fix mask for REVID
@ 2014-04-17 8:35 Axel Lin
2014-04-17 13:49 ` Brian Austin
2014-04-18 14:59 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-04-17 8:35 UTC (permalink / raw)
To: Mark Brown
Cc: Brian Austin, alsa-devel, Paul Handrigan, Arnaud Patard,
Liam Girdwood
The REVID mask was changed by commit a1253ef6d3fa
"ASoC: cs42l51: split i2c from codec driver". Fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/cs42l51.c | 3 ++-
sound/soc/codecs/cs42l51.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs42l51.c b/sound/soc/codecs/cs42l51.c
index dadc20d..09488d9 100644
--- a/sound/soc/codecs/cs42l51.c
+++ b/sound/soc/codecs/cs42l51.c
@@ -548,7 +548,8 @@ int cs42l51_probe(struct device *dev, struct regmap *regmap)
ret = -ENODEV;
goto error;
}
- dev_info(dev, "Cirrus Logic CS42L51, Revision: %02X\n", val & 0xFF);
+ dev_info(dev, "Cirrus Logic CS42L51, Revision: %02X\n",
+ val & CS42L51_CHIP_REV_MASK);
ret = snd_soc_register_codec(dev,
&soc_codec_device_cs42l51, &cs42l51_dai, 1);
diff --git a/sound/soc/codecs/cs42l51.h b/sound/soc/codecs/cs42l51.h
index 641ef18..8c55bf3 100644
--- a/sound/soc/codecs/cs42l51.h
+++ b/sound/soc/codecs/cs42l51.h
@@ -26,6 +26,7 @@ int cs42l51_probe(struct device *dev, struct regmap *regmap);
#define CS42L51_CHIP_ID 0x1B
#define CS42L51_CHIP_REV_A 0x00
#define CS42L51_CHIP_REV_B 0x01
+#define CS42L51_CHIP_REV_MASK 0x07
#define CS42L51_CHIP_REV_ID 0x01
#define CS42L51_MK_CHIP_REV(a, b) ((a)<<3|(b))
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cs42l51: Fix mask for REVID
2014-04-17 8:35 [PATCH] ASoC: cs42l51: Fix mask for REVID Axel Lin
@ 2014-04-17 13:49 ` Brian Austin
2014-04-18 14:59 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Brian Austin @ 2014-04-17 13:49 UTC (permalink / raw)
To: Axel Lin
Cc: alsa-devel, Brian Austin, Paul Handrigan, Liam Girdwood,
Mark Brown, Arnaud Patard
On Thu, 17 Apr 2014, Axel Lin wrote:
> The REVID mask was changed by commit a1253ef6d3fa
> "ASoC: cs42l51: split i2c from codec driver". Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Sorry about that.
Acked-by: Brian Austin <brian.austin@cirrus.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: cs42l51: Fix mask for REVID
2014-04-17 8:35 [PATCH] ASoC: cs42l51: Fix mask for REVID Axel Lin
2014-04-17 13:49 ` Brian Austin
@ 2014-04-18 14:59 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-04-18 14:59 UTC (permalink / raw)
To: Axel Lin
Cc: Brian Austin, alsa-devel, Paul Handrigan, Arnaud Patard,
Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 184 bytes --]
On Thu, Apr 17, 2014 at 04:35:43PM +0800, Axel Lin wrote:
> The REVID mask was changed by commit a1253ef6d3fa
> "ASoC: cs42l51: split i2c from codec driver". Fix it.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-18 14:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-17 8:35 [PATCH] ASoC: cs42l51: Fix mask for REVID Axel Lin
2014-04-17 13:49 ` Brian Austin
2014-04-18 14:59 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.