All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Shannon Nelson <shannon.nelson@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Catherine Sullivan <catherine.sullivan@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 10/16] i40e: prep vsi_open logic for non-netdev cases
Date: Tue, 22 Apr 2014 05:39:25 -0700	[thread overview]
Message-ID: <1398170371-3333-11-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1398170371-3333-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Shannon Nelson <shannon.nelson@intel.com>

Rearrange the "if netdev" logic slightly to get ready for handling
non-netdev VSIs.

Change-ID: Ia0bfe13d4c994a2351a3c31fe725b75caeb397ee
Signed-off-by: Shannon Nelson <shannon.nelson@intel.com>
Signed-off-by: Catherine Sullivan <catherine.sullivan@intel.com>
Tested-by: Kavindya Deegala <kavindya.s.deegala@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 33 ++++++++++++++++-------------
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 7beef10..7dda8b2 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -4306,24 +4306,27 @@ int i40e_vsi_open(struct i40e_vsi *vsi)
 	if (err)
 		goto err_setup_rx;
 
-	if (!vsi->netdev) {
+	if (vsi->netdev) {
+		snprintf(int_name, sizeof(int_name) - 1, "%s-%s",
+			 dev_driver_string(&pf->pdev->dev), vsi->netdev->name);
+		err = i40e_vsi_request_irq(vsi, int_name);
+		if (err)
+			goto err_setup_rx;
+
+		/* Notify the stack of the actual queue counts. */
+		err = netif_set_real_num_tx_queues(vsi->netdev,
+						   vsi->num_queue_pairs);
+		if (err)
+			goto err_set_queues;
+
+		err = netif_set_real_num_rx_queues(vsi->netdev,
+						   vsi->num_queue_pairs);
+		if (err)
+			goto err_set_queues;
+	} else {
 		err = EINVAL;
 		goto err_setup_rx;
 	}
-	snprintf(int_name, sizeof(int_name) - 1, "%s-%s",
-		 dev_driver_string(&pf->pdev->dev), vsi->netdev->name);
-	err = i40e_vsi_request_irq(vsi, int_name);
-	if (err)
-		goto err_setup_rx;
-
-	/* Notify the stack of the actual queue counts. */
-	err = netif_set_real_num_tx_queues(vsi->netdev, vsi->num_queue_pairs);
-	if (err)
-		goto err_set_queues;
-
-	err = netif_set_real_num_rx_queues(vsi->netdev, vsi->num_queue_pairs);
-	if (err)
-		goto err_set_queues;
 
 	err = i40e_up_complete(vsi);
 	if (err)
-- 
1.9.0

  parent reply	other threads:[~2014-04-22 12:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22 12:39 [net-next 00/16][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-04-22 12:39 ` [net-next 01/16] i40e: Add bridge FDB add/del/dump ops Jeff Kirsher
2014-04-22 12:39 ` [net-next 02/16] i40e/i40evf: unhide and enable to one prefena field Jeff Kirsher
2014-04-22 12:39 ` [net-next 03/16] i40e: Reset the VF upon conflicting VLAN configuration Jeff Kirsher
2014-04-22 12:39 ` [net-next 04/16] i40e: Enable VF Tx bandwidth setting Jeff Kirsher
2014-04-22 12:39 ` [net-next 05/16] i40e/i40evf: Bump build versions Jeff Kirsher
2014-04-22 12:39 ` [net-next 06/16] i40e: Remove a FW workaround Jeff Kirsher
2014-04-22 12:39 ` [net-next 07/16] i40e: Fix an issue with displaying IPv4 FD filters Jeff Kirsher
2014-04-22 12:39 ` [net-next 08/16] i40e/i40evf: add tracking to NVM busy state Jeff Kirsher
2014-04-22 12:39 ` [net-next 09/16] i40e/i40evf: update AdminQ API Jeff Kirsher
2014-04-22 12:39 ` Jeff Kirsher [this message]
2014-04-22 12:39 ` [net-next 11/16] i40e: abstract the close path for better netdev vsis Jeff Kirsher
2014-04-22 12:39 ` [net-next 12/16] i40e: use generic vsi_open to unquiesce vsi Jeff Kirsher
2014-04-22 12:39 ` [net-next 13/16] i40e: rework fdir setup and teardown Jeff Kirsher
2014-04-22 12:39 ` [net-next 14/16] i40e: Cleanup if/else statements Jeff Kirsher
2014-04-22 12:39 ` [net-next 15/16] i40e: Tweak for-loop in i40e_ethtool.c Jeff Kirsher
2014-04-22 12:39 ` [net-next 16/16] i40e/i40evf: Bump build versions Jeff Kirsher
2014-04-23  1:47 ` [net-next 00/16][pull request] Intel Wired LAN Driver Updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398170371-3333-11-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=catherine.sullivan@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    --cc=shannon.nelson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.