From: "Michal Malý" <madcatxster@devoid-pointer.net>
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, jkosina@suse.cz, elias.vds@gmail.com,
anssi.hannula@iki.fi, simon@mungewell.org,
"Michal Malý" <madcatxster@devoid-pointer.net>
Subject: [PATCH v4 04/24] input: Port twl6040-vibra to ff-memless-next
Date: Sat, 26 Apr 2014 13:57:41 +0200 [thread overview]
Message-ID: <1398513696-12626-5-git-send-email-madcatxster@devoid-pointer.net> (raw)
In-Reply-To: <1398513696-12626-1-git-send-email-madcatxster@devoid-pointer.net>
Port twl6040-vibra to ff-memless-next
Signed-off-by: Michal Malý <madcatxster@devoid-pointer.net>
---
drivers/input/misc/Kconfig | 2 +-
drivers/input/misc/twl6040-vibra.c | 27 ++++++++++++++++++++++-----
2 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 817156f..b9cbb91 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -417,7 +417,7 @@ config INPUT_TWL4030_VIBRA
config INPUT_TWL6040_VIBRA
tristate "Support for TWL6040 Vibrator"
depends on TWL6040_CORE
- select INPUT_FF_MEMLESS
+ select INPUT_FF_MEMLESS_NEXT
help
This option enables support for TWL6040 Vibrator Driver.
diff --git a/drivers/input/misc/twl6040-vibra.c b/drivers/input/misc/twl6040-vibra.c
index 77dc23b..7440a74 100644
--- a/drivers/input/misc/twl6040-vibra.c
+++ b/drivers/input/misc/twl6040-vibra.c
@@ -30,12 +30,14 @@
#include <linux/of.h>
#include <linux/workqueue.h>
#include <linux/input.h>
+#include <linux/input/ff-memless-next.h>
#include <linux/mfd/twl6040.h>
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/regulator/consumer.h>
#define EFFECT_DIR_180_DEG 0x8000
+#define FF_UPDATE_RATE 50
/* Recommended modulation index 85% */
#define TWL6040_VIBRA_MOD 85
@@ -197,9 +199,10 @@ static void vibra_play_work(struct work_struct *work)
}
static int vibra_play(struct input_dev *input, void *data,
- struct ff_effect *effect)
+ const struct mlnx_effect_command *command)
{
struct vibra_info *info = input_get_drvdata(input);
+ const struct mlnx_rumble_force *rumble_force = &command->u.rumble_force;
int ret;
/* Do not allow effect, while the routing is set to use audio */
@@ -209,9 +212,23 @@ static int vibra_play(struct input_dev *input, void *data,
return -EBUSY;
}
- info->weak_speed = effect->u.rumble.weak_magnitude;
- info->strong_speed = effect->u.rumble.strong_magnitude;
- info->direction = effect->direction < EFFECT_DIR_180_DEG ? 1 : -1;
+ switch (command->cmd) {
+ case MLNX_START_RUMBLE:
+ info->weak_speed = rumble_force->weak;
+ info->strong_speed = rumble_force->strong;
+ if (info->strong_speed >= info->weak_speed)
+ info->direction = rumble_force->strong_dir < EFFECT_DIR_180_DEG ? 1 : -1;
+ else
+ info->direction = rumble_force->weak_dir < EFFECT_DIR_180_DEG ? 1 : -1;
+ break;
+ case MLNX_STOP_RUMBLE:
+ info->weak_speed = 0;
+ info->strong_speed = 0;
+ info->direction = 1;
+ break;
+ default:
+ return -EINVAL;
+ }
ret = queue_work(info->workqueue, &info->play_work);
if (!ret) {
@@ -367,7 +384,7 @@ static int twl6040_vibra_probe(struct platform_device *pdev)
info->input_dev->close = twl6040_vibra_close;
__set_bit(FF_RUMBLE, info->input_dev->ffbit);
- ret = input_ff_create_memless(info->input_dev, NULL, vibra_play);
+ ret = input_ff_create_mlnx(info->input_dev, NULL, vibra_play, FF_UPDATE_RATE);
if (ret < 0) {
dev_err(info->dev, "couldn't register vibrator to FF\n");
goto err_ialloc;
--
1.9.2
next prev parent reply other threads:[~2014-04-26 11:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 11:57 [PATCH v3 00/24] input: Introduce ff-memless-next as an improved replacement for ff-memless Michal Malý
2014-04-26 11:57 ` Michal Malý
2014-04-26 11:57 ` [PATCH v3 01/24] input: Add ff-memless-next module Michal Malý
2014-04-26 11:57 ` Michal Malý
2014-04-26 13:07 ` Antonio Ospite
2014-04-26 13:07 ` Antonio Ospite
2014-04-26 15:04 ` Michal Malý
2014-04-26 11:57 ` [PATCH v3 02/24] input: Port arizona-haptics to ff-memless-next Michal Malý
2014-04-26 11:57 ` [PATCH v3 03/24] input: Port twl4030-vibra " Michal Malý
2014-04-26 11:57 ` Michal Malý [this message]
2014-04-26 11:57 ` [PATCH v3 05/24] input: Port max8997_haptic " Michal Malý
2014-04-26 11:57 ` [PATCH v3 06/24] input: Port pm8xxx-vibrator " Michal Malý
2014-04-26 11:57 ` [PATCH v3 07/24] hid: Port hid-axff " Michal Malý
2014-04-26 11:57 ` [PATCH v3 08/24] hid: Port hid-emsff " Michal Malý
2014-04-26 11:57 ` [PATCH v3 09/24] hid: Port hid-dr " Michal Malý
2014-04-26 11:57 ` [PATCH v3 10/24] hid: Port hid-gaff " Michal Malý
2014-04-26 11:57 ` Michal Malý
2014-04-26 11:57 ` [PATCH v3 11/24] hid: Port hid-holtekff " Michal Malý
2014-04-26 11:57 ` [PATCH v3 12/24] hid: Port hid-lgff " Michal Malý
2014-04-26 11:57 ` [PATCH v3 13/24] hid: Port hid-lg3ff " Michal Malý
2014-04-26 11:57 ` [PATCH v3 14/24] hid: Port hid-pl " Michal Malý
2014-04-26 11:57 ` [PATCH v3 15/24] hid: Port hid-sjoy " Michal Malý
2014-04-26 11:57 ` [PATCH v3 16/24] hid: Port hid-sony " Michal Malý
2014-04-26 13:09 ` Antonio Ospite
2014-04-26 13:09 ` Antonio Ospite
2014-04-26 15:05 ` Michal Malý
2014-04-26 11:57 ` [PATCH v3 17/24] hid: Port hid-tmff " Michal Malý
2014-04-26 11:57 ` [PATCH v3 18/24] hid: Port hid-wiimote-modules " Michal Malý
2014-04-26 11:57 ` [PATCH v3 19/24] hid: Port hid-zpff " Michal Malý
2014-04-26 11:57 ` [PATCH v3 20/24] input: Port gamecon " Michal Malý
2014-04-26 11:57 ` [PATCH v3 21/24] input: Port xpad " Michal Malý
2014-04-26 11:57 ` [PATCH v3 22/24] hid: Port hid-lg2ff " Michal Malý
2014-04-26 11:58 ` [PATCH v3 23/24] hid: Port hid-lg4ff " Michal Malý
2014-04-26 13:50 ` Elias Vanderstuyft
2014-04-26 13:50 ` Elias Vanderstuyft
2014-04-26 11:58 ` [PATCH v3 24/24] input: Replace ff-memless with ff-memless-next Michal Malý
-- strict thread matches above, loose matches on Subject: below --
2014-04-26 15:01 [PATCH v4 00/24] input: Introduce ff-memless-next as an improved replacement for ff-memless Michal Malý
2014-04-26 15:02 ` [PATCH v4 04/24] input: Port twl6040-vibra to ff-memless-next Michal Malý
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398513696-12626-5-git-send-email-madcatxster@devoid-pointer.net \
--to=madcatxster@devoid-pointer.net \
--cc=anssi.hannula@iki.fi \
--cc=dmitry.torokhov@gmail.com \
--cc=elias.vds@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.