All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yijing Wang <wangyijing@huawei.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	sparclinux@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org
Subject: Re: [PATCH 08/13] PCI, rpaphp: Use new pci_is_bridge() to simplify code
Date: Mon, 28 Apr 2014 00:43:21 +0000	[thread overview]
Message-ID: <1398645801.8437.84.camel@pasglop> (raw)
In-Reply-To: <1398417515-8740-9-git-send-email-wangyijing@huawei.com>

On Fri, 2014-04-25 at 17:18 +0800, Yijing Wang wrote:
> Now we can use new pci_is_bridge() helper function
> to simplify code.
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/pci/hotplug/rpadlpar_core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
> index 4fcdeed..7660232 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -157,8 +157,7 @@ static void dlpar_pci_add_bus(struct device_node *dn)
>  	}
>  
>  	/* Scan below the new bridge */
> -	if (dev->hdr_type = PCI_HEADER_TYPE_BRIDGE ||
> -	    dev->hdr_type = PCI_HEADER_TYPE_CARDBUS)
> +	if (pci_is_bridge(dev))
>  		of_scan_pci_bridge(dev);
>  
>  	/* Map IO space for child bus, which may or may not succeed */



WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yijing Wang <wangyijing@huawei.com>
Cc: Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 08/13] PCI, rpaphp: Use new pci_is_bridge() to simplify code
Date: Mon, 28 Apr 2014 10:43:21 +1000	[thread overview]
Message-ID: <1398645801.8437.84.camel@pasglop> (raw)
In-Reply-To: <1398417515-8740-9-git-send-email-wangyijing@huawei.com>

On Fri, 2014-04-25 at 17:18 +0800, Yijing Wang wrote:
> Now we can use new pci_is_bridge() helper function
> to simplify code.
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/pci/hotplug/rpadlpar_core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
> index 4fcdeed..7660232 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -157,8 +157,7 @@ static void dlpar_pci_add_bus(struct device_node *dn)
>  	}
>  
>  	/* Scan below the new bridge */
> -	if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
> -	    dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)
> +	if (pci_is_bridge(dev))
>  		of_scan_pci_bridge(dev);
>  
>  	/* Map IO space for child bus, which may or may not succeed */

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yijing Wang <wangyijing@huawei.com>
Cc: Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 08/13] PCI, rpaphp: Use new pci_is_bridge() to simplify code
Date: Mon, 28 Apr 2014 00:43:21 +0000	[thread overview]
Message-ID: <1398645801.8437.84.camel@pasglop> (raw)
In-Reply-To: <1398417515-8740-9-git-send-email-wangyijing@huawei.com>

On Fri, 2014-04-25 at 17:18 +0800, Yijing Wang wrote:
> Now we can use new pci_is_bridge() helper function
> to simplify code.
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/pci/hotplug/rpadlpar_core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
> index 4fcdeed..7660232 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -157,8 +157,7 @@ static void dlpar_pci_add_bus(struct device_node *dn)
>  	}
>  
>  	/* Scan below the new bridge */
> -	if (dev->hdr_type = PCI_HEADER_TYPE_BRIDGE ||
> -	    dev->hdr_type = PCI_HEADER_TYPE_CARDBUS)
> +	if (pci_is_bridge(dev))
>  		of_scan_pci_bridge(dev);
>  
>  	/* Map IO space for child bus, which may or may not succeed */



WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yijing Wang <wangyijing@huawei.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	sparclinux@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org
Subject: Re: [PATCH 08/13] PCI, rpaphp: Use new pci_is_bridge() to simplify code
Date: Mon, 28 Apr 2014 10:43:21 +1000	[thread overview]
Message-ID: <1398645801.8437.84.camel@pasglop> (raw)
In-Reply-To: <1398417515-8740-9-git-send-email-wangyijing@huawei.com>

On Fri, 2014-04-25 at 17:18 +0800, Yijing Wang wrote:
> Now we can use new pci_is_bridge() helper function
> to simplify code.
> 
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> ---
>  drivers/pci/hotplug/rpadlpar_core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
> index 4fcdeed..7660232 100644
> --- a/drivers/pci/hotplug/rpadlpar_core.c
> +++ b/drivers/pci/hotplug/rpadlpar_core.c
> @@ -157,8 +157,7 @@ static void dlpar_pci_add_bus(struct device_node *dn)
>  	}
>  
>  	/* Scan below the new bridge */
> -	if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE ||
> -	    dev->hdr_type == PCI_HEADER_TYPE_CARDBUS)
> +	if (pci_is_bridge(dev))
>  		of_scan_pci_bridge(dev);
>  
>  	/* Map IO space for child bus, which may or may not succeed */



  reply	other threads:[~2014-04-28  0:43 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  9:18 [PATCH 00/13] Refactor pci_is_brdige() to simplify code Yijing Wang
2014-04-25  9:18 ` Yijing Wang
2014-04-25  9:18 ` Yijing Wang
2014-04-25  9:18 ` Yijing Wang
2014-04-25  9:18 ` [PATCH 01/13] PCI: rename pci_is_bridge() to pci_has_subordinate() Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 02/13] PCI: Introduce new pci_is_bridge() helper function Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 03/13] PCI: Use new pci_is_bridge() to simplify code Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 04/13] x86/PCI: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 05/13] IA64/PCI: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 06/13] powerpc/PCI: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 07/13] sparc/PCI: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25 16:49   ` David Miller
2014-04-25 16:49     ` David Miller
2014-04-25 16:49     ` David Miller
2014-04-25 16:49     ` David Miller
2014-04-25  9:18 ` [PATCH 08/13] PCI, rpaphp: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-28  0:43   ` Benjamin Herrenschmidt [this message]
2014-04-28  0:43     ` Benjamin Herrenschmidt
2014-04-28  0:43     ` Benjamin Herrenschmidt
2014-04-28  0:43     ` Benjamin Herrenschmidt
2014-04-25  9:18 ` [PATCH 09/13] PCI, shpchp: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 10/13] PCI, cpcihp: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 11/13] PCI, acpiphp: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 12/13] PCI, pcmcia: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18 ` [PATCH 13/13] PCI, pciehp: " Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:18   ` Yijing Wang
2014-04-25  9:42 ` [PATCH 00/13] Refactor pci_is_brdige() " David Laight
2014-04-25  9:42   ` David Laight
2014-04-25  9:42   ` David Laight
2014-04-26  2:49   ` Yijing Wang
2014-04-26  2:49     ` Yijing Wang
2014-04-30 16:29 ` Bjorn Helgaas
2014-04-30 16:29   ` Bjorn Helgaas
2014-04-30 16:29   ` Bjorn Helgaas
2014-04-30 16:29   ` Bjorn Helgaas
2014-05-04  4:16   ` Yijing Wang
2014-05-04  4:16     ` Yijing Wang
2014-05-04  4:16     ` Yijing Wang
2014-05-04  4:16     ` Yijing Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398645801.8437.84.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=wangyijing@huawei.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.