* [PATCH] spi: qup: Fix return value checking for pm_runtime_get_sync()
@ 2014-05-03 2:57 Axel Lin
2014-05-03 16:53 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2014-05-03 2:57 UTC (permalink / raw)
To: Mark Brown; +Cc: Ivan T. Ivanov, linux-spi-u79uwXL29TY76Z2rM5mHXA
pm_runtime_get_sync() returns 1 if !CONFIG_PM_RUNTIME.
Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
drivers/spi/spi-qup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index b032e88..78c66e3 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -734,7 +734,7 @@ static int spi_qup_remove(struct platform_device *pdev)
int ret;
ret = pm_runtime_get_sync(&pdev->dev);
- if (ret)
+ if (ret < 0)
return ret;
ret = spi_qup_set_state(controller, QUP_STATE_RESET);
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] spi: qup: Fix return value checking for pm_runtime_get_sync()
2014-05-03 2:57 [PATCH] spi: qup: Fix return value checking for pm_runtime_get_sync() Axel Lin
@ 2014-05-03 16:53 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-05-03 16:53 UTC (permalink / raw)
To: Axel Lin; +Cc: Ivan T. Ivanov, linux-spi-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 133 bytes --]
On Sat, May 03, 2014 at 10:57:57AM +0800, Axel Lin wrote:
> pm_runtime_get_sync() returns 1 if !CONFIG_PM_RUNTIME.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-03 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-03 2:57 [PATCH] spi: qup: Fix return value checking for pm_runtime_get_sync() Axel Lin
2014-05-03 16:53 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.