From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Alexander Graf <agraf@suse.de>,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr
Date: Tue, 06 May 2014 00:04:16 +0000 [thread overview]
Message-ID: <1399334656.20388.69.camel@pasglop> (raw)
In-Reply-To: <87tx949u9d.fsf@linux.vnet.ibm.com>
On Mon, 2014-05-05 at 19:56 +0530, Aneesh Kumar K.V wrote:
>
> Paul mentioned that BOOK3S always had DAR value set on alignment
> interrupt. And the patch is to enable/collect correct DAR value when
> running with Little Endian PR guest. Now to limit the impact and to
> enable Little Endian PR guest, I ended up doing the conditional code
> only for book3s 64 for which we know for sure that we set DAR value.
Only BookS ? Afaik, the kernel align.c unconditionally uses DAR on
every processor type. It's DSISR that may or may not be populated
but afaik DAR always is.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, paulus@samba.org,
Alexander Graf <agraf@suse.de>,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr
Date: Tue, 06 May 2014 10:04:16 +1000 [thread overview]
Message-ID: <1399334656.20388.69.camel@pasglop> (raw)
In-Reply-To: <87tx949u9d.fsf@linux.vnet.ibm.com>
On Mon, 2014-05-05 at 19:56 +0530, Aneesh Kumar K.V wrote:
>
> Paul mentioned that BOOK3S always had DAR value set on alignment
> interrupt. And the patch is to enable/collect correct DAR value when
> running with Little Endian PR guest. Now to limit the impact and to
> enable Little Endian PR guest, I ended up doing the conditional code
> only for book3s 64 for which we know for sure that we set DAR value.
Only BookS ? Afaik, the kernel align.c unconditionally uses DAR on
every processor type. It's DSISR that may or may not be populated
but afaik DAR always is.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Alexander Graf <agraf@suse.de>,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr
Date: Tue, 06 May 2014 10:04:16 +1000 [thread overview]
Message-ID: <1399334656.20388.69.camel@pasglop> (raw)
In-Reply-To: <87tx949u9d.fsf@linux.vnet.ibm.com>
On Mon, 2014-05-05 at 19:56 +0530, Aneesh Kumar K.V wrote:
>
> Paul mentioned that BOOK3S always had DAR value set on alignment
> interrupt. And the patch is to enable/collect correct DAR value when
> running with Little Endian PR guest. Now to limit the impact and to
> enable Little Endian PR guest, I ended up doing the conditional code
> only for book3s 64 for which we know for sure that we set DAR value.
Only BookS ? Afaik, the kernel align.c unconditionally uses DAR on
every processor type. It's DSISR that may or may not be populated
but afaik DAR always is.
Cheers,
Ben.
next prev parent reply other threads:[~2014-05-06 0:04 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-04 17:21 [PATCH V4] POWERPC: BOOK3S: KVM: Use the saved dar value and generic make_dsisr Aneesh Kumar K.V
2014-05-04 17:33 ` Aneesh Kumar K.V
2014-05-04 17:21 ` Aneesh Kumar K.V
2014-05-05 11:19 ` Alexander Graf
2014-05-05 11:19 ` Alexander Graf
2014-05-05 11:19 ` Alexander Graf
2014-05-05 14:26 ` Aneesh Kumar K.V
2014-05-05 14:38 ` Aneesh Kumar K.V
2014-05-05 14:26 ` Aneesh Kumar K.V
2014-05-05 14:43 ` Alexander Graf
2014-05-05 14:43 ` Alexander Graf
2014-05-05 14:43 ` Alexander Graf
2014-05-05 14:50 ` Aneesh Kumar K.V
2014-05-05 14:51 ` Aneesh Kumar K.V
2014-05-05 14:50 ` Aneesh Kumar K.V
2014-05-05 15:10 ` Alexander Graf
2014-05-05 15:10 ` Alexander Graf
2014-05-05 15:10 ` Alexander Graf
2014-05-05 14:54 ` Olof Johansson
2014-05-05 14:54 ` Olof Johansson
2014-05-05 15:03 ` Aneesh Kumar K.V
2014-05-05 15:15 ` Aneesh Kumar K.V
2014-05-05 15:03 ` Aneesh Kumar K.V
2014-05-05 15:06 ` Olof Johansson
2014-05-05 15:06 ` Olof Johansson
2014-05-05 15:06 ` Olof Johansson
2014-05-05 14:57 ` Olof Johansson
2014-05-05 14:57 ` Olof Johansson
2014-05-05 14:57 ` Olof Johansson
2014-05-05 15:09 ` Alexander Graf
2014-05-05 15:09 ` Alexander Graf
2014-05-05 15:09 ` Alexander Graf
2014-05-05 21:23 ` Christian Zigotzky
2014-05-05 21:23 ` Christian Zigotzky
2014-05-05 21:23 ` Christian Zigotzky
2014-05-06 0:07 ` Benjamin Herrenschmidt
2014-05-06 0:07 ` Benjamin Herrenschmidt
2014-05-06 0:07 ` Benjamin Herrenschmidt
2014-05-06 0:04 ` Benjamin Herrenschmidt [this message]
2014-05-06 0:04 ` Benjamin Herrenschmidt
2014-05-06 0:04 ` Benjamin Herrenschmidt
2014-05-06 0:41 ` Paul Mackerras
2014-05-06 0:41 ` Paul Mackerras
2014-05-06 0:41 ` Paul Mackerras
2014-05-06 6:57 ` Alexander Graf
2014-05-06 6:57 ` Alexander Graf
2014-05-06 6:57 ` Alexander Graf
2014-05-06 14:06 ` Aneesh Kumar K.V
2014-05-06 14:18 ` Aneesh Kumar K.V
2014-05-06 14:06 ` Aneesh Kumar K.V
2014-05-06 14:12 ` Aneesh Kumar K.V
2014-05-06 14:24 ` Aneesh Kumar K.V
2014-05-06 14:12 ` Aneesh Kumar K.V
2014-05-06 14:21 ` Alexander Graf
2014-05-06 14:21 ` Alexander Graf
2014-05-06 14:21 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399334656.20388.69.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.