All of lore.kernel.org
 help / color / mirror / Atom feed
From: iivanov@mm-sol.com (Ivan T. Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] usb: phy: msm: reset controller is mandatory now
Date: Thu, 08 May 2014 17:21:49 +0300	[thread overview]
Message-ID: <1399558909.8165.8.camel@iivanov-dev> (raw)
In-Reply-To: <1399557141-1346645-6-git-send-email-arnd@arndb.de>


Hi Arnd, 

On Thu, 2014-05-08 at 15:52 +0200, Arnd Bergmann wrote:
> Commit a27345434134 "usb: phy: msm: Use reset framework for LINK
> and PHY resets" introduced a mandatory call to reset_control_get
> into the msm usb phy driver, which means we have to add a Kconfig
> dependency on the API to avoid this build error:
> 
> phy/phy-msm-usb.c: In function 'msm_otg_read_dt':
> phy/phy-msm-usb.c:1461:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
>   motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
>   ^
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> ---
>  drivers/usb/host/Kconfig | 2 +-
>  drivers/usb/phy/Kconfig  | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 3d9e540..890fc8c 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -168,7 +168,7 @@ config USB_EHCI_HCD_AT91
>  
>  config USB_EHCI_MSM
>  	tristate "Support for Qualcomm QSD/MSM on-chip EHCI USB controller"
> -	depends on ARCH_MSM
> +	depends on ARCH_MSM && RESET_CONTROLLER

This driver did not use reset controller API.

>  	select USB_EHCI_ROOT_HUB_TT
>  	select USB_MSM_OTG
>  	---help---
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index 359a6c1..65bec8f 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -165,6 +165,7 @@ config USB_ISP1301
>  config USB_MSM_OTG
>  	tristate "Qualcomm on-chip USB OTG controller support"
>  	depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM)
> +	depends on RESET_CONTROLLER

This is fine. 

Thank you.
Ivan

WARNING: multiple messages have this Message-ID (diff)
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@ti.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/8] usb: phy: msm: reset controller is mandatory now
Date: Thu, 08 May 2014 17:21:49 +0300	[thread overview]
Message-ID: <1399558909.8165.8.camel@iivanov-dev> (raw)
In-Reply-To: <1399557141-1346645-6-git-send-email-arnd@arndb.de>


Hi Arnd, 

On Thu, 2014-05-08 at 15:52 +0200, Arnd Bergmann wrote:
> Commit a27345434134 "usb: phy: msm: Use reset framework for LINK
> and PHY resets" introduced a mandatory call to reset_control_get
> into the msm usb phy driver, which means we have to add a Kconfig
> dependency on the API to avoid this build error:
> 
> phy/phy-msm-usb.c: In function 'msm_otg_read_dt':
> phy/phy-msm-usb.c:1461:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
>   motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
>   ^
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> ---
>  drivers/usb/host/Kconfig | 2 +-
>  drivers/usb/phy/Kconfig  | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 3d9e540..890fc8c 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -168,7 +168,7 @@ config USB_EHCI_HCD_AT91
>  
>  config USB_EHCI_MSM
>  	tristate "Support for Qualcomm QSD/MSM on-chip EHCI USB controller"
> -	depends on ARCH_MSM
> +	depends on ARCH_MSM && RESET_CONTROLLER

This driver did not use reset controller API.

>  	select USB_EHCI_ROOT_HUB_TT
>  	select USB_MSM_OTG
>  	---help---
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index 359a6c1..65bec8f 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -165,6 +165,7 @@ config USB_ISP1301
>  config USB_MSM_OTG
>  	tristate "Qualcomm on-chip USB OTG controller support"
>  	depends on (USB || USB_GADGET) && (ARCH_MSM || ARCH_QCOM)
> +	depends on RESET_CONTROLLER

This is fine. 

Thank you.
Ivan


  reply	other threads:[~2014-05-08 14:21 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08 13:52 [PATCH 0/8] usb: various fixes for ARM randconfig failures Arnd Bergmann
2014-05-08 13:52 ` Arnd Bergmann
2014-05-08 13:52 ` [PATCH 1/8] usb/gadget: s3c2410_udc: don't use pr_debug return value Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 13:52 ` [PATCH 2/8] usb: musb: tusb-dma can't be built-in if tusb is not Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 13:52 ` [PATCH 3/8] usb: musb: omap2plus bus glue needs USB host support Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 13:52 ` [PATCH 4/8] usb: phy: fix isp1301-omap dependency on tps65010 Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
     [not found]   ` <1399557141-1346645-5-git-send-email-arnd-r2nGTMty4D4@public.gmane.org>
2014-05-13 15:26     ` Felipe Balbi
2014-05-13 15:26       ` Felipe Balbi
2014-05-13 15:26       ` Felipe Balbi
2014-05-13 19:48       ` Arnd Bergmann
2014-05-13 19:48         ` Arnd Bergmann
2014-05-13 19:52         ` Felipe Balbi
2014-05-13 19:52           ` Felipe Balbi
2014-05-13 19:52           ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 5/8] usb: phy: msm: reset controller is mandatory now Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 14:21   ` Ivan T. Ivanov [this message]
2014-05-08 14:21     ` Ivan T. Ivanov
2014-05-08 14:27     ` Arnd Bergmann
2014-05-08 14:27       ` Arnd Bergmann
2014-05-08 14:58       ` Ivan T. Ivanov
2014-05-08 14:58         ` Ivan T. Ivanov
2014-05-13 15:27   ` Felipe Balbi
2014-05-13 15:27     ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 6/8] usb: xhci: avoid warning for !PM_SLEEP Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-13 15:28   ` Felipe Balbi
2014-05-13 15:28     ` Felipe Balbi
2014-05-13 19:39     ` Arnd Bergmann
2014-05-13 19:39       ` Arnd Bergmann
2014-05-13 19:52       ` Felipe Balbi
2014-05-13 19:52         ` Felipe Balbi
2014-05-08 13:52 ` [PATCH 7/8] usb: ohci: sort out dependencies for lpc32xx and omap Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 15:51   ` Alan Stern
2014-05-08 15:51     ` Alan Stern
2014-05-08 15:51     ` Alan Stern
2014-05-08 13:52 ` [PATCH 8/8] usb: ohci-da8xx can only be built-in Arnd Bergmann
2014-05-08 13:52   ` Arnd Bergmann
2014-05-08 15:47   ` Alan Stern
2014-05-08 15:47     ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399558909.8165.8.camel@iivanov-dev \
    --to=iivanov@mm-sol.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.