All of lore.kernel.org
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] ARM: imx: fix function type for CLK_OF_DECLARE
Date: Mon, 12 May 2014 19:29:47 -0500	[thread overview]
Message-ID: <1399940993-1773-2-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1399940993-1773-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <robh@kernel.org>

Adding function type checking to CLK_OF_DECLARE found a type mismatch with
mx35_clocks_init_dt. The function should return void.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Shawn Guo <shawn.guo@freescale.com>
Cc: Sascha Hauer <kernel@pengutronix.de>
---
 arch/arm/mach-imx/clk-imx35.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-imx/clk-imx35.c b/arch/arm/mach-imx/clk-imx35.c
index a4d5e42..71c86a2 100644
--- a/arch/arm/mach-imx/clk-imx35.c
+++ b/arch/arm/mach-imx/clk-imx35.c
@@ -289,14 +289,12 @@ int __init mx35_clocks_init(void)
 	return 0;
 }
 
-static int __init mx35_clocks_init_dt(struct device_node *ccm_node)
+static void __init mx35_clocks_init_dt(struct device_node *ccm_node)
 {
 	clk_data.clks = clk;
 	clk_data.clk_num = ARRAY_SIZE(clk);
 	of_clk_add_provider(ccm_node, of_clk_src_onecell_get, &clk_data);
 
 	mx35_clocks_init();
-
-	return 0;
 }
 CLK_OF_DECLARE(imx35, "fsl,imx35-ccm", mx35_clocks_init_dt);
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2@gmail.com>
To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Rob Herring <robh@kernel.org>,
	Shawn Guo <shawn.guo@freescale.com>,
	Sascha Hauer <kernel@pengutronix.de>
Subject: [PATCH 1/7] ARM: imx: fix function type for CLK_OF_DECLARE
Date: Mon, 12 May 2014 19:29:47 -0500	[thread overview]
Message-ID: <1399940993-1773-2-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1399940993-1773-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <robh@kernel.org>

Adding function type checking to CLK_OF_DECLARE found a type mismatch with
mx35_clocks_init_dt. The function should return void.

Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Shawn Guo <shawn.guo@freescale.com>
Cc: Sascha Hauer <kernel@pengutronix.de>
---
 arch/arm/mach-imx/clk-imx35.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-imx/clk-imx35.c b/arch/arm/mach-imx/clk-imx35.c
index a4d5e42..71c86a2 100644
--- a/arch/arm/mach-imx/clk-imx35.c
+++ b/arch/arm/mach-imx/clk-imx35.c
@@ -289,14 +289,12 @@ int __init mx35_clocks_init(void)
 	return 0;
 }
 
-static int __init mx35_clocks_init_dt(struct device_node *ccm_node)
+static void __init mx35_clocks_init_dt(struct device_node *ccm_node)
 {
 	clk_data.clks = clk;
 	clk_data.clk_num = ARRAY_SIZE(clk);
 	of_clk_add_provider(ccm_node, of_clk_src_onecell_get, &clk_data);
 
 	mx35_clocks_init();
-
-	return 0;
 }
 CLK_OF_DECLARE(imx35, "fsl,imx35-ccm", mx35_clocks_init_dt);
-- 
1.9.1


  reply	other threads:[~2014-05-13  0:29 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13  0:29 [PATCH 0/7] OF init section function prototype fixes Rob Herring
2014-05-13  0:29 ` Rob Herring
2014-05-13  0:29 ` Rob Herring [this message]
2014-05-13  0:29   ` [PATCH 1/7] ARM: imx: fix function type for CLK_OF_DECLARE Rob Herring
2014-05-13  2:10   ` Shawn Guo
2014-05-13  2:10     ` Shawn Guo
2014-05-13  0:29 ` [PATCH 2/7] clk: rockchip: " Rob Herring
2014-05-13  0:29   ` Rob Herring
2014-05-13  0:29 ` [PATCH 3/7] clk: sunxi: avoid double DT matching Rob Herring
2014-05-13  0:29   ` Rob Herring
2014-05-13 15:12   ` Rob Herring
2014-05-13 15:12     ` Rob Herring
2014-05-13 16:57     ` Emilio López
2014-05-13 16:57       ` Emilio López
2014-05-13  0:29 ` [PATCH 4/7] clk: sunxi: fix function type for CLK_OF_DECLARE Rob Herring
2014-05-13  0:29   ` Rob Herring
2014-05-13  0:29 ` [PATCH 5/7] irqchip: s3c24xx: fix function type for IRQCHIP_OF_DECLARE Rob Herring
2014-05-13  0:29   ` Rob Herring
2014-05-13 15:22   ` Jason Cooper
2014-05-13 15:22     ` Jason Cooper
2014-05-13 17:02     ` Rob Herring
2014-05-13 17:02       ` Rob Herring
2014-05-13 19:19       ` Jason Cooper
2014-05-13 19:19         ` Jason Cooper
2014-05-13  0:29 ` [PATCH 6/7] irqchip: mxs: " Rob Herring
2014-05-13  0:29   ` Rob Herring
2014-05-13  0:29 ` [PATCH 7/7] clk: ti: add missing semi-colon on CLK_OF_DECLARE Rob Herring
2014-05-13  0:29   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399940993-1773-2-git-send-email-robherring2@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.