Re: [PATCH 2/2] platform/x86: huawei-wmi: add modern Honor MagicBook hotkeys

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Fri, 14 Aug 2026, Ruzal Daminov wrote:

> Honor MagicBook laptops (e.g. FMI-76 / X14 / X16 Plus series) use the
> ACPI WMI interface (GUID 0xA0) with modern function key scancodes.
> 
> Add the missing keycodes to huawei_wmi_keymap[]:
>  - 0x0287: Mic mute key (Fn+F7) -> KEY_MICMUTE
>  - 0x0288: Camera toggle (Fn+F8) -> KEY_CAMERA
>  - 0x028a: Honor Connect / Share (Fn+F10) -> KEY_CONFIG
>  - 0x028b: YOYO AI Assistant (Fn+F11) -> KEY_VOICECOMMAND
>  - 0x028e: Screenshot key (Fn+F12) -> KEY_PRINT
> 
> Tested on Honor MagicBook X14 Plus (FMI-76, AMD Ryzen 8845HS).
> 
> Signed-off-by: Ruzal Daminov <daminovruzal7@gmail.com>
> ---
>  drivers/platform/x86/huawei-wmi.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
> index 93cca17fd..d5f77fb68 100644
> --- a/drivers/platform/x86/huawei-wmi.c
> +++ b/drivers/platform/x86/huawei-wmi.c
> @@ -72,6 +72,12 @@ struct huawei_wmi {
>  static struct huawei_wmi *huawei_wmi;
>  
>  static const struct key_entry huawei_wmi_keymap[] = {
> +	{ KE_KEY, 0x0287, { KEY_MICMUTE } },
> +	{ KE_KEY, 0x0288, { KEY_CAMERA } },              /* Fn+F8: Camera */
> +	{ KE_KEY, 0x028a, { KEY_CONFIG } },              /* Fn+F10: Honor Connect */
> +	{ KE_KEY, 0x028b, { KEY_VOICECOMMAND } },        /* Fn+F11: YOYO AI */
> +	{ KE_KEY, 0x028e, { KEY_PRINT } },               /* Fn+F12: Screenshot */
> +
>  	{ KE_KEY,    0x281, { KEY_BRIGHTNESSDOWN } },
>  	{ KE_KEY,    0x282, { KEY_BRIGHTNESSUP } },
>  	{ KE_KEY,    0x284, { KEY_MUTE } },

??? Multiple of those keys are already in the array ???

I suppose you'd have noticed it if you'd have not added the leading zeros 
and would have put those correctly in their place in the numerical order.

Please also keep the existing formatting.

-- 
 i.