All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] platform/x86: huawei-wmi: add modern Honor MagicBook hotkeys
@ 2026-08-14 17:13 Ruzal Daminov
  2026-08-18 10:26 ` Ilpo Järvinen
  2026-08-19  8:38 ` [PATCH v2] platform/x86: huawei-wmi: add camera toggle keycode Ruzal Daminov
  0 siblings, 2 replies; 3+ messages in thread
From: Ruzal Daminov @ 2026-08-14 17:13 UTC (permalink / raw)
  To: hansg, ilpo.jarvinen; +Cc: platform-driver-x86, linux-kernel, Ruzal Daminov

Honor MagicBook laptops (e.g. FMI-76 / X14 / X16 Plus series) use the
ACPI WMI interface (GUID 0xA0) with modern function key scancodes.

Add the missing keycodes to huawei_wmi_keymap[]:
 - 0x0287: Mic mute key (Fn+F7) -> KEY_MICMUTE
 - 0x0288: Camera toggle (Fn+F8) -> KEY_CAMERA
 - 0x028a: Honor Connect / Share (Fn+F10) -> KEY_CONFIG
 - 0x028b: YOYO AI Assistant (Fn+F11) -> KEY_VOICECOMMAND
 - 0x028e: Screenshot key (Fn+F12) -> KEY_PRINT

Tested on Honor MagicBook X14 Plus (FMI-76, AMD Ryzen 8845HS).

Signed-off-by: Ruzal Daminov <daminovruzal7@gmail.com>
---
 drivers/platform/x86/huawei-wmi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index 93cca17fd..d5f77fb68 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -72,6 +72,12 @@ struct huawei_wmi {
 static struct huawei_wmi *huawei_wmi;
 
 static const struct key_entry huawei_wmi_keymap[] = {
+	{ KE_KEY, 0x0287, { KEY_MICMUTE } },
+	{ KE_KEY, 0x0288, { KEY_CAMERA } },              /* Fn+F8: Camera */
+	{ KE_KEY, 0x028a, { KEY_CONFIG } },              /* Fn+F10: Honor Connect */
+	{ KE_KEY, 0x028b, { KEY_VOICECOMMAND } },        /* Fn+F11: YOYO AI */
+	{ KE_KEY, 0x028e, { KEY_PRINT } },               /* Fn+F12: Screenshot */
+
 	{ KE_KEY,    0x281, { KEY_BRIGHTNESSDOWN } },
 	{ KE_KEY,    0x282, { KEY_BRIGHTNESSUP } },
 	{ KE_KEY,    0x284, { KEY_MUTE } },
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] platform/x86: huawei-wmi: add modern Honor MagicBook hotkeys
  2026-08-14 17:13 [PATCH 2/2] platform/x86: huawei-wmi: add modern Honor MagicBook hotkeys Ruzal Daminov
@ 2026-08-18 10:26 ` Ilpo Järvinen
  2026-08-19  8:38 ` [PATCH v2] platform/x86: huawei-wmi: add camera toggle keycode Ruzal Daminov
  1 sibling, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2026-08-18 10:26 UTC (permalink / raw)
  To: Ruzal Daminov; +Cc: Hans de Goede, platform-driver-x86, LKML

On Fri, 14 Aug 2026, Ruzal Daminov wrote:

> Honor MagicBook laptops (e.g. FMI-76 / X14 / X16 Plus series) use the
> ACPI WMI interface (GUID 0xA0) with modern function key scancodes.
> 
> Add the missing keycodes to huawei_wmi_keymap[]:
>  - 0x0287: Mic mute key (Fn+F7) -> KEY_MICMUTE
>  - 0x0288: Camera toggle (Fn+F8) -> KEY_CAMERA
>  - 0x028a: Honor Connect / Share (Fn+F10) -> KEY_CONFIG
>  - 0x028b: YOYO AI Assistant (Fn+F11) -> KEY_VOICECOMMAND
>  - 0x028e: Screenshot key (Fn+F12) -> KEY_PRINT
> 
> Tested on Honor MagicBook X14 Plus (FMI-76, AMD Ryzen 8845HS).
> 
> Signed-off-by: Ruzal Daminov <daminovruzal7@gmail.com>
> ---
>  drivers/platform/x86/huawei-wmi.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
> index 93cca17fd..d5f77fb68 100644
> --- a/drivers/platform/x86/huawei-wmi.c
> +++ b/drivers/platform/x86/huawei-wmi.c
> @@ -72,6 +72,12 @@ struct huawei_wmi {
>  static struct huawei_wmi *huawei_wmi;
>  
>  static const struct key_entry huawei_wmi_keymap[] = {
> +	{ KE_KEY, 0x0287, { KEY_MICMUTE } },
> +	{ KE_KEY, 0x0288, { KEY_CAMERA } },              /* Fn+F8: Camera */
> +	{ KE_KEY, 0x028a, { KEY_CONFIG } },              /* Fn+F10: Honor Connect */
> +	{ KE_KEY, 0x028b, { KEY_VOICECOMMAND } },        /* Fn+F11: YOYO AI */
> +	{ KE_KEY, 0x028e, { KEY_PRINT } },               /* Fn+F12: Screenshot */
> +
>  	{ KE_KEY,    0x281, { KEY_BRIGHTNESSDOWN } },
>  	{ KE_KEY,    0x282, { KEY_BRIGHTNESSUP } },
>  	{ KE_KEY,    0x284, { KEY_MUTE } },

??? Multiple of those keys are already in the array ???

I suppose you'd have noticed it if you'd have not added the leading zeros 
and would have put those correctly in their place in the numerical order.

Please also keep the existing formatting.

-- 
 i.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2] platform/x86: huawei-wmi: add camera toggle keycode
  2026-08-14 17:13 [PATCH 2/2] platform/x86: huawei-wmi: add modern Honor MagicBook hotkeys Ruzal Daminov
  2026-08-18 10:26 ` Ilpo Järvinen
@ 2026-08-19  8:38 ` Ruzal Daminov
  1 sibling, 0 replies; 3+ messages in thread
From: Ruzal Daminov @ 2026-08-19  8:38 UTC (permalink / raw)
  To: ilpo.jarvinen, hansg; +Cc: platform-driver-x86, linux-kernel, Ruzal Daminov

Honor MagicBook laptops emit WMI event code 0x288 when pressing the
camera e-shutter / privacy toggle key (Fn+F8 on Honor).

Add the missing 0x288 keycode to huawei_wmi_keymap[] in correct numerical
order and map it to KEY_CAMERA_ACCESS_TOGGLE.

Tested on Honor MagicBook X14 Plus (FMI-76, AMD Ryzen 8845HS).

Signed-off-by: Ruzal Daminov <daminovruzal7@gmail.com>
---
v2:
 - Drop duplicate keys already present in the table.
 - Remove leading zeros to match existing table style.
 - Place 0x288 in correct numerical order.
 - Map 0x288 to KEY_CAMERA_ACCESS_TOGGLE.

 drivers/platform/x86/huawei-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index 93cca17fdf5868..b5463edc4053d4 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -78,6 +78,7 @@ static const struct key_entry huawei_wmi_keymap[] = {
 	{ KE_KEY,    0x285, { KEY_VOLUMEDOWN } },
 	{ KE_KEY,    0x286, { KEY_VOLUMEUP } },
 	{ KE_KEY,    0x287, { KEY_MICMUTE } },
+	{ KE_KEY,    0x288, { KEY_CAMERA_ACCESS_TOGGLE } },
 	{ KE_KEY,    0x289, { KEY_WLAN } },
 	// Huawei |M| key
 	{ KE_KEY,    0x28a, { KEY_CONFIG } },
-- 
2.45.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-19  8:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-14 17:13 [PATCH 2/2] platform/x86: huawei-wmi: add modern Honor MagicBook hotkeys Ruzal Daminov
2026-08-18 10:26 ` Ilpo Järvinen
2026-08-19  8:38 ` [PATCH v2] platform/x86: huawei-wmi: add camera toggle keycode Ruzal Daminov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.