From: iivanov@mm-sol.com (Ivan T. Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] usb: phy: msm: reset controller is mandatory now
Date: Wed, 14 May 2014 10:23:44 +0300 [thread overview]
Message-ID: <1400052224.8431.11.camel@iivanov-dev> (raw)
In-Reply-To: <4319810.IibMxJ0Qvk@wuerfel>
On Tue, 2014-05-13 at 21:46 +0200, Arnd Bergmann wrote:
> Commit a27345434134 "usb: phy: msm: Use reset framework for LINK
> and PHY resets" introduced a mandatory call to reset_control_get
> into the msm usb phy driver, which means we have to add a Kconfig
> dependency on the API to avoid this build error:
>
> phy/phy-msm-usb.c: In function 'msm_otg_read_dt':
> phy/phy-msm-usb.c:1461:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
> motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
> ^
>
> Since the usb-ehci-msm driver currently selects the OTG driver,
> we could still get a broken dependency here. To solve that,
> this patch also removes the 'select', which turns out to be
> unnecessary.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Thank you.
Reviewed-by: Ivan T. Ivanov <iivanov@mm-sol.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] usb: phy: msm: reset controller is mandatory now
Date: Wed, 14 May 2014 10:23:44 +0300 [thread overview]
Message-ID: <1400052224.8431.11.camel@iivanov-dev> (raw)
In-Reply-To: <4319810.IibMxJ0Qvk@wuerfel>
On Tue, 2014-05-13 at 21:46 +0200, Arnd Bergmann wrote:
> Commit a27345434134 "usb: phy: msm: Use reset framework for LINK
> and PHY resets" introduced a mandatory call to reset_control_get
> into the msm usb phy driver, which means we have to add a Kconfig
> dependency on the API to avoid this build error:
>
> phy/phy-msm-usb.c: In function 'msm_otg_read_dt':
> phy/phy-msm-usb.c:1461:2: error: implicit declaration of function 'devm_reset_control_get' [-Werror=implicit-function-declaration]
> motg->link_rst = devm_reset_control_get(&pdev->dev, "link");
> ^
>
> Since the usb-ehci-msm driver currently selects the OTG driver,
> we could still get a broken dependency here. To solve that,
> this patch also removes the 'select', which turns out to be
> unnecessary.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Thank you.
Reviewed-by: Ivan T. Ivanov <iivanov@mm-sol.com>
next prev parent reply other threads:[~2014-05-14 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 19:46 [PATCH v2] usb: phy: msm: reset controller is mandatory now Arnd Bergmann
2014-05-13 19:46 ` Arnd Bergmann
2014-05-14 7:23 ` Ivan T. Ivanov [this message]
2014-05-14 7:23 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400052224.8431.11.camel@iivanov-dev \
--to=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.