* git.py support for submodules @ 2014-05-17 17:13 Chris Morgan 2014-05-17 19:58 ` Christopher Larson 0 siblings, 1 reply; 6+ messages in thread From: Chris Morgan @ 2014-05-17 17:13 UTC (permalink / raw) To: yocto [-- Attachment #1: Type: text/plain, Size: 312 bytes --] Hello. I noticed that git.py doesn't seem to have support for submodules. I worked around this in my recipe by adding a pre configure step but I was wondering if a patch to add another option to git.py to fetch submodules would make sense and be welcomed (pending it's implementation of course). Chris [-- Attachment #2: Type: text/html, Size: 372 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git.py support for submodules 2014-05-17 17:13 git.py support for submodules Chris Morgan @ 2014-05-17 19:58 ` Christopher Larson 2014-05-17 20:17 ` Chris Morgan 0 siblings, 1 reply; 6+ messages in thread From: Christopher Larson @ 2014-05-17 19:58 UTC (permalink / raw) To: Chris Morgan; +Cc: yocto@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 571 bytes --] On Saturday, May 17, 2014, Chris Morgan <chmorgan@gmail.com> wrote: > Hello. > > I noticed that git.py doesn't seem to have support for submodules. I > worked around this in my recipe by adding a pre configure step but I was > wondering if a patch to add another option to git.py to fetch submodules > would make sense and be welcomed (pending it's implementation of course). > See gitsm.py. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics [-- Attachment #2: Type: text/html, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git.py support for submodules 2014-05-17 19:58 ` Christopher Larson @ 2014-05-17 20:17 ` Chris Morgan 2014-05-17 20:19 ` Christopher Larson 0 siblings, 1 reply; 6+ messages in thread From: Chris Morgan @ 2014-05-17 20:17 UTC (permalink / raw) To: Christopher Larson; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 815 bytes --] On May 17, 2014 3:58 PM, "Christopher Larson" <clarson@kergoth.com> wrote: > > > > On Saturday, May 17, 2014, Chris Morgan <chmorgan@gmail.com> wrote: >> >> Hello. >> >> I noticed that git.py doesn't seem to have support for submodules. I worked around this in my recipe by adding a pre configure step but I was wondering if a patch to add another option to git.py to fetch submodules would make sense and be welcomed (pending it's implementation of course). > > > See gitsm.py. > > > -- > Christopher Larson > clarson at kergoth dot com > Founder - BitBake, OpenEmbedded, OpenZaurus > Maintainer - Tslib > Senior Software Engineer, Mentor Graphics I couldn't actually figure out how to use it. I looked at the code and wasn't sure how it war supposed to do or what it was for. Chris [-- Attachment #2: Type: text/html, Size: 1136 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git.py support for submodules 2014-05-17 20:17 ` Chris Morgan @ 2014-05-17 20:19 ` Christopher Larson 2014-05-19 11:12 ` Richard Purdie 0 siblings, 1 reply; 6+ messages in thread From: Christopher Larson @ 2014-05-17 20:19 UTC (permalink / raw) To: Chris Morgan; +Cc: yocto@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 1423 bytes --] On Saturday, May 17, 2014, Chris Morgan <chmorgan@gmail.com> wrote: > > On May 17, 2014 3:58 PM, "Christopher Larson" <clarson@kergoth.com<javascript:_e(%7B%7D,'cvml','clarson@kergoth.com');>> > wrote: > > > > > > > > On Saturday, May 17, 2014, Chris Morgan <chmorgan@gmail.com<javascript:_e(%7B%7D,'cvml','chmorgan@gmail.com');>> > wrote: > >> > >> Hello. > >> > >> I noticed that git.py doesn't seem to have support for submodules. I > worked around this in my recipe by adding a pre configure step but I was > wondering if a patch to add another option to git.py to fetch submodules > would make sense and be welcomed (pending it's implementation of course). > > > > > > See gitsm.py. > > > > > > -- > > Christopher Larson > > clarson at kergoth dot com > > Founder - BitBake, OpenEmbedded, OpenZaurus > > Maintainer - Tslib > > Senior Software Engineer, Mentor Graphics > > I couldn't actually figure out how to use it. I looked at the code and > wasn't sure how it war supposed to do or what it was for. > You use it exactly the way you use git.py - gitsm:// instead of git://. It's basically git fetching plus submodule handling. I personally would rather see it merged into git.py, but I can see the reasoning. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics [-- Attachment #2: Type: text/html, Size: 1907 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git.py support for submodules 2014-05-17 20:19 ` Christopher Larson @ 2014-05-19 11:12 ` Richard Purdie 2014-05-21 14:47 ` Chris Morgan 0 siblings, 1 reply; 6+ messages in thread From: Richard Purdie @ 2014-05-19 11:12 UTC (permalink / raw) To: Christopher Larson; +Cc: yocto@yoctoproject.org On Sat, 2014-05-17 at 13:19 -0700, Christopher Larson wrote: > > > On Saturday, May 17, 2014, Chris Morgan <chmorgan@gmail.com> wrote: > > On May 17, 2014 3:58 PM, "Christopher Larson" > <clarson@kergoth.com> wrote: > > > > > > > > On Saturday, May 17, 2014, Chris Morgan <chmorgan@gmail.com> > wrote: > >> > >> Hello. > >> > >> I noticed that git.py doesn't seem to have support for > submodules. I worked around this in my recipe by adding a pre > configure step but I was wondering if a patch to add another > option to git.py to fetch submodules would make sense and be > welcomed (pending it's implementation of course). > > > > > > See gitsm.py. > > > > > > -- > > Christopher Larson > > clarson at kergoth dot com > > Founder - BitBake, OpenEmbedded, OpenZaurus > > Maintainer - Tslib > > Senior Software Engineer, Mentor Graphics > > > I couldn't actually figure out how to use it. I looked at the > code and wasn't sure how it war supposed to do or what it was > for. > > You use it exactly the way you use git.py - gitsm:// instead of > git://. It's basically git fetching plus submodule handling. I > personally would rather see it merged into git.py, but I can see the > reasoning. FWIW the reason its separate is that mirroring is not in a good state with submodules since git is doing magic things behind the scenes that the fetcher and its mirror infrastructure have no knowledge of. We should probably document that somewhere though. There are a few ways it can be fixed but its ugly and I'd prefer to have that code isolated for now. It could easily be merged later and it needs someone who cares about submodules to fix it up to be a first class citizen before that can happen. Cheers, Richard ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: git.py support for submodules 2014-05-19 11:12 ` Richard Purdie @ 2014-05-21 14:47 ` Chris Morgan 0 siblings, 0 replies; 6+ messages in thread From: Chris Morgan @ 2014-05-21 14:47 UTC (permalink / raw) To: Richard Purdie; +Cc: yocto@yoctoproject.org, Christopher Larson On Mon, May 19, 2014 at 7:12 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > On Sat, 2014-05-17 at 13:19 -0700, Christopher Larson wrote: >> >> >> On Saturday, May 17, 2014, Chris Morgan <chmorgan@gmail.com> wrote: >> >> On May 17, 2014 3:58 PM, "Christopher Larson" >> <clarson@kergoth.com> wrote: >> > >> > >> > >> > On Saturday, May 17, 2014, Chris Morgan <chmorgan@gmail.com> >> wrote: >> >> >> >> Hello. >> >> >> >> I noticed that git.py doesn't seem to have support for >> submodules. I worked around this in my recipe by adding a pre >> configure step but I was wondering if a patch to add another >> option to git.py to fetch submodules would make sense and be >> welcomed (pending it's implementation of course). >> > >> > >> > See gitsm.py. >> > >> > >> > -- >> > Christopher Larson >> > clarson at kergoth dot com >> > Founder - BitBake, OpenEmbedded, OpenZaurus >> > Maintainer - Tslib >> > Senior Software Engineer, Mentor Graphics >> > >> I couldn't actually figure out how to use it. I looked at the >> code and wasn't sure how it war supposed to do or what it was >> for. >> >> You use it exactly the way you use git.py - gitsm:// instead of >> git://. It's basically git fetching plus submodule handling. I >> personally would rather see it merged into git.py, but I can see the >> reasoning. > > FWIW the reason its separate is that mirroring is not in a good state > with submodules since git is doing magic things behind the scenes that > the fetcher and its mirror infrastructure have no knowledge of. We > should probably document that somewhere though. > > There are a few ways it can be fixed but its ugly and I'd prefer to have > that code isolated for now. It could easily be merged later and it needs > someone who cares about submodules to fix it up to be a first class > citizen before that can happen. > > Cheers, > > Richard > Here is an interesting twist on the same issue. It looks like if you have two recipes pointing to the same repository but with different git:// vs. gitsm://, that if the git:// runs first the one with gitsm:// will fail. I'm using multiple recipes against the same repository to build some internal code where several programs are in the same repository. I suppose the work around is to make them all gitsm:// but still... Chris ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-05-21 14:47 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-05-17 17:13 git.py support for submodules Chris Morgan 2014-05-17 19:58 ` Christopher Larson 2014-05-17 20:17 ` Chris Morgan 2014-05-17 20:19 ` Christopher Larson 2014-05-19 11:12 ` Richard Purdie 2014-05-21 14:47 ` Chris Morgan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.