Re: [PATCH 0/2] wic: looking by plugins and .wks file in all layers

[Tom Zanussi <tom.zanussi@linux.intel.com>]

On Wed, 2014-05-14 at 22:37 -0300, João Henrique Ferreira de Freitas
wrote:
> Hi,
> 
> This introduces a little wic usability enhanced. Now wic has the
> ability to search in all layers looking by .wks files and plugins.
> 
> The aim is to provide the layers a way to keep .wks and plugins that
> they use. Without this patch the user need to inform the full path of .wks, or put it
> in scripts directory. Or, in case of plugins, only putting in scripts directory.
> 
> Example:
> 
> In .wks case, inside my custom layer I have the following files: 
> 
> scripts/lib/image/canned-wks/
>  otns-directdisk-devel.wks
>  otns-directdisk.wks
>  otns-directsdcard-devel.wks
>  otns-directsdcard.wks
>  otns-nobml-directdisk-devel.wks
>  otns-nobml-directsdcard-devel.wks
> 
> So, I do:
> 
>  $ wic list images
>   otns-directdisk-devel                         Create a 'pcbios' direct disk image
>   otns-directdisk                               Create a 'pcbios' direct disk image
>   otns-nobml-directdisk-devel                   Create a 'pcbios' direct disk image
>   otns-nobml-directsdcard-devel                 Create a 'pcbios' direct disk image
>   otns-directsdcard                             Create a 'pcbios' direct disk image
>   otns-directsdcard-devel                       Create a 'pcbios' direct disk image
>   mkefidisk                                     Create an EFI disk image
>   directdisk                                    Create a 'pcbios' direct disk image
> 
> And to plugins case, in another layer, I have:
> 
> scripts/lib/mic/plugins/source/
>  bootimg-pcbios-myplugin.py
> 
> 
> To sum up, this enhanced wic because users could keep .wks and plugins inside their own layers.
> 

Very nice enhancement, makes a lot of sense.

Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>

> I don't know if using the 'scripts/lib/' is the best to keep files in layers. Any suggestion?
> 

I think it's fine and is consistent with the current path.

Tom

> Thanks.
> 
> João Henrique Ferreira de Freitas (2):
>   wic: add support to look in all layers and get .wks file
>   wic: add support to look in all layers and get plugins
> 
>  scripts/lib/image/engine.py | 72 +++++++++++++++++++++++++++------------------
>  scripts/lib/mic/plugin.py   | 28 ++++++++++++++----
>  scripts/wic                 |  6 ++++
>  3 files changed, 72 insertions(+), 34 deletions(-)
>