All of lore.kernel.org
 help / color / mirror / Atom feed
From: "João Henrique Ferreira de Freitas" <joaohf@gmail.com>
To: Adrian Calianu <Adrian.Calianu@enea.com>,
	 "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Cc: "tom.zanussi@linux.intel.com" <tom.zanussi@linux.intel.com>
Subject: Re: [PATCH 2/2] wic: add support to look in all layers and get plugins
Date: Tue, 03 Jun 2014 22:28:39 -0300	[thread overview]
Message-ID: <538E7647.2000803@gmail.com> (raw)
In-Reply-To: <A1661D2DDD942248A02617DE63569A0125CB32DA@SESTOEX04.enea.se>

Hi,

Thanks to point this.

> [Adrian Calianu]
> 1) It looks like a bad indentation, here, adding 'dl' path for each found BBLAYER. Probably those two lines from above should not be part of 'for' statement.

Yes, it is.

> 2) If BBLAYERS variable is empty/None then the "self.layers_path.split()" will generate an error:
> AttributeError: 'NoneType' object has no attribute 'split'

I will protect it. So if BBLAYERS is empty/None the default will be 
used. Then the raw mode of the wic works too.

-- 
João Henrique Ferreira de Freitas - joaohf_at_gmail.com
Campinas-SP-Brasil



  reply	other threads:[~2014-06-04  1:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-15  1:37 [PATCH 0/2] wic: looking by plugins and .wks file in all layers João Henrique Ferreira de Freitas
2014-05-15  1:37 ` [PATCH 1/2] wic: add support to look in all layers and get .wks file João Henrique Ferreira de Freitas
2014-05-15  1:37 ` [PATCH 2/2] wic: add support to look in all layers and get plugins João Henrique Ferreira de Freitas
2014-06-02  9:25   ` Adrian Calianu
2014-06-04  1:28     ` João Henrique Ferreira de Freitas [this message]
2014-05-19 14:00 ` [PATCH 0/2] wic: looking by plugins and .wks file in all layers Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538E7647.2000803@gmail.com \
    --to=joaohf@gmail.com \
    --cc=Adrian.Calianu@enea.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=tom.zanussi@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.