All of lore.kernel.org
 help / color / mirror / Atom feed
From: Weston Andros Adamson <dros@primarydata.com>
To: trond.myklebust@primarydata.com
Cc: linux-nfs@vger.kernel.org, Weston Andros Adamson <dros@primarydata.com>
Subject: [PATCH 8/8] pnfs: merge identical functions
Date: Mon, 19 May 2014 11:15:08 -0400	[thread overview]
Message-ID: <1400512508-7530-9-git-send-email-dros@primarydata.com> (raw)
In-Reply-To: <1400512508-7530-1-git-send-email-dros@primarydata.com>

pnfs_readhdr_free and pnfs_writehdr_free were identical - merge them
info pnfs_pgio_header_free. Also drop EXPORT_SYMBOL_GPL of static function.

Signed-off-by: Weston Andros Adamson <dros@primarydata.com>
---
 fs/nfs/pnfs.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 79792a4..d45cca8 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1552,12 +1552,11 @@ pnfs_do_write(struct nfs_pageio_descriptor *desc,
 	pnfs_put_lseg(lseg);
 }
 
-static void pnfs_writehdr_free(struct nfs_pgio_header *hdr)
+static void pnfs_pgio_header_free(struct nfs_pgio_header *hdr)
 {
 	pnfs_put_lseg(hdr->lseg);
 	nfs_pgio_header_free(hdr);
 }
-EXPORT_SYMBOL_GPL(pnfs_writehdr_free);
 
 int
 pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
@@ -1572,7 +1571,7 @@ pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
 		desc->pg_lseg = NULL;
 		return -ENOMEM;
 	}
-	nfs_pgheader_init(desc, hdr, pnfs_writehdr_free);
+	nfs_pgheader_init(desc, hdr, pnfs_pgio_header_free);
 	hdr->lseg = pnfs_get_lseg(desc->pg_lseg);
 	ret = nfs_generic_pgio(desc, hdr);
 	if (ret != 0) {
@@ -1671,13 +1670,6 @@ pnfs_do_read(struct nfs_pageio_descriptor *desc, struct nfs_pgio_header *hdr)
 	pnfs_put_lseg(lseg);
 }
 
-static void pnfs_readhdr_free(struct nfs_pgio_header *hdr)
-{
-	pnfs_put_lseg(hdr->lseg);
-	nfs_pgio_header_free(hdr);
-}
-EXPORT_SYMBOL_GPL(pnfs_readhdr_free);
-
 int
 pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)
 {
@@ -1692,7 +1684,7 @@ pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)
 		desc->pg_lseg = NULL;
 		return ret;
 	}
-	nfs_pgheader_init(desc, hdr, pnfs_readhdr_free);
+	nfs_pgheader_init(desc, hdr, pnfs_pgio_header_free);
 	hdr->lseg = pnfs_get_lseg(desc->pg_lseg);
 	ret = nfs_generic_pgio(desc, hdr);
 	if (ret != 0) {
-- 
1.8.5.2 (Apple Git-48)


  parent reply	other threads:[~2014-05-19 15:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 15:15 [PATCH 0/8] more pgio cleanup Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 1/8] nfs: move nfs_pgio_data and remove nfs_rw_header Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 2/8] nfs: rename members of nfs_pgio_data Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 3/8] nfs: merge nfs_pgio_data into _header Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 4/8] nfs: remove unused writeverf code Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 5/8] nfs: remove pgio_header refcount, related cleanup Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 6/8] pnfs: clean up *_resend_to_mds Weston Andros Adamson
2014-05-19 15:32   ` Christoph Hellwig
2014-05-19 19:25   ` Anna Schumaker
2014-05-19 19:57     ` Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 7/8] nfs: clean up function decls in nfs_page.h Weston Andros Adamson
2014-05-19 15:29   ` Jim Rees
2014-05-19 16:25     ` Weston Andros Adamson
2014-05-19 16:36       ` Jim Rees
2014-05-19 16:56         ` Weston Andros Adamson
2014-05-19 15:15 ` Weston Andros Adamson [this message]
2014-05-19 15:34   ` [PATCH 8/8] pnfs: merge identical functions Christoph Hellwig
2014-05-19 16:11     ` Anna Schumaker
2014-05-19 16:21       ` Weston Andros Adamson
2014-05-19 17:06         ` Anna Schumaker
2014-05-19 16:57       ` Christoph Hellwig
2014-05-19 17:06         ` Anna Schumaker
2014-05-19 17:11         ` Weston Andros Adamson
2014-05-19 17:44     ` Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400512508-7530-9-git-send-email-dros@primarydata.com \
    --to=dros@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.