From: Christoph Hellwig <hch@infradead.org>
To: Weston Andros Adamson <dros@primarydata.com>
Cc: trond.myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 6/8] pnfs: clean up *_resend_to_mds
Date: Mon, 19 May 2014 08:32:34 -0700 [thread overview]
Message-ID: <20140519153234.GA21345@infradead.org> (raw)
In-Reply-To: <1400512508-7530-7-git-send-email-dros@primarydata.com>
> + desc->pg_dreq = hdr->dreq;
> + while (!list_empty(&hdr->pages)) {
> + struct nfs_page *req = nfs_list_entry(hdr->pages.next);
> +
> + nfs_list_remove_request(req);
> + if (!nfs_pageio_add_request(desc, req))
> + nfs_list_add_request(req, &failed);
> + }
> + nfs_pageio_complete(desc);
I think you can also drop the export for nfs_pageio_complete now.
next prev parent reply other threads:[~2014-05-19 15:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 15:15 [PATCH 0/8] more pgio cleanup Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 1/8] nfs: move nfs_pgio_data and remove nfs_rw_header Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 2/8] nfs: rename members of nfs_pgio_data Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 3/8] nfs: merge nfs_pgio_data into _header Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 4/8] nfs: remove unused writeverf code Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 5/8] nfs: remove pgio_header refcount, related cleanup Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 6/8] pnfs: clean up *_resend_to_mds Weston Andros Adamson
2014-05-19 15:32 ` Christoph Hellwig [this message]
2014-05-19 19:25 ` Anna Schumaker
2014-05-19 19:57 ` Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 7/8] nfs: clean up function decls in nfs_page.h Weston Andros Adamson
2014-05-19 15:29 ` Jim Rees
2014-05-19 16:25 ` Weston Andros Adamson
2014-05-19 16:36 ` Jim Rees
2014-05-19 16:56 ` Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 8/8] pnfs: merge identical functions Weston Andros Adamson
2014-05-19 15:34 ` Christoph Hellwig
2014-05-19 16:11 ` Anna Schumaker
2014-05-19 16:21 ` Weston Andros Adamson
2014-05-19 17:06 ` Anna Schumaker
2014-05-19 16:57 ` Christoph Hellwig
2014-05-19 17:06 ` Anna Schumaker
2014-05-19 17:11 ` Weston Andros Adamson
2014-05-19 17:44 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519153234.GA21345@infradead.org \
--to=hch@infradead.org \
--cc=dros@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.