From: Ondrej Zary <linux@rainbow-software.org>
To: Samuel Chessman <chessman@tux.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/9] tlan: Fix MAC address byte order on OC-2325/OC-2326
Date: Tue, 27 May 2014 23:38:42 +0200 [thread overview]
Message-ID: <1401226727-5508-5-git-send-email-linux@rainbow-software.org> (raw)
In-Reply-To: <1401226727-5508-1-git-send-email-linux@rainbow-software.org>
Olicom OC-2325 and OC-2326 cards have the MAC address byte-swapped in EEPROM.
Byte-swap the MAC address if it's located at offset 0xF8.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
---
drivers/net/ethernet/ti/tlan.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
index ae9fece..31d4a96 100644
--- a/drivers/net/ethernet/ti/tlan.c
+++ b/drivers/net/ethernet/ti/tlan.c
@@ -864,7 +864,7 @@ static int tlan_init(struct net_device *dev)
priv->rx_list_dma + sizeof(struct tlan_list)*TLAN_NUM_RX_LISTS;
err = 0;
- for (i = 0; i < 6 ; i++)
+ for (i = 0; i < ETH_ALEN; i++)
err |= tlan_ee_read_byte(dev,
(u8) priv->adapter->addr_ofs + i,
(u8 *) &dev->dev_addr[i]);
@@ -872,7 +872,14 @@ static int tlan_init(struct net_device *dev)
pr_err("%s: Error reading MAC from eeprom: %d\n",
dev->name, err);
}
- dev->addr_len = 6;
+ /* Olicom OC-2325/OC-2326 have the address byte-swapped */
+ if (priv->adapter->addr_ofs == 0xf8) {
+ for (i = 0; i < ETH_ALEN; i += 2) {
+ char tmp = dev->dev_addr[i];
+ dev->dev_addr[i] = dev->dev_addr[i + 1];
+ dev->dev_addr[i + 1] = tmp;
+ }
+ }
netif_carrier_off(dev);
--
Ondrej Zary
next prev parent reply other threads:[~2014-05-27 21:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 21:38 [PATCH 0/9] tlan: Link handling improvements and Olicom fixes Ondrej Zary
2014-05-27 21:38 ` [PATCH 1/9] tlan: Enable activity LED on Olicom OC-2325 and OC-2326 Ondrej Zary
2014-05-27 21:38 ` [PATCH 2/9] tlan: Enable link monitoring Ondrej Zary
2014-05-27 21:38 ` [PATCH 3/9] tlan: Add ethtool support Ondrej Zary
2014-05-27 21:38 ` Ondrej Zary [this message]
2014-05-27 21:38 ` [PATCH 5/9] tlan: Restart autonegotiation on link loss Ondrej Zary
2014-05-27 22:29 ` Florian Fainelli
2014-05-28 6:39 ` Ondrej Zary
2014-05-28 17:26 ` Florian Fainelli
2014-05-28 14:08 ` Sergei Shtylyov
2014-05-27 21:38 ` [PATCH 6/9] tlan: Don't scream if no link Ondrej Zary
2014-05-27 21:38 ` [PATCH 7/9] tlan: Make autonegotiation faster Ondrej Zary
2014-05-28 14:11 ` Sergei Shtylyov
2014-05-27 21:38 ` [PATCH 8/9] tlan: Add PHY reset timeout Ondrej Zary
2014-05-27 21:38 ` [PATCH 9/9] tlan: Don't disable internal PHY on cards that use it in 10 Mbps mode Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401226727-5508-5-git-send-email-linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=chessman@tux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.