From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: aik@ozlabs.ru, Gavin Shan <gwshan@linux.vnet.ibm.com>,
kvm-ppc@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v7 3/3] drivers/vfio: EEH support for VFIO PCI device
Date: Wed, 28 May 2014 23:18:45 +0000 [thread overview]
Message-ID: <1401319125.8262.34.camel@pasglop> (raw)
In-Reply-To: <53866747.50703@suse.de>
On Thu, 2014-05-29 at 00:46 +0200, Alexander Graf wrote:
> I don't think so :). In QEMU the PHB emulation would have to notify the
> "container" (IOMMU emulation layer -> PE) that a PE operation happened.
> It's that emulation code's responsibility to broadcast operations across
> its own emulated operations (recover config space access, reconfigure
> BARs, etc) and the VFIO PE operations.
>
> So from a kernel interface point of view, I think leaving out any
> address information is the right way to go. Whether we managed to get
> all QEMU internal interfaces modeled correctly yet has to be seen on the
> next patch set revision :).
For a kernel interface I absolutely agree, all we care about is the group fd.
From a qemu internal, I suppose it makes things easier to operate at the PHB
level for now and we can revisit later if the need arises.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alexander Graf <agraf@suse.de>
Cc: aik@ozlabs.ru, Gavin Shan <gwshan@linux.vnet.ibm.com>,
kvm-ppc@vger.kernel.org,
Alex Williamson <alex.williamson@redhat.com>,
qiudayu@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v7 3/3] drivers/vfio: EEH support for VFIO PCI device
Date: Thu, 29 May 2014 09:18:45 +1000 [thread overview]
Message-ID: <1401319125.8262.34.camel@pasglop> (raw)
In-Reply-To: <53866747.50703@suse.de>
On Thu, 2014-05-29 at 00:46 +0200, Alexander Graf wrote:
> I don't think so :). In QEMU the PHB emulation would have to notify the
> "container" (IOMMU emulation layer -> PE) that a PE operation happened.
> It's that emulation code's responsibility to broadcast operations across
> its own emulated operations (recover config space access, reconfigure
> BARs, etc) and the VFIO PE operations.
>
> So from a kernel interface point of view, I think leaving out any
> address information is the right way to go. Whether we managed to get
> all QEMU internal interfaces modeled correctly yet has to be seen on the
> next patch set revision :).
For a kernel interface I absolutely agree, all we care about is the group fd.
>From a qemu internal, I suppose it makes things easier to operate at the PHB
level for now and we can revisit later if the need arises.
Cheers,
Ben.
next prev parent reply other threads:[~2014-05-28 23:18 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 8:40 [PATCH v7 0/3] EEH Support for VFIO PCI Device Gavin Shan
2014-05-27 8:40 ` Gavin Shan
2014-05-27 8:40 ` [PATCH v7 1/3] powerpc/eeh: Avoid event on passed PE Gavin Shan
2014-05-27 8:40 ` Gavin Shan
2014-05-27 8:40 ` [PATCH v7 2/3] powerpc/eeh: EEH support for VFIO PCI device Gavin Shan
2014-05-27 8:40 ` Gavin Shan
2014-05-27 8:40 ` [PATCH v7 3/3] drivers/vfio: " Gavin Shan
2014-05-27 8:40 ` Gavin Shan
2014-05-27 18:15 ` Alex Williamson
2014-05-27 18:15 ` Alex Williamson
2014-05-27 20:30 ` Benjamin Herrenschmidt
2014-05-27 20:30 ` Benjamin Herrenschmidt
2014-05-27 20:37 ` Alex Williamson
2014-05-27 20:37 ` Alex Williamson
2014-05-27 20:41 ` Benjamin Herrenschmidt
2014-05-27 20:41 ` Benjamin Herrenschmidt
2014-05-27 22:49 ` Alexander Graf
2014-05-27 22:49 ` Alexander Graf
2014-05-28 0:39 ` Alex Williamson
2014-05-28 0:39 ` Alex Williamson
2014-05-28 0:44 ` Alexander Graf
2014-05-28 0:44 ` Alexander Graf
2014-05-28 0:57 ` Alex Williamson
2014-05-28 0:57 ` Alex Williamson
2014-05-28 11:37 ` Alexander Graf
2014-05-28 11:37 ` Alexander Graf
2014-05-28 16:17 ` Alex Williamson
2014-05-28 16:17 ` Alex Williamson
2014-05-28 22:40 ` Alexander Graf
2014-05-28 22:40 ` Alexander Graf
2014-05-28 23:37 ` Gavin Shan
2014-05-28 23:37 ` Gavin Shan
2014-05-28 23:38 ` Alexander Graf
2014-05-28 23:38 ` Alexander Graf
2014-05-28 23:41 ` Gavin Shan
2014-05-28 23:41 ` Gavin Shan
2014-05-28 0:55 ` Gavin Shan
2014-05-28 0:55 ` Gavin Shan
2014-05-28 11:41 ` Alexander Graf
2014-05-28 11:41 ` Alexander Graf
2014-05-28 12:49 ` Gavin Shan
2014-05-28 12:49 ` Gavin Shan
2014-05-28 13:12 ` Alexander Graf
2014-05-28 13:12 ` Alexander Graf
2014-05-28 23:13 ` Gavin Shan
2014-05-28 23:13 ` Gavin Shan
2014-05-28 21:58 ` Benjamin Herrenschmidt
2014-05-28 21:58 ` Benjamin Herrenschmidt
2014-05-28 22:46 ` Alexander Graf
2014-05-28 22:46 ` Alexander Graf
2014-05-28 23:18 ` Benjamin Herrenschmidt [this message]
2014-05-28 23:18 ` Benjamin Herrenschmidt
2014-05-30 3:44 ` Alexey Kardashevskiy
2014-05-30 3:44 ` Alexey Kardashevskiy
2014-05-30 3:49 ` Benjamin Herrenschmidt
2014-05-30 3:49 ` Benjamin Herrenschmidt
2014-05-28 16:32 ` Alex Williamson
2014-05-28 16:32 ` Alex Williamson
2014-05-29 0:05 ` Gavin Shan
2014-05-29 0:05 ` Gavin Shan
2014-05-29 0:44 ` Benjamin Herrenschmidt
2014-05-29 0:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401319125.8262.34.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=qiudayu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.