From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 09/11] ARM: timer-sp: allow getting timer1 clock from DT to fallback to legacy clock
Date: Thu, 29 May 2014 17:40:19 -0500 [thread overview]
Message-ID: <1401403221-27523-10-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1401403221-27523-1-git-send-email-robherring2@gmail.com>
From: Rob Herring <robh@kernel.org>
The sp804 clocks may be specified in DT, but the kernel may still be using
legacy clocks. This is handled if a single clock for sp804 is present,
but not when 3 clocks are present.
This prevents Versatile platforms from breaking when the DT has clocks
added.
Signed-off-by: Rob Herring <robh@kernel.org>
Cc: Russell King <linux@arm.linux.org.uk>
---
v2:
- New patch necessary to handle DT with 3 clocks in sp804 node and still
use the legacy non-DT clocks.
arch/arm/common/timer-sp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/common/timer-sp.c b/arch/arm/common/timer-sp.c
index fd6bff0..1921132 100644
--- a/arch/arm/common/timer-sp.c
+++ b/arch/arm/common/timer-sp.c
@@ -233,13 +233,13 @@ static void __init sp804_of_init(struct device_node *np)
if (IS_ERR(clk1))
clk1 = NULL;
- /* Get the 2nd clock if the timer has 2 timer clocks */
+ /* Get the 2nd clock if the timer has 3 timer clocks */
if (of_count_phandle_with_args(np, "clocks", "#clock-cells") == 3) {
clk2 = of_clk_get(np, 1);
if (IS_ERR(clk2)) {
pr_err("sp804: %s clock not found: %d\n", np->name,
(int)PTR_ERR(clk2));
- goto err;
+ clk2 = NULL;
}
} else
clk2 = clk1;
--
1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Subject: [PATCH v2 09/11] ARM: timer-sp: allow getting timer1 clock from DT to fallback to legacy clock
Date: Thu, 29 May 2014 17:40:19 -0500 [thread overview]
Message-ID: <1401403221-27523-10-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1401403221-27523-1-git-send-email-robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
The sp804 clocks may be specified in DT, but the kernel may still be using
legacy clocks. This is handled if a single clock for sp804 is present,
but not when 3 clocks are present.
This prevents Versatile platforms from breaking when the DT has clocks
added.
Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
---
v2:
- New patch necessary to handle DT with 3 clocks in sp804 node and still
use the legacy non-DT clocks.
arch/arm/common/timer-sp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/common/timer-sp.c b/arch/arm/common/timer-sp.c
index fd6bff0..1921132 100644
--- a/arch/arm/common/timer-sp.c
+++ b/arch/arm/common/timer-sp.c
@@ -233,13 +233,13 @@ static void __init sp804_of_init(struct device_node *np)
if (IS_ERR(clk1))
clk1 = NULL;
- /* Get the 2nd clock if the timer has 2 timer clocks */
+ /* Get the 2nd clock if the timer has 3 timer clocks */
if (of_count_phandle_with_args(np, "clocks", "#clock-cells") == 3) {
clk2 = of_clk_get(np, 1);
if (IS_ERR(clk2)) {
pr_err("sp804: %s clock not found: %d\n", np->name,
(int)PTR_ERR(clk2));
- goto err;
+ clk2 = NULL;
}
} else
clk2 = clk1;
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-05-29 22:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 22:40 [PATCH v2 00/11] ARM: Versatile irq and clock DT support Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-29 22:40 ` [PATCH v2 01/11] dts: versatile: add missing irq controller properties Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-29 22:40 ` [PATCH v2 02/11] irqchip: versatile-fpga: Add IRQCHIP_DECLARE support Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-30 9:43 ` Linus Walleij
2014-05-30 9:43 ` Linus Walleij
2014-05-29 22:40 ` [PATCH v2 03/11] irqchip: versatile-fpga: add support for arm, versatile-sic Rob Herring
2014-05-29 22:40 ` [PATCH v2 03/11] irqchip: versatile-fpga: add support for arm,versatile-sic Rob Herring
2014-05-30 9:46 ` [PATCH v2 03/11] irqchip: versatile-fpga: add support for arm, versatile-sic Linus Walleij
2014-05-30 9:46 ` [PATCH v2 03/11] irqchip: versatile-fpga: add support for arm,versatile-sic Linus Walleij
2014-05-29 22:40 ` [PATCH v2 04/11] ARM: integrator: convert to use irqchip_init Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-30 9:47 ` Linus Walleij
2014-05-30 9:47 ` Linus Walleij
2014-05-29 22:40 ` [PATCH v2 05/11] ARM: versatile: remove init_irq hook for DT boot Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-30 9:48 ` Linus Walleij
2014-05-30 9:48 ` Linus Walleij
2014-05-29 22:40 ` [PATCH v2 06/11] dts: versatile: add pl180 compatible strings Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-29 22:40 ` [PATCH v2 07/11] dt/bindings: arm-boards: add binding for Versatile core module Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-30 9:49 ` Linus Walleij
2014-05-30 9:49 ` Linus Walleij
2014-05-29 22:40 ` [PATCH v2 08/11] dt/bindings: add compatible string for versatile osc clock Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-29 22:40 ` Rob Herring [this message]
2014-05-29 22:40 ` [PATCH v2 09/11] ARM: timer-sp: allow getting timer1 clock from DT to fallback to legacy clock Rob Herring
2014-05-29 22:40 ` [PATCH v2 10/11] dts: versatile: add clock tree Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-30 9:52 ` Linus Walleij
2014-05-30 9:52 ` Linus Walleij
2014-05-29 22:40 ` [PATCH v2 11/11] clk: versatile: add versatile OSC support Rob Herring
2014-05-29 22:40 ` Rob Herring
2014-05-30 9:55 ` Linus Walleij
2014-05-30 9:55 ` Linus Walleij
2014-05-30 23:03 ` Mike Turquette
2014-05-30 23:03 ` Mike Turquette
2014-05-31 2:38 ` Rob Herring
2014-05-31 2:38 ` Rob Herring
2014-06-02 21:08 ` Mike Turquette
2014-06-02 21:08 ` Mike Turquette
2014-05-30 9:41 ` [PATCH v2 00/11] ARM: Versatile irq and clock DT support Linus Walleij
2014-05-30 9:41 ` Linus Walleij
2014-05-30 12:17 ` Rob Herring
2014-05-30 12:17 ` Rob Herring
2014-06-21 2:10 ` Jason Cooper
2014-06-21 2:10 ` Jason Cooper
2014-06-23 11:08 ` Linus Walleij
2014-06-23 11:08 ` Linus Walleij
2014-06-26 12:52 ` Linus Walleij
2014-06-26 12:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401403221-27523-10-git-send-email-robherring2@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.