From: Matthew Garrett <matthew.garrett@nebula.com>
To: "andreas.noever@gmail.com" <andreas.noever@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"greg@kroah.com" <greg@kroah.com>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH v4 00/15] Thunderbolt driver for Apple MacBooks
Date: Sun, 1 Jun 2014 16:07:49 +0000 [thread overview]
Message-ID: <1401638869.7663.21.camel@x230> (raw)
In-Reply-To: <CAMxnaaURVhZ_SiJW7Qy1bsye1bcPE=J=vjL5MgTN5znP15WnXw@mail.gmail.com>
T24gU3VuLCAyMDE0LTA2LTAxIGF0IDEyOjExICswMjAwLCBBbmRyZWFzIE5vZXZlciB3cm90ZToN
Cj4gT24gU3VuLCBKdW4gMSwgMjAxNCBhdCAxOjUxIEFNLCBNYXR0aGV3IEdhcnJldHQNCj4gPG1h
dHRoZXcuZ2FycmV0dEBuZWJ1bGEuY29tPiB3cm90ZToNCj4gPiBUaGlzIHNlZW1zIHRvIGJlIHdv
cmtpbmcgd2VsbCBvbiBteSBNQlAuIEl0IGFwcGVhcnMgdG8gYnJvYWRseSB3b3JrIG9uDQo+ID4g
bXkgTWFjIFBybywgd2hpY2ggaGFzIFRodW5kZXJib2x0IDIgaGFyZHdhcmUgLSBJIGFkZGVkIHRo
ZSBQQ0kgSUQsIGFuZA0KPiA+IGxvYWRpbmcgdGhlIHRodW5kZXJib2x0IGRyaXZlciBhZnRlciB0
aGUgZGV2aWNlIGlzIHBsdWdnZWQgaW4gd29ya3MsIGJ1dA0KPiA+IGl0IHdvbid0IHJlY29nbmlz
ZSBob3RwbHVnIGV2ZW50cy4gSSBkb24ndCBhcHBlYXIgdG8gZ2V0IGFueSBpbnRlcnJ1cHRzDQo+
ID4gZnJvbSB0aGUgVGh1bmRlcmJvbHQgY29udHJvbGxlci4gQW55IGlkZWEgd2hhdCBtaWdodCBi
ZSBoYXBwZW5pbmcgdGhlcmU/DQo+IFNvIHRoZSBjb21tdW5pY2F0aW9uIHdpdGggdGhlIGNvbnRy
b2xsZXIgd29ya3MgKGRtZXNnIGR1bXBzIGEgbGlzdCBvZg0KPiBwb3J0cyBldGMuKT8gRG8geW91
IGdldCBwbHVnIGV2ZW50cyAoInJlc2V0dGluZyBlcnJvciBvbiBwb3J0IC4uLiIpPw0KPiBZb3Ug
Y291bGQgdHJ5IHRvIHBsYXkgYXJvdW5kIHdpdGggdGJfcGx1Z19ldmVudHNfYWN0aXZlLCBpZiB5
b3Ugd2FudA0KPiB0byBleHBlcmltZW50LiBJIGNhbiBhbHNvIHRha2UgYW5vdGhlciBsb29rIGF0
IHdoYXQgT1MgWCBkb2VzIG9uY2UgSQ0KPiBnZXQgYmFjayB0byBteSB3b3Jrc3RhdGlvbiAod2hl
biBJIHdvcmtlZCBvbiB0aGlzIHBhcnQgZmFsY29uIHJpZGdlDQo+IHdhcyBub3QgamV0IHJlbGVh
c2VkLCBzbyBtYXliZSB0aGV5IGRvIHRoaW5ncyBkaWZmZXJlbnRseSBub3cpLg0KDQpZZWFoLCB0
aGF0IHdhcyBpdC4gSSdsbCBtYWlsIHRoZSBwYXRjaCBzZXBhcmF0ZWx5Lg0KDQoNCj4gPiBBcyBm
YXIgYXMgdGhlIHF1aXJrcyBnbyAtIHBlcmhhcHMgc29tZXRoaW5nIGxpa2UgdGhpcyB3b3VsZCBi
ZQ0KPiA+IHJlYXNvbmFibGUsIHJhdGhlciB0aGFuIG1haW50YWluaW5nIGEgbGlzdCBvZiBtYWNo
aW5lcz8NCj4gSSBoYXZlIG9idGFpbmVkIEFDUEkgZHVtcHMgZnJvbSBhIGxhdGUgMjAxMyBNQlAg
YW5kIGZyb20gYSBNYWNQcm8NCj4gKGJvdGggYXJlIGZhbGNvbiByaWRnZSBkZXZpY2VzKSBhbmQg
dGhlc2UgY29udGFpbiBhIGZldyBmaXJtd2FyZQ0KPiBjaGFuZ2VzLiBGb3IgZXhhbXBsZSBTWElP
LCBTWElMIGFuZCBTWExWIGFyZSBnb25lIHNvIHRoZSBzaHV0ZG93bg0KPiBxdWlyayB3aWxsIGZh
aWwuIFdpdGggc29tZSBsdWNrIHRoYXQgbWVhbnMgdGhhdCB0aGUgc2h1dGRvd24gcXVpcmsgaXMN
Cj4gbm8gbG9uZ2VyIHJlcXVpcmVkIGZvciBmYWxjb24gcmlkZ2UgaGFyZHdhcmUuDQoNClllYWgs
IGl0IHNlZW1zIEkgZG9uJ3QgbmVlZCB0aGUgc3VzcGVuZCBxdWlyayAtIHRoZSBOSEkgaXMgc3Rp
bGwgdGhlcmUNCndpdGhvdXQgaXQuIEkgc3RpbGwgdGhpbmsgd2Ugc2hvdWxkIG1ha2UgdGhlIHF1
aXJrIGdlbmVyYWwgcmF0aGVyIHRoYW4NCnR5aW5nIGl0IHRvIHRoZSBtYWNoaW5lcywgdGhlIHdv
cnN0IGNhc2UgaXMgdGhhdCBpdCdsbCBqdXN0IGRvIG5vdGhpbmcuDQoNCi0tIA0KTWF0dGhldyBH
YXJyZXR0IDxtYXR0aGV3LmdhcnJldHRAbmVidWxhLmNvbT4NCg==
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "andreas.noever@gmail.com" <andreas.noever@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"greg@kroah.com" <greg@kroah.com>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH v4 00/15] Thunderbolt driver for Apple MacBooks
Date: Sun, 1 Jun 2014 16:07:49 +0000 [thread overview]
Message-ID: <1401638869.7663.21.camel@x230> (raw)
In-Reply-To: <CAMxnaaURVhZ_SiJW7Qy1bsye1bcPE=J=vjL5MgTN5znP15WnXw@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1875 bytes --]
On Sun, 2014-06-01 at 12:11 +0200, Andreas Noever wrote:
> On Sun, Jun 1, 2014 at 1:51 AM, Matthew Garrett
> <matthew.garrett@nebula.com> wrote:
> > This seems to be working well on my MBP. It appears to broadly work on
> > my Mac Pro, which has Thunderbolt 2 hardware - I added the PCI ID, and
> > loading the thunderbolt driver after the device is plugged in works, but
> > it won't recognise hotplug events. I don't appear to get any interrupts
> > from the Thunderbolt controller. Any idea what might be happening there?
> So the communication with the controller works (dmesg dumps a list of
> ports etc.)? Do you get plug events ("resetting error on port ...")?
> You could try to play around with tb_plug_events_active, if you want
> to experiment. I can also take another look at what OS X does once I
> get back to my workstation (when I worked on this part falcon ridge
> was not jet released, so maybe they do things differently now).
Yeah, that was it. I'll mail the patch separately.
> > As far as the quirks go - perhaps something like this would be
> > reasonable, rather than maintaining a list of machines?
> I have obtained ACPI dumps from a late 2013 MBP and from a MacPro
> (both are falcon ridge devices) and these contain a few firmware
> changes. For example SXIO, SXIL and SXLV are gone so the shutdown
> quirk will fail. With some luck that means that the shutdown quirk is
> no longer required for falcon ridge hardware.
Yeah, it seems I don't need the suspend quirk - the NHI is still there
without it. I still think we should make the quirk general rather than
tying it to the machines, the worst case is that it'll just do nothing.
--
Matthew Garrett <matthew.garrett@nebula.com>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2014-06-01 16:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 14:27 [PATCH v4 00/15] Thunderbolt driver for Apple MacBooks Andreas Noever
2014-05-31 14:27 ` [PATCH v4 01/15] thunderbolt: Add initial cactus ridge NHI support Andreas Noever
2014-05-31 14:27 ` [PATCH v4 02/15] thunderbolt: Add control channel interface Andreas Noever
2014-05-31 14:27 ` [PATCH v4 03/15] thunderbolt: Setup control channel Andreas Noever
2014-05-31 14:27 ` [PATCH v4 04/15] thunderbolt: Add tb_regs.h Andreas Noever
2014-05-31 14:27 ` [PATCH v4 05/15] thunderbolt: Initialize root switch and ports Andreas Noever
2014-05-31 14:27 ` [PATCH v4 06/15] thunderbolt: Add thunderbolt capability handling Andreas Noever
2014-05-31 14:27 ` [PATCH v4 07/15] thunderbolt: Enable plug events Andreas Noever
2014-05-31 14:27 ` [PATCH v4 08/15] thunderbolt: Scan for downstream switches Andreas Noever
2014-05-31 14:27 ` [PATCH v4 09/15] thunderbolt: Handle hotplug events Andreas Noever
2014-05-31 14:27 ` [PATCH v4 10/15] thunderbolt: Add path setup code Andreas Noever
2014-05-31 14:27 ` [PATCH v4 11/15] thunderbolt: Add support for simple pci tunnels Andreas Noever
2014-05-31 14:27 ` [PATCH v4 12/15] PCI: Add pci_fixup_suspend_late quirk pass Andreas Noever
2014-05-31 14:27 ` [PATCH v4 13/15] PCI: Suspend/resume quirks for Apple thunderbolt Andreas Noever
2014-05-31 14:27 ` [PATCH v4 14/15] thunderbolt: Read switch uid from EEPROM Andreas Noever
2014-05-31 14:28 ` [PATCH v4 15/15] thunderbolt: Add suspend/hibernate support Andreas Noever
2014-05-31 17:51 ` [PATCH v4 00/15] Thunderbolt driver for Apple MacBooks Greg KH
2014-05-31 23:51 ` Matthew Garrett
2014-05-31 23:51 ` Matthew Garrett
2014-06-01 10:11 ` Andreas Noever
2014-06-01 16:07 ` Matthew Garrett [this message]
2014-06-01 16:07 ` Matthew Garrett
2014-06-01 20:45 ` Andreas Noever
2014-06-01 22:02 ` Matthew Garrett
2014-06-01 22:02 ` Matthew Garrett
2014-06-01 22:57 ` greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401638869.7663.21.camel@x230 \
--to=matthew.garrett@nebula.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.