From: Matthew Garrett <matthew.garrett@nebula.com>
To: "andreas.noever@gmail.com" <andreas.noever@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"greg@kroah.com" <greg@kroah.com>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH] Thunderbolt: Add support for Thunderbolt 2 host controllers
Date: Sun, 1 Jun 2014 22:05:32 +0000 [thread overview]
Message-ID: <1401660332.7663.26.camel@x230> (raw)
In-Reply-To: <CAMxnaaUh0s5A6x=N9VEeHGFkATDsYAtfz3JoLOLYA5jKSVyFwA@mail.gmail.com>
T24gU3VuLCAyMDE0LTA2LTAxIGF0IDIyOjQyICswMjAwLCBBbmRyZWFzIE5vZXZlciB3cm90ZToN
Cg0KPiBKdXN0IHRvIGNoZWNrOiBEaWQgdGhleSBzcGxpdCB1cCB0aGUgZGV2aWNlIGlkcz8gSXMg
MHgxNTZkIGZvciB0aGUNCj4gYnJpZGdlcyBhbmQgMHgxNTZjIGZvciB0aGUgTkhJPw0KDQpZZXMu
IFNvbWUga2luZCBvZiBwcm9ncmVzcy4gSSBkaWQgbm90aWNlIHRoYXQgdGhlIEFwcGxlIGRyaXZl
ciBiaW5kcyB0bw0KYWxsIGRldmljZXMgd2l0aCB0aGUgc3lzdGVtIHBlcmlwaGVyYWwgY2xhc3Ms
IHZlbmRvciA4MDg2IGFuZCBkZXZpY2UNCjE1eHggLSBJIGRvbid0IHRoaW5rIHdlIGNhbiByZXBy
ZXNlbnQgdGhhdCBpbiBMaW51eCBhdCB0aGUgbW9tZW50Lg0KDQo+IEkgaGF2ZSBoYWQgYSBsb29r
IGF0IHdoYXQgb3MgeCBkb2VzLiBUaGV5IHNwbGl0IGJldHdlZW46DQo+IDE1MTMsIDE1MWEsIDE1
NDkgYW5kIDE1NDcsIDE1NDgsIDE1NjcsIDE1NjksIDE1NmIsIDE1NmQgKHRoZSBsYXR0ZXINCj4g
Z3JvdXAgZ2V0cyBiaXQgMyBzZXQpDQo+IA0KPiBJdCBsb29rcyBsaWtlIHRoZSBmaXJzdCAzIGFy
ZSBsZWdhY3kgZGV2aWNlcywgc28gbWF5YmUgcmV2ZXJzZSB0aGUgY2hlY2s/DQoNClNlZW1zIGZh
aXIuIEkgcHJvYmFibHkgd29uJ3QgaGF2ZSB0aW1lIHRvIHJlc2VuZCBmb3IgYSBjb3VwbGUgb2Yg
ZGF5cyAtDQppZiBpdCdzIGVhc2llciwgcGxlYXNlIGRvIGp1c3QgcmV3b3JrIHRoaXMgeW91cnNl
bGYuDQoNCi0tIA0KTWF0dGhldyBHYXJyZXR0IDxtYXR0aGV3LmdhcnJldHRAbmVidWxhLmNvbT4N
Cg==
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "andreas.noever@gmail.com" <andreas.noever@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"greg@kroah.com" <greg@kroah.com>,
"bhelgaas@google.com" <bhelgaas@google.com>
Subject: Re: [PATCH] Thunderbolt: Add support for Thunderbolt 2 host controllers
Date: Sun, 1 Jun 2014 22:05:32 +0000 [thread overview]
Message-ID: <1401660332.7663.26.camel@x230> (raw)
In-Reply-To: <CAMxnaaUh0s5A6x=N9VEeHGFkATDsYAtfz3JoLOLYA5jKSVyFwA@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 939 bytes --]
On Sun, 2014-06-01 at 22:42 +0200, Andreas Noever wrote:
> Just to check: Did they split up the device ids? Is 0x156d for the
> bridges and 0x156c for the NHI?
Yes. Some kind of progress. I did notice that the Apple driver binds to
all devices with the system peripheral class, vendor 8086 and device
15xx - I don't think we can represent that in Linux at the moment.
> I have had a look at what os x does. They split between:
> 1513, 151a, 1549 and 1547, 1548, 1567, 1569, 156b, 156d (the latter
> group gets bit 3 set)
>
> It looks like the first 3 are legacy devices, so maybe reverse the check?
Seems fair. I probably won't have time to resend for a couple of days -
if it's easier, please do just rework this yourself.
--
Matthew Garrett <matthew.garrett@nebula.com>
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2014-06-01 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 16:13 [PATCH] Thunderbolt: Add support for Thunderbolt 2 host controllers Matthew Garrett
2014-06-01 20:42 ` Andreas Noever
2014-06-01 22:05 ` Matthew Garrett [this message]
2014-06-01 22:05 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401660332.7663.26.camel@x230 \
--to=matthew.garrett@nebula.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.