Can DATABASE_URL also be read from toaster.conf

Can DATABASE_URL also be read from toaster.conf

[Lerner, Dave]

Hi Alex,

In your latest 20140650-bldcontrol push, you include a simpler model to specify a global database path via a shell variable, DATABASE_URL.  If set, the variable is parsed in settings.py, overriding the simple $pwd/toaster.sqlite, ... values.  It works great for me.

What do you think of reading DATABASE_URL, if present, from conf/toaster.conf?

That value would override the shell variable value if both are present?  If neither the toaster.conf:DATABASE_URL nor the shell variable DATABASE_URL exist, then it defaults as it does now.  

Thanks,
Dave Lerner

Re: Can DATABASE_URL also be read from toaster.conf

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

Hello,

I'm sorry for the late reply - I'm not sure how I didn't see this mail
until now.

About having the DATABASE_URL in toaster.conf, I feel that this would break
the separation between core bitbake and Django environments - toaster.conf
is designed to be read and used by the bitbake core.

As such, changing the value of this variable in toaster.conf will
invalidate task signatures and caches of tasks, even if the value itself is
irrelevant to the build task execution processes. This is likely to confuse
users and trigger problems with cache reuse. More code would need to be
added to bitbake to make this variable transparent to the build process.

This being said, I'm not sure about the use case you have in mind - can you
please give me more details on why this would be useful ?

Alex


On Fri, May 30, 2014 at 8:20 PM, Lerner, Dave <dave.lerner@windriver.com>
wrote:

> Hi Alex,
>
> In your latest 20140650-bldcontrol push, you include a simpler model to
> specify a global database path via a shell variable, DATABASE_URL.  If set,
> the variable is parsed in settings.py, overriding the simple
> $pwd/toaster.sqlite, ... values.  It works great for me.
>
> What do you think of reading DATABASE_URL, if present, from
> conf/toaster.conf?
>
> That value would override the shell variable value if both are present?
>  If neither the toaster.conf:DATABASE_URL nor the shell variable
> DATABASE_URL exist, then it defaults as it does now.
>
> Thanks,
> Dave Lerner
>



-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 2203 bytes --]

Re: Can DATABASE_URL also be read from toaster.conf

[Richard Purdie]

On Tue, 2014-06-03 at 14:09 +0100, Damian, Alexandru wrote:
> Hello,
> 
> I'm sorry for the late reply - I'm not sure how I didn't see this mail
> until now.
> 
> 
> About having the DATABASE_URL in toaster.conf, I feel that this would
> break the separation between core bitbake and Django environments -
> toaster.conf is designed to be read and used by the bitbake core. 
> 
> As such, changing the value of this variable in toaster.conf will
> invalidate task signatures and caches of tasks, even if the value
> itself is irrelevant to the build task execution processes. This is
> likely to confuse users and trigger problems with cache reuse. More
> code would need to be added to bitbake to make this variable
> transparent to the build process.

Changing an incidental variable like this will trigger reparses and will
invalidate some caches but the task signatures themselves wouldn't
change due to it since they have no dependency on the variable.

I make no comment on whether its a good/bad idea, just want to ensure we
base the decisions on the right data.

Cheers,

Richard