* [RESEND][PATCH v2] platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset range check
@ 2014-06-08 12:54 Axel Lin
0 siblings, 0 replies; only message in thread
From: Axel Lin @ 2014-06-08 12:54 UTC (permalink / raw)
To: Matthew Garrett; +Cc: Alek Du, platform-driver-x86
Only pin 0-7 support input, so the valid offset range should be 0 ~ 7.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Alek Du <alek.du@intel.com>
---
Hi Matthew,
This patch was sent on http://www.spinics.net/lists/platform-driver-x86/msg05259.html.
Seems this patch is not applied yet. So here is a resend.
Axel
drivers/platform/x86/intel_pmic_gpio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel_pmic_gpio.c b/drivers/platform/x86/intel_pmic_gpio.c
index 2805988..40929e4 100644
--- a/drivers/platform/x86/intel_pmic_gpio.c
+++ b/drivers/platform/x86/intel_pmic_gpio.c
@@ -91,7 +91,7 @@ static void pmic_program_irqtype(int gpio, int type)
static int pmic_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
{
- if (offset > 8) {
+ if (offset >= 8) {
pr_err("only pin 0-7 support input\n");
return -1;/* we only have 8 GPIO can use as input */
}
@@ -130,7 +130,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned offset)
int ret;
/* we only have 8 GPIO pins we can use as input */
- if (offset > 8)
+ if (offset >= 8)
return -EOPNOTSUPP;
ret = intel_scu_ipc_ioread8(GPIO0 + offset, &r);
if (ret < 0)
--
1.8.3.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-06-08 12:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-08 12:54 [RESEND][PATCH v2] platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset range check Axel Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.