From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: spear: Remove references to PLAT_SPEAR_SINGLE
Date: Mon, 16 Jun 2014 13:49:47 +0200 [thread overview]
Message-ID: <1402919387.30599.4.camel@x220> (raw)
In-Reply-To: <534CFB45.9070704@st.com>
On Tue, 2014-04-15 at 14:56 +0530, Rajeev kumar wrote:
> On 4/15/2014 1:56 PM, Paul Bolle wrote:
> > The Kconfig symbol PLAT_SPEAR_SINGLE briefly appeared during the v3.10
> > development cycle. It was removed in a merge commit before v3.10. A few
> > references to it were left in the tree, probably because they didn't
> > generate merge conflicts. Whatever it was, they're useless now and can
> > safely be removed.
> >
> > Reported-by: Martin Walch <walch.martin@web.de>
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > 0) First version was broken: it left config ARCH_SPEAR_AUTO without its
> > bool type. This version is done on top of v3.15-rc1.
> >
> > 1) Still untested.
> >
> > arch/arm/mach-spear/Kconfig | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/mach-spear/Kconfig b/arch/arm/mach-spear/Kconfig
> > index 0786249b2832..bc8a11c53377 100644
> > --- a/arch/arm/mach-spear/Kconfig
> > +++ b/arch/arm/mach-spear/Kconfig
> > @@ -4,7 +4,6 @@
> >
> > menuconfig PLAT_SPEAR
> > bool "ST SPEAr Family" if ARCH_MULTI_V7 || ARCH_MULTI_V5
> > - default PLAT_SPEAR_SINGLE
> > select ARCH_REQUIRE_GPIOLIB
> > select ARM_AMBA
> > select CLKSRC_MMIO
> > @@ -13,7 +12,7 @@ if PLAT_SPEAR
> >
> > config ARCH_SPEAR13XX
> > bool "ST SPEAr13xx"
> > - depends on ARCH_MULTI_V7 || PLAT_SPEAR_SINGLE
> > + depends on ARCH_MULTI_V7
> > select ARCH_HAS_CPUFREQ
> > select ARM_GIC
> > select GPIO_SPEAR_SPICS
> > @@ -41,7 +40,7 @@ endif #ARCH_SPEAR13XX
> >
> > config ARCH_SPEAR3XX
> > bool "ST SPEAr3xx"
> > - depends on ARCH_MULTI_V5 || PLAT_SPEAR_SINGLE
> > + depends on ARCH_MULTI_V5
> > depends on !ARCH_SPEAR13XX
> > select ARM_VIC
> > select PINCTRL
> > @@ -72,7 +71,7 @@ endif
> >
> > config ARCH_SPEAR6XX
> > bool "ST SPEAr6XX"
> > - depends on ARCH_MULTI_V5 || PLAT_SPEAR_SINGLE
> > + depends on ARCH_MULTI_V5
> > depends on !ARCH_SPEAR13XX
> > select ARM_VIC
> > help
> > @@ -85,7 +84,7 @@ config MACH_SPEAR600
> > Supports ST SPEAr600 boards configured via the device-tree
> >
> > config ARCH_SPEAR_AUTO
> > - def_bool PLAT_SPEAR_SINGLE
> > + bool
> > depends on !ARCH_SPEAR13XX && !ARCH_SPEAR6XX
> > select ARCH_SPEAR3XX
> >
> >
>
>
> Reviewed-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
Thanks!
This can still be seen in v3.16-rc1 and in today's linux-next (ie,
next-20140616). Is this trivial patch queued somewhere?
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Rajeev kumar <rajeev-dlh.kumar@st.com>
Cc: Viresh Kumar <viresh.linux@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Martin Walch <walch.martin@web.de>,
Richard Weinberger <richard@nod.at>,
spear-devel <spear-devel@list.st.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: spear: Remove references to PLAT_SPEAR_SINGLE
Date: Mon, 16 Jun 2014 13:49:47 +0200 [thread overview]
Message-ID: <1402919387.30599.4.camel@x220> (raw)
In-Reply-To: <534CFB45.9070704@st.com>
On Tue, 2014-04-15 at 14:56 +0530, Rajeev kumar wrote:
> On 4/15/2014 1:56 PM, Paul Bolle wrote:
> > The Kconfig symbol PLAT_SPEAR_SINGLE briefly appeared during the v3.10
> > development cycle. It was removed in a merge commit before v3.10. A few
> > references to it were left in the tree, probably because they didn't
> > generate merge conflicts. Whatever it was, they're useless now and can
> > safely be removed.
> >
> > Reported-by: Martin Walch <walch.martin@web.de>
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > 0) First version was broken: it left config ARCH_SPEAR_AUTO without its
> > bool type. This version is done on top of v3.15-rc1.
> >
> > 1) Still untested.
> >
> > arch/arm/mach-spear/Kconfig | 9 ++++-----
> > 1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/mach-spear/Kconfig b/arch/arm/mach-spear/Kconfig
> > index 0786249b2832..bc8a11c53377 100644
> > --- a/arch/arm/mach-spear/Kconfig
> > +++ b/arch/arm/mach-spear/Kconfig
> > @@ -4,7 +4,6 @@
> >
> > menuconfig PLAT_SPEAR
> > bool "ST SPEAr Family" if ARCH_MULTI_V7 || ARCH_MULTI_V5
> > - default PLAT_SPEAR_SINGLE
> > select ARCH_REQUIRE_GPIOLIB
> > select ARM_AMBA
> > select CLKSRC_MMIO
> > @@ -13,7 +12,7 @@ if PLAT_SPEAR
> >
> > config ARCH_SPEAR13XX
> > bool "ST SPEAr13xx"
> > - depends on ARCH_MULTI_V7 || PLAT_SPEAR_SINGLE
> > + depends on ARCH_MULTI_V7
> > select ARCH_HAS_CPUFREQ
> > select ARM_GIC
> > select GPIO_SPEAR_SPICS
> > @@ -41,7 +40,7 @@ endif #ARCH_SPEAR13XX
> >
> > config ARCH_SPEAR3XX
> > bool "ST SPEAr3xx"
> > - depends on ARCH_MULTI_V5 || PLAT_SPEAR_SINGLE
> > + depends on ARCH_MULTI_V5
> > depends on !ARCH_SPEAR13XX
> > select ARM_VIC
> > select PINCTRL
> > @@ -72,7 +71,7 @@ endif
> >
> > config ARCH_SPEAR6XX
> > bool "ST SPEAr6XX"
> > - depends on ARCH_MULTI_V5 || PLAT_SPEAR_SINGLE
> > + depends on ARCH_MULTI_V5
> > depends on !ARCH_SPEAR13XX
> > select ARM_VIC
> > help
> > @@ -85,7 +84,7 @@ config MACH_SPEAR600
> > Supports ST SPEAr600 boards configured via the device-tree
> >
> > config ARCH_SPEAR_AUTO
> > - def_bool PLAT_SPEAR_SINGLE
> > + bool
> > depends on !ARCH_SPEAR13XX && !ARCH_SPEAR6XX
> > select ARCH_SPEAR3XX
> >
> >
>
>
> Reviewed-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
Thanks!
This can still be seen in v3.16-rc1 and in today's linux-next (ie,
next-20140616). Is this trivial patch queued somewhere?
Paul Bolle
next prev parent reply other threads:[~2014-06-16 11:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 21:21 [PATCH] ARM: spear: Remove references to PLAT_SPEAR_SINGLE Paul Bolle
2014-02-11 21:21 ` Paul Bolle
2014-02-11 21:27 ` Paul Bolle
2014-02-11 21:27 ` Paul Bolle
2014-04-15 8:26 ` [PATCH v2] " Paul Bolle
2014-04-15 8:26 ` Paul Bolle
2014-04-15 9:26 ` Rajeev kumar
2014-04-15 9:26 ` Rajeev kumar
2014-06-16 11:49 ` Paul Bolle [this message]
2014-06-16 11:49 ` Paul Bolle
2014-09-05 9:27 ` Paul Bolle
2014-09-05 9:27 ` Paul Bolle
2014-09-05 9:39 ` Paul Bolle
2014-09-05 9:39 ` Paul Bolle
2014-09-05 9:43 ` Viresh Kumar
2014-09-05 9:43 ` Viresh Kumar
2014-09-05 9:50 ` Paul Bolle
2014-09-05 9:50 ` Paul Bolle
2014-09-05 9:54 ` Viresh Kumar
2014-09-05 9:54 ` Viresh Kumar
2014-09-05 11:38 ` Arnd Bergmann
2014-09-05 11:38 ` Arnd Bergmann
2014-09-05 11:53 ` Paul Bolle
2014-09-05 11:53 ` Paul Bolle
2014-09-05 9:46 ` bhupesh.sharma at freescale.com
2014-09-05 9:46 ` bhupesh.sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402919387.30599.4.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.