From: Joe Perches <joe@perches.com>
To: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
Cc: devel@linuxdriverproject.org,
Maximilian Eschenbacher <maximilian@eschenbacher.email>,
linux-kernel@i4.cs.fau.de,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tugce Sirin <ztugcesirin@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Neil Armstrong <superna9999@gmail.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Vitaly Osipov <vitaly.osipov@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] wlan-ng/prism2sta:checkpatch: Fix long lines
Date: Thu, 19 Jun 2014 13:22:12 -0700 [thread overview]
Message-ID: <1403209332.2753.2.camel@joe-AO725> (raw)
In-Reply-To: <1403205620-10219-6-git-send-email-Johannes.Stadlinger@fau.de>
On Thu, 2014-06-19 at 21:20 +0200, Johannes Stadlinger wrote:
> This patch fixes all warning of checkpatch about lines over 80
> characters.
trivia:
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
[]
> @@ -1271,7 +1275,8 @@ void prism2sta_processing_defer(struct work_struct *data)
> HFA384x_RID_CURRENTSSID, result);
> return;
> }
> - prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *) &ssid,
> + prism2mgmt_bytestr2pstr((struct hfa384x_bytestr *)
> + &ssid,
> (p80211pstrd_t *) &
> wlandev->ssid);
I don't find this better or easier to read.
Sometimes it's easier to read to cast to a
void * instead of the specific type
prism2mgmt_bytestr2pstr((void *)&ssid,
(void *)&wlandev->ssid);
next prev parent reply other threads:[~2014-06-19 20:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 19:20 [PATCH 1/8] wlan-ng/prism2mgmt:checkpatch: Fix long lines Johannes Stadlinger
2014-06-19 19:20 ` [PATCH 2/8] wlan-ng/prism2mgmt:checkpatch: Fix string split Johannes Stadlinger
2014-06-19 20:09 ` josh
2014-06-19 19:20 ` [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line Johannes Stadlinger
2014-06-19 20:11 ` josh
2014-06-20 8:14 ` Dan Carpenter
2014-06-19 19:20 ` [PATCH 4/8] wlan-ng/prism2mib:checkpatch: Fix string split Johannes Stadlinger
2014-06-19 20:12 ` josh
2014-06-19 19:20 ` [PATCH 5/8] wlan-ng/prism2mib:checkpatch: Insert blank lines Johannes Stadlinger
2014-06-19 20:14 ` josh
2014-06-19 20:25 ` Joe Perches
2014-06-19 19:20 ` [PATCH 6/8] wlan-ng/prism2sta:checkpatch: Fix long lines Johannes Stadlinger
2014-06-19 20:19 ` josh
2014-06-19 20:22 ` Joe Perches [this message]
2014-06-19 19:20 ` [PATCH 7/8] wlan-ng/prism2sta:checkpatch: Fix string split Johannes Stadlinger
2014-06-19 20:20 ` josh
2014-06-19 19:20 ` [PATCH 8/8] wlan-ng/prism2sta:checkpatch: Insert blank lines Johannes Stadlinger
2014-06-19 20:20 ` josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403209332.2753.2.camel@joe-AO725 \
--to=joe@perches.com \
--cc=Johannes.Stadlinger@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=maximilian@eschenbacher.email \
--cc=paul.gortmaker@windriver.com \
--cc=superna9999@gmail.com \
--cc=vitaly.osipov@gmail.com \
--cc=ztugcesirin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.