Re: [PATCH 3/8] wlan-ng/prism2mgmt:checkpatch: Insert blank line

[Dan Carpenter <dan.carpenter@oracle.com>]

On Thu, Jun 19, 2014 at 01:11:40PM -0700, josh@joshtriplett.org wrote:
> On Thu, Jun 19, 2014 at 09:20:15PM +0200, Johannes Stadlinger wrote:
> > This patch inserts a blank line after a declaration to avoid checkpatch
> > warning.
> > 
> > Signed-off-by: Johannes Stadlinger <Johannes.Stadlinger@fau.de>
> > Signed-off-by: Maximilian Eschenbacher <maximilian@eschenbacher.email>
> > CC: linux-kernel@i4.cs.fau.de
> > CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > CC: Josh Triplett <josh@joshtriplett.org>
> > CC: Himangi Saraogi <himangi774@gmail.com>
> > CC: Vitaly Osipov <vitaly.osipov@gmail.com>
> > CC: devel@driverdev.osuosl.org
> > CC: linux-kernel@vger.kernel.org
> 
> This is one case where I think checkpatch is just wrong; this doesn't
> make the code any more (or less) readable.
> 
> Meh-by: Josh Triplett <josh@joshtriplett.org>

We've asked about making checkpatch ignore small blocks but apparently
that is a hard thing.  It's less work to apply these than to argue about
them and adding a space doesn't hurt so meh is correct.

regards,
dan carpenter