From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew.Cooper3@citrix.com, Ian.Jackson@citrix.com,
xen-devel@lists.xen.org, Ian.Campbell@citrix.com,
George.Dunlap@citrix.com
Subject: Re: [PATCH v9 5/9] libxl/xl: push VCPU affinity pinning down to libxl
Date: Fri, 20 Jun 2014 14:01:40 +0200 [thread overview]
Message-ID: <1403265700.16957.24.camel@Solace> (raw)
In-Reply-To: <20140620085814.GT20819@zion.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1991 bytes --]
On ven, 2014-06-20 at 09:58 +0100, Wei Liu wrote:
> On Fri, Jun 20, 2014 at 10:17:17AM +0200, Dario Faggioli wrote:
> > On mer, 2014-06-18 at 16:28 +0200, Dario Faggioli wrote:
> > > From: Wei Liu <wei.liu2@citrix.com>
> > >
> > Oh and, Wei, one more thing about this patch.
> >
> > While preparing v10, I happen to have made quite a few changes to the
> > patch itself. It still accomplishes its goal, and its still based on
> > your one, of course, but it does look a bit different from it now.
> >
> > I'm attaching it to this email, let me know what you want me to do about
> > authorship. I'm totally fine with keeping the `From: Wei Liu' tag, but
> > I'll keep it only if you also are... I don't want you to be blamed for
> > my bugs! :-P
> >
>
> The "From:" tag doesn't matter that much IMO. What matters is the SoB.
> If this patch is still based on mine (as far as I can tell it still is),
> please keep my SoB, otherwise just drop it. I'm happy with whatever
> thing you do with the "From:" tag.
>
Well, it's what tells who the Author (e.g., as per `git log') of the
patch is, so I think it does matter. SoB has more to to with the
developer's certificate of origin:
http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signing_off_a_patch
Or at least this is how I see this.
Anyway, since you say it's fine for you, I'll stick with putting your
name in 'From:'
> > [sorry for the kind-of top-posting. I'm leaving the content of the
> > original e-mail here, so that one can easily compare the old (here in
> > the message body) and new (attached) look of the patch]
> >
>
> The patch looks good to me.
>
Thanks for looking at it. :-)
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-06-20 12:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 14:27 [PATCH v9 0/9] Implement vcpu soft affinity for credit1 (toolstack side) Dario Faggioli
2014-06-18 14:27 ` [PATCH v9 1/9] libxc/libxl: bump library SONAMEs Dario Faggioli
2014-06-18 14:27 ` [PATCH v9 2/9] libxc: get and set soft and hard affinity Dario Faggioli
2014-06-18 14:28 ` [PATCH v9 3/9] libxl: get and set soft affinity Dario Faggioli
2014-06-18 14:28 ` [PATCH v9 4/9] xl: enable getting and setting " Dario Faggioli
2014-06-18 15:37 ` Ian Campbell
2014-06-18 14:28 ` [PATCH v9 5/9] libxl/xl: push VCPU affinity pinning down to libxl Dario Faggioli
2014-06-18 15:44 ` Ian Campbell
2014-06-18 16:32 ` Dario Faggioli
2014-06-18 16:46 ` Ian Campbell
2014-06-18 17:00 ` Dario Faggioli
2014-06-20 8:17 ` Dario Faggioli
2014-06-20 8:58 ` Wei Liu
2014-06-20 12:01 ` Dario Faggioli [this message]
2014-06-18 14:28 ` [PATCH v9 6/9] libxl/xl: deprecate the build_info->cpumap field Dario Faggioli
2014-06-18 15:09 ` Wei Liu
2014-06-18 16:40 ` Dario Faggioli
2014-06-19 11:06 ` Wei Liu
2014-06-19 14:00 ` Dario Faggioli
2014-06-19 14:18 ` Wei Liu
2014-06-18 15:53 ` Ian Campbell
2014-06-18 16:26 ` Dario Faggioli
2014-06-18 16:44 ` Ian Campbell
2014-06-18 17:11 ` Dario Faggioli
2014-06-19 9:07 ` Dario Faggioli
2014-06-18 14:28 ` [PATCH v9 7/9] xl: move the vcpu affinity parsing in a function Dario Faggioli
2014-06-18 15:55 ` Ian Campbell
2014-06-18 14:28 ` [PATCH v9 8/9] libxl/xl: enable for specifying soft-affinity in the config file Dario Faggioli
2014-06-18 16:00 ` Ian Campbell
2014-06-18 17:02 ` Dario Faggioli
2014-06-18 14:28 ` [PATCH v9 9/9] libxl: automatic NUMA placement affects soft affinity Dario Faggioli
2014-06-19 17:33 ` Dario Faggioli
2014-06-19 17:42 ` Wei Liu
2014-06-20 7:18 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403265700.16957.24.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.