Re: [PATCH v9 8/9] libxl/xl: enable for specifying soft-affinity in the config file

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1475 bytes --]

On mer, 2014-06-18 at 17:00 +0100, Ian Campbell wrote:
> On Wed, 2014-06-18 at 16:28 +0200, Dario Faggioli wrote:
> 
> $subject starts "enable for specifying". I think a word must be missing.
> 
I think I just meant something like "make it possible to specify...".
I'll word it like that.

> > in a similar way to how hard-affinity is specified (i.e.,
> > exactly how plain vcpu-affinity was being specified before
> > this change).
> > 
> > To do so, we add a vcpu_soft_affinity array to build_info,
> > and treat it much like vcpu_hard_affinity. The new config
> > option is called "cpus_soft".
> 
> Not any more.
> 
Ehm... is it not?

> >  /*
> > + * LIBXL_HAVE_BUILDINFO_VCPU_SOFT_AFFINITY_ARRAY
> 
> You could probably combine this #define with the HARD ones, after all
> they arrived at the same time.
> 
> i.e. in the hard affinity patch:
> /* to be uncommented when soft array added */
> /* #define LIBXL_HAVE_BUILDINFO_VCPU_AFFINITY_ARRAYS */
> and then uncomment it here.
> 
Ok, I'll do like this.

> At the very least they could share a doc comment.
> 
Right, although I think I'd be at least amending the comment in the this
patch.

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel