From: Michael Ellerman <mpe@ellerman.id.au>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: netdev@vger.kernel.org, Denis Kirjanov <kda@linux-powerpc.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test
Date: Fri, 27 Jun 2014 15:08:17 +1000 [thread overview]
Message-ID: <1403845697.21873.1.camel@concordia> (raw)
In-Reply-To: <53ABDB72.9020902@redhat.com>
On Thu, 2014-06-26 at 10:36 +0200, Daniel Borkmann wrote:
> On 06/26/2014 10:30 AM, Michael Ellerman wrote:
> > On Wed, 2014-06-25 at 21:34 +0400, Denis Kirjanov wrote:
> >> We have to return the boolean here if the tag presents
> >> or not, not just ANDing the TCI with the mask which results to:
> >>
> >> [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT
> >> [ 709.412245] ret 4096 != 1
> >> [ 709.412332] ret 4096 != 1
> >> [ 709.412333] FAIL (2 times)
> >
> > Hi Denis,
> >
> > Is this the same version of test_bpf that is in Linus' tree?
> >
> > I don't see any fails with that version, am I missing something?
> >
> > [ 187.690640] test_bpf: #18 LD_VLAN_TAG_PRESENT 46 50 PASS
>
> Did you try to modprobe test_bpf after enabling JIT, i.e. :
>
> echo 1 > /proc/sys/net/core/bpf_jit_enable
>
> Last time I tested with ppc64, I saw the interpreter passing
> while JIT failed, which the fix above should address.
Right, I thought CONFIG_BPF_JIT=y was sufficient.
But that just makes it available, I need to *also* enable it at runtime.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: Denis Kirjanov <kda@linux-powerpc.org>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test
Date: Fri, 27 Jun 2014 15:08:17 +1000 [thread overview]
Message-ID: <1403845697.21873.1.camel@concordia> (raw)
In-Reply-To: <53ABDB72.9020902@redhat.com>
On Thu, 2014-06-26 at 10:36 +0200, Daniel Borkmann wrote:
> On 06/26/2014 10:30 AM, Michael Ellerman wrote:
> > On Wed, 2014-06-25 at 21:34 +0400, Denis Kirjanov wrote:
> >> We have to return the boolean here if the tag presents
> >> or not, not just ANDing the TCI with the mask which results to:
> >>
> >> [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT
> >> [ 709.412245] ret 4096 != 1
> >> [ 709.412332] ret 4096 != 1
> >> [ 709.412333] FAIL (2 times)
> >
> > Hi Denis,
> >
> > Is this the same version of test_bpf that is in Linus' tree?
> >
> > I don't see any fails with that version, am I missing something?
> >
> > [ 187.690640] test_bpf: #18 LD_VLAN_TAG_PRESENT 46 50 PASS
>
> Did you try to modprobe test_bpf after enabling JIT, i.e. :
>
> echo 1 > /proc/sys/net/core/bpf_jit_enable
>
> Last time I tested with ppc64, I saw the interpreter passing
> while JIT failed, which the fix above should address.
Right, I thought CONFIG_BPF_JIT=y was sufficient.
But that just makes it available, I need to *also* enable it at runtime.
cheers
next prev parent reply other threads:[~2014-06-27 5:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 17:34 [PATCH v2 1/2] powerpc: bpf: Use correct mask while accessing the VLAN tag Denis Kirjanov
2014-06-25 17:34 ` Denis Kirjanov
2014-06-25 17:34 ` [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test Denis Kirjanov
2014-06-25 17:34 ` Denis Kirjanov
2014-06-26 8:30 ` Michael Ellerman
2014-06-26 8:36 ` Daniel Borkmann
2014-06-26 8:36 ` Daniel Borkmann
2014-06-27 5:08 ` Michael Ellerman [this message]
2014-06-27 5:08 ` Michael Ellerman
2014-06-27 9:46 ` Daniel Borkmann
2014-06-27 9:46 ` Daniel Borkmann
2014-06-26 15:43 ` Denis Kirjanov
2014-06-27 23:14 ` David Miller
2014-06-27 23:14 ` [PATCH v2 1/2] powerpc: bpf: Use correct mask while accessing the VLAN tag David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403845697.21873.1.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=dborkman@redhat.com \
--cc=kda@linux-powerpc.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.