* [PATCH 1/2] Deletes arch/arm/mach-gemini/idle.c
@ 2014-07-01 3:11 ` Nicholas Krause
0 siblings, 0 replies; 4+ messages in thread
From: Nicholas Krause @ 2014-07-01 3:11 UTC (permalink / raw)
To: linux-arm-kernel
This patch deletes the above file in order to remove the function
in this file that may cause races. In addition this function is
no longer needed due to commit 8182a34d85698 fixing this issue.
Therefore gemmi_idle is no longer needed and due to in being the
only function in this file I am removing it.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
arch/arm/mach-gemini/idle.c | 30 ------------------------------
1 file changed, 30 deletions(-)
delete mode 100644 arch/arm/mach-gemini/idle.c
diff --git a/arch/arm/mach-gemini/idle.c b/arch/arm/mach-gemini/idle.c
deleted file mode 100644
index 2880f5a..0000000
--- a/arch/arm/mach-gemini/idle.c
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * arch/arm/mach-gemini/idle.c
- */
-
-#include <linux/init.h>
-#include <asm/system_misc.h>
-#include <asm/proc-fns.h>
-
-static void gemini_idle(void)
-{
- /*
- * Because of broken hardware we have to enable interrupts or the CPU
- * will never wakeup... Acctualy it is not very good to enable
- * interrupts first since scheduler can miss a tick, but there is
- * no other way around this. Platforms that needs it for power saving
- * should enable it in init code, since by default it is
- * disabled.
- */
-
- local_irq_disable();
- cpu_do_idle();
-}
-
-static int __init gemini_idle_init(void)
-{
- arm_pm_idle = gemini_idle;
- return 0;
-}
-
-arch_initcall(gemini_idle_init);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] Deletes arch/arm/mach-gemini/idle.c
@ 2014-07-01 3:11 ` Nicholas Krause
0 siblings, 0 replies; 4+ messages in thread
From: Nicholas Krause @ 2014-07-01 3:11 UTC (permalink / raw)
To: ulli.kroll; +Cc: linux, linux-arm-kernel, linux-kernel
This patch deletes the above file in order to remove the function
in this file that may cause races. In addition this function is
no longer needed due to commit 8182a34d85698 fixing this issue.
Therefore gemmi_idle is no longer needed and due to in being the
only function in this file I am removing it.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
arch/arm/mach-gemini/idle.c | 30 ------------------------------
1 file changed, 30 deletions(-)
delete mode 100644 arch/arm/mach-gemini/idle.c
diff --git a/arch/arm/mach-gemini/idle.c b/arch/arm/mach-gemini/idle.c
deleted file mode 100644
index 2880f5a..0000000
--- a/arch/arm/mach-gemini/idle.c
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * arch/arm/mach-gemini/idle.c
- */
-
-#include <linux/init.h>
-#include <asm/system_misc.h>
-#include <asm/proc-fns.h>
-
-static void gemini_idle(void)
-{
- /*
- * Because of broken hardware we have to enable interrupts or the CPU
- * will never wakeup... Acctualy it is not very good to enable
- * interrupts first since scheduler can miss a tick, but there is
- * no other way around this. Platforms that needs it for power saving
- * should enable it in init code, since by default it is
- * disabled.
- */
-
- local_irq_disable();
- cpu_do_idle();
-}
-
-static int __init gemini_idle_init(void)
-{
- arm_pm_idle = gemini_idle;
- return 0;
-}
-
-arch_initcall(gemini_idle_init);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 1/2] Deletes arch/arm/mach-gemini/idle.c
2014-07-01 3:11 ` Nicholas Krause
@ 2014-07-01 3:11 ` Nick Krause
-1 siblings, 0 replies; 4+ messages in thread
From: Nick Krause @ 2014-07-01 3:11 UTC (permalink / raw)
To: linux-arm-kernel
This is only one patch please disregard patch 1/2.
Cheers Nick
On Mon, Jun 30, 2014 at 11:11 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This patch deletes the above file in order to remove the function
> in this file that may cause races. In addition this function is
> no longer needed due to commit 8182a34d85698 fixing this issue.
> Therefore gemmi_idle is no longer needed and due to in being the
> only function in this file I am removing it.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/arm/mach-gemini/idle.c | 30 ------------------------------
> 1 file changed, 30 deletions(-)
> delete mode 100644 arch/arm/mach-gemini/idle.c
>
> diff --git a/arch/arm/mach-gemini/idle.c b/arch/arm/mach-gemini/idle.c
> deleted file mode 100644
> index 2880f5a..0000000
> --- a/arch/arm/mach-gemini/idle.c
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -/*
> - * arch/arm/mach-gemini/idle.c
> - */
> -
> -#include <linux/init.h>
> -#include <asm/system_misc.h>
> -#include <asm/proc-fns.h>
> -
> -static void gemini_idle(void)
> -{
> - /*
> - * Because of broken hardware we have to enable interrupts or the CPU
> - * will never wakeup... Acctualy it is not very good to enable
> - * interrupts first since scheduler can miss a tick, but there is
> - * no other way around this. Platforms that needs it for power saving
> - * should enable it in init code, since by default it is
> - * disabled.
> - */
> -
> - local_irq_disable();
> - cpu_do_idle();
> -}
> -
> -static int __init gemini_idle_init(void)
> -{
> - arm_pm_idle = gemini_idle;
> - return 0;
> -}
> -
> -arch_initcall(gemini_idle_init);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Deletes arch/arm/mach-gemini/idle.c
@ 2014-07-01 3:11 ` Nick Krause
0 siblings, 0 replies; 4+ messages in thread
From: Nick Krause @ 2014-07-01 3:11 UTC (permalink / raw)
To: ulli.kroll
Cc: Russell King - ARM Linux, linux-arm-kernel,
linux-kernel@vger.kernel.org
This is only one patch please disregard patch 1/2.
Cheers Nick
On Mon, Jun 30, 2014 at 11:11 PM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This patch deletes the above file in order to remove the function
> in this file that may cause races. In addition this function is
> no longer needed due to commit 8182a34d85698 fixing this issue.
> Therefore gemmi_idle is no longer needed and due to in being the
> only function in this file I am removing it.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/arm/mach-gemini/idle.c | 30 ------------------------------
> 1 file changed, 30 deletions(-)
> delete mode 100644 arch/arm/mach-gemini/idle.c
>
> diff --git a/arch/arm/mach-gemini/idle.c b/arch/arm/mach-gemini/idle.c
> deleted file mode 100644
> index 2880f5a..0000000
> --- a/arch/arm/mach-gemini/idle.c
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -/*
> - * arch/arm/mach-gemini/idle.c
> - */
> -
> -#include <linux/init.h>
> -#include <asm/system_misc.h>
> -#include <asm/proc-fns.h>
> -
> -static void gemini_idle(void)
> -{
> - /*
> - * Because of broken hardware we have to enable interrupts or the CPU
> - * will never wakeup... Acctualy it is not very good to enable
> - * interrupts first since scheduler can miss a tick, but there is
> - * no other way around this. Platforms that needs it for power saving
> - * should enable it in init code, since by default it is
> - * disabled.
> - */
> -
> - local_irq_disable();
> - cpu_do_idle();
> -}
> -
> -static int __init gemini_idle_init(void)
> -{
> - arm_pm_idle = gemini_idle;
> - return 0;
> -}
> -
> -arch_initcall(gemini_idle_init);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-01 3:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-01 3:11 [PATCH 1/2] Deletes arch/arm/mach-gemini/idle.c Nicholas Krause
2014-07-01 3:11 ` Nicholas Krause
2014-07-01 3:11 ` Nick Krause
2014-07-01 3:11 ` Nick Krause
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.