[PATCH] microblaze: fixes includes in sigcontext.h

[PATCH] microblaze: fixes includes in sigcontext.h

[Nicholas Krause]

This patch changes this file to use linux/ptrace.h instead of
included file to fix this FIXME message in this file.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 arch/microblaze/include/uapi/asm/sigcontext.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h
index 55873c8..1180d9b 100644
--- a/arch/microblaze/include/uapi/asm/sigcontext.h
+++ b/arch/microblaze/include/uapi/asm/sigcontext.h
@@ -9,8 +9,7 @@
 #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H
 #define _ASM_MICROBLAZE_SIGCONTEXT_H
 
-/* FIXME should be linux/ptrace.h */
-#include <asm/ptrace.h>
+#include <linux/ptrace.h>
 
 struct sigcontext {
 	struct pt_regs regs;
-- 
1.9.1

Re: [PATCH] microblaze: fixes includes in sigcontext.h

[David Rientjes]

On Thu, 3 Jul 2014, Nicholas Krause wrote:

> diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h
> index 55873c8..1180d9b 100644
> --- a/arch/microblaze/include/uapi/asm/sigcontext.h
> +++ b/arch/microblaze/include/uapi/asm/sigcontext.h
> @@ -9,8 +9,7 @@
>  #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H
>  #define _ASM_MICROBLAZE_SIGCONTEXT_H
>  
> -/* FIXME should be linux/ptrace.h */
> -#include <asm/ptrace.h>
> +#include <linux/ptrace.h>
>  
>  struct sigcontext {
>  	struct pt_regs regs;

Umm, does this even compile?  How does sigcontext.h get the definition of 
struct pt_regs?  Seems like it would be better to just do a forward 
declaration.

Re: [PATCH] microblaze: fixes includes in sigcontext.h

[Nick Krause]

You may be right I don't have a compiler that supports microblaze therefore I
would suggest removing this FIXME message.
Cheers Nick

On Thu, Jul 3, 2014 at 5:57 PM, David Rientjes <rientjes@google.com> wrote:
> On Thu, 3 Jul 2014, Nicholas Krause wrote:
>
>> diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h
>> index 55873c8..1180d9b 100644
>> --- a/arch/microblaze/include/uapi/asm/sigcontext.h
>> +++ b/arch/microblaze/include/uapi/asm/sigcontext.h
>> @@ -9,8 +9,7 @@
>>  #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H
>>  #define _ASM_MICROBLAZE_SIGCONTEXT_H
>>
>> -/* FIXME should be linux/ptrace.h */
>> -#include <asm/ptrace.h>
>> +#include <linux/ptrace.h>
>>
>>  struct sigcontext {
>>       struct pt_regs regs;
>
> Umm, does this even compile?  How does sigcontext.h get the definition of
> struct pt_regs?  Seems like it would be better to just do a forward
> declaration.

Re: [PATCH] microblaze: fixes includes in sigcontext.h

[David Rientjes]

On Thu, 3 Jul 2014, Nick Krause wrote:

> You may be right I don't have a compiler that supports microblaze therefore I
> would suggest removing this FIXME message.

The FIXME here is obviously stating that the code needs to be fixed so 
that it can include linux/ptrace.h rather than asm/ptrace.h since we want 
to include the former rather than the latter.  It doesn't imply, in any 
way, that you can just do the conversion without some due diligence 
(compilation) to ensure it works; otherwise it would have been including 
linux/ptrace.h since the beginning.

It's bad practice to mess with per-arch header files for platforms that 
you cannot compile yourself.

> Cheers Nick
> 
> On Thu, Jul 3, 2014 at 5:57 PM, David Rientjes <rientjes@google.com> wrote:
> > On Thu, 3 Jul 2014, Nicholas Krause wrote:
> >
> >> diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h
> >> index 55873c8..1180d9b 100644
> >> --- a/arch/microblaze/include/uapi/asm/sigcontext.h
> >> +++ b/arch/microblaze/include/uapi/asm/sigcontext.h
> >> @@ -9,8 +9,7 @@
> >>  #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H
> >>  #define _ASM_MICROBLAZE_SIGCONTEXT_H
> >>
> >> -/* FIXME should be linux/ptrace.h */
> >> -#include <asm/ptrace.h>
> >> +#include <linux/ptrace.h>
> >>
> >>  struct sigcontext {
> >>       struct pt_regs regs;
> >
> > Umm, does this even compile?  How does sigcontext.h get the definition of
> > struct pt_regs?  Seems like it would be better to just do a forward
> > declaration.
> 

Re: [PATCH] microblaze: fixes includes in sigcontext.h

[Nick Krause]

Very well ,
I guess this bug is outside my scope.
Cheers Nick

On Thu, Jul 3, 2014 at 6:14 PM, David Rientjes <rientjes@google.com> wrote:
> On Thu, 3 Jul 2014, Nick Krause wrote:
>
>> You may be right I don't have a compiler that supports microblaze therefore I
>> would suggest removing this FIXME message.
>
> The FIXME here is obviously stating that the code needs to be fixed so
> that it can include linux/ptrace.h rather than asm/ptrace.h since we want
> to include the former rather than the latter.  It doesn't imply, in any
> way, that you can just do the conversion without some due diligence
> (compilation) to ensure it works; otherwise it would have been including
> linux/ptrace.h since the beginning.
>
> It's bad practice to mess with per-arch header files for platforms that
> you cannot compile yourself.
>
>> Cheers Nick
>>
>> On Thu, Jul 3, 2014 at 5:57 PM, David Rientjes <rientjes@google.com> wrote:
>> > On Thu, 3 Jul 2014, Nicholas Krause wrote:
>> >
>> >> diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h
>> >> index 55873c8..1180d9b 100644
>> >> --- a/arch/microblaze/include/uapi/asm/sigcontext.h
>> >> +++ b/arch/microblaze/include/uapi/asm/sigcontext.h
>> >> @@ -9,8 +9,7 @@
>> >>  #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H
>> >>  #define _ASM_MICROBLAZE_SIGCONTEXT_H
>> >>
>> >> -/* FIXME should be linux/ptrace.h */
>> >> -#include <asm/ptrace.h>
>> >> +#include <linux/ptrace.h>
>> >>
>> >>  struct sigcontext {
>> >>       struct pt_regs regs;
>> >
>> > Umm, does this even compile?  How does sigcontext.h get the definition of
>> > struct pt_regs?  Seems like it would be better to just do a forward
>> > declaration.
>>