From: Kishon Vijay Abraham I <kishon@ti.com>
To: kishon@ti.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, lee.jones@linaro.org,
sergei.shtylyov@cogentembedded.com,
antoine.tenart@free-electrons.com
Cc: kgene.kim@samsung.com, maxime.ripard@free-electrons.com
Subject: [RFC PATCH 1/2] phy: core: Fix of_phy_provider_lookup to return PHY provider for sub node
Date: Fri, 4 Jul 2014 20:37:53 +0530 [thread overview]
Message-ID: <1404486474-28312-2-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1404486474-28312-1-git-send-email-kishon@ti.com>
Fixed of_phy_provider_lookup to return 'phy_provider' if _of_phy_get
passes the node pointer of the sub-node of phy provider node. This is
needed when phy provider implements multiple PHYs and each PHY is
modelled as the sub-node of PHY provider device node.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-core.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index c64a2f3..a4a1f783 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -86,10 +86,18 @@ static struct phy *phy_lookup(struct device *device, const char *port)
static struct phy_provider *of_phy_provider_lookup(struct device_node *node)
{
struct phy_provider *phy_provider;
+ struct device_node *child;
list_for_each_entry(phy_provider, &phy_provider_list, list) {
- if (phy_provider->dev->of_node == node)
+ if (phy_provider->dev->of_node != node) {
+ for_each_child_of_node(phy_provider->dev->of_node,
+ child) {
+ if (child == node)
+ return phy_provider;
+ }
+ } else {
return phy_provider;
+ }
}
return ERR_PTR(-EPROBE_DEFER);
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/2] phy: core: Fix of_phy_provider_lookup to return PHY provider for sub node
Date: Fri, 4 Jul 2014 20:37:53 +0530 [thread overview]
Message-ID: <1404486474-28312-2-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1404486474-28312-1-git-send-email-kishon@ti.com>
Fixed of_phy_provider_lookup to return 'phy_provider' if _of_phy_get
passes the node pointer of the sub-node of phy provider node. This is
needed when phy provider implements multiple PHYs and each PHY is
modelled as the sub-node of PHY provider device node.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-core.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index c64a2f3..a4a1f783 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -86,10 +86,18 @@ static struct phy *phy_lookup(struct device *device, const char *port)
static struct phy_provider *of_phy_provider_lookup(struct device_node *node)
{
struct phy_provider *phy_provider;
+ struct device_node *child;
list_for_each_entry(phy_provider, &phy_provider_list, list) {
- if (phy_provider->dev->of_node == node)
+ if (phy_provider->dev->of_node != node) {
+ for_each_child_of_node(phy_provider->dev->of_node,
+ child) {
+ if (child == node)
+ return phy_provider;
+ }
+ } else {
return phy_provider;
+ }
}
return ERR_PTR(-EPROBE_DEFER);
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <kishon@ti.com>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>, <lee.jones@linaro.org>,
<sergei.shtylyov@cogentembedded.com>,
<antoine.tenart@free-electrons.com>
Cc: <kgene.kim@samsung.com>, <maxime.ripard@free-electrons.com>
Subject: [RFC PATCH 1/2] phy: core: Fix of_phy_provider_lookup to return PHY provider for sub node
Date: Fri, 4 Jul 2014 20:37:53 +0530 [thread overview]
Message-ID: <1404486474-28312-2-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1404486474-28312-1-git-send-email-kishon@ti.com>
Fixed of_phy_provider_lookup to return 'phy_provider' if _of_phy_get
passes the node pointer of the sub-node of phy provider node. This is
needed when phy provider implements multiple PHYs and each PHY is
modelled as the sub-node of PHY provider device node.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-core.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index c64a2f3..a4a1f783 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -86,10 +86,18 @@ static struct phy *phy_lookup(struct device *device, const char *port)
static struct phy_provider *of_phy_provider_lookup(struct device_node *node)
{
struct phy_provider *phy_provider;
+ struct device_node *child;
list_for_each_entry(phy_provider, &phy_provider_list, list) {
- if (phy_provider->dev->of_node == node)
+ if (phy_provider->dev->of_node != node) {
+ for_each_child_of_node(phy_provider->dev->of_node,
+ child) {
+ if (child == node)
+ return phy_provider;
+ }
+ } else {
return phy_provider;
+ }
}
return ERR_PTR(-EPROBE_DEFER);
--
1.7.9.5
next prev parent reply other threads:[~2014-07-04 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 15:07 [RFC PATCH 0/2] phy: core: better support for multi-phy in phy-core Kishon Vijay Abraham I
2014-07-04 15:07 ` Kishon Vijay Abraham I
2014-07-04 15:07 ` Kishon Vijay Abraham I
2014-07-04 15:07 ` Kishon Vijay Abraham I [this message]
2014-07-04 15:07 ` [RFC PATCH 1/2] phy: core: Fix of_phy_provider_lookup to return PHY provider for sub node Kishon Vijay Abraham I
2014-07-04 15:07 ` Kishon Vijay Abraham I
2014-07-07 13:43 ` Lee Jones
2014-07-07 13:43 ` Lee Jones
2014-07-04 15:07 ` [RFC PATCH 2/2] phy: core: the node pointer of PHY need not be the same as that of PHY provider Kishon Vijay Abraham I
2014-07-04 15:07 ` Kishon Vijay Abraham I
2014-07-04 15:07 ` Kishon Vijay Abraham I
2014-07-07 13:12 ` Lee Jones
2014-07-07 13:12 ` Lee Jones
2014-07-07 14:09 ` Kishon Vijay Abraham I
2014-07-07 14:09 ` Kishon Vijay Abraham I
2014-07-07 14:09 ` Kishon Vijay Abraham I
2014-07-07 14:59 ` Lee Jones
2014-07-07 14:59 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404486474-28312-2-git-send-email-kishon@ti.com \
--to=kishon@ti.com \
--cc=antoine.tenart@free-electrons.com \
--cc=kgene.kim@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.