All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "bhelgaas@google.com" <bhelgaas@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"swarren@nvidia.com" <swarren@nvidia.com>,
	"vidyas@nvidia.com" <vidyas@nvidia.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"kthota@nvidia.com" <kthota@nvidia.com>,
	"nagananda.chumbalkar@hp.com" <nagananda.chumbalkar@hp.com>
Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode
Date: Mon, 7 Jul 2014 16:02:29 +0000	[thread overview]
Message-ID: <1404748948.9762.29.camel@x230> (raw)
In-Reply-To: <20140705190203.GE28871@google.com>

T24gU2F0LCAyMDE0LTA3LTA1IGF0IDEzOjAyIC0wNjAwLCBCam9ybiBIZWxnYWFzIHdyb3RlOg0K
PiA+IFJhZmFlbCwgTWF0dGhldywgYW55IGNvbW1lbnRzPyAgV2UgaGF2ZSB2YWNpbGxhdGVkIG9u
IHRoaXMgYmVmb3JlIGFuZA0KPiA+IHRoZSB3ZWIgaXMgYWxyZWFkeSBwcmV0dHkgdGFuZ2xlZC4N
Cj4gPiANCj4gPiBWaWR5YSwgY2FuIHlvdSBnaXZlIG1vcmUgZGV0YWlscyBhYm91dCB0aGUgYnVn
IGZpeGVkIGJ5IHRoaXMgY2hhbmdlPw0KPiA+IFdoYXQncyB0aGUgc2NlbmFyaW8/ICBBcmUgd2Ug
cmVzdW1pbmcgYW5kIHRoZSBkZXZpY2UgaXMgcG93ZXJlZCB1cCBidXQNCj4gPiBBU1BNIGlzbid0
IGVuYWJsZWQ/ICBNYXliZSB5b3UgY291bGQgY29sbGVjdCBtb3JlIGRldGFpbHMgaW4gYQ0KPiA+
IGh0dHA6Ly9idWd6aWxsYS5rZXJuZWwub3JnIHJlcG9ydD8NCg0KSSBiZWxpZXZlIHRoYXQncyB0
aGUgY2FzZS4gVGhlIHByb3Bvc2VkIGNoYW5nZSB3b3VsZCBmaXggaXQgYnV0IGlzbid0DQpyZWFs
bHkgdGVycmlibHkgY2xlYW4gLSBJIHRoaW5rIGl0IHdvdWxkIGJlIG1vcmUgcmVhZGFibGUgdG8g
c3BsaXQgdGhpcw0KaW50byBtdWx0aXBsZSBmdW5jdGlvbnMuDQoNCi0tIA0KTWF0dGhldyBHYXJy
ZXR0IDxtYXR0aGV3LmdhcnJldHRAbmVidWxhLmNvbT4NCg==

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "bhelgaas@google.com" <bhelgaas@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"swarren@nvidia.com" <swarren@nvidia.com>,
	"vidyas@nvidia.com" <vidyas@nvidia.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"kthota@nvidia.com" <kthota@nvidia.com>,
	"nagananda.chumbalkar@hp.com" <nagananda.chumbalkar@hp.com>
Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode
Date: Mon, 7 Jul 2014 16:02:29 +0000	[thread overview]
Message-ID: <1404748948.9762.29.camel@x230> (raw)
In-Reply-To: <20140705190203.GE28871@google.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 806 bytes --]

On Sat, 2014-07-05 at 13:02 -0600, Bjorn Helgaas wrote:
> > Rafael, Matthew, any comments?  We have vacillated on this before and
> > the web is already pretty tangled.
> > 
> > Vidya, can you give more details about the bug fixed by this change?
> > What's the scenario?  Are we resuming and the device is powered up but
> > ASPM isn't enabled?  Maybe you could collect more details in a
> > http://bugzilla.kernel.org report?

I believe that's the case. The proposed change would fix it but isn't
really terribly clean - I think it would be more readable to split this
into multiple functions.

-- 
Matthew Garrett <matthew.garrett@nebula.com>
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  reply	other threads:[~2014-07-07 16:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  7:16 [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode Vidya Sagar
2014-07-01 15:04 ` Stephen Warren
2014-07-02  4:23   ` Vidya Sagar
2014-07-05 18:57 ` Bjorn Helgaas
2014-07-05 19:02   ` Bjorn Helgaas
2014-07-07 16:02     ` Matthew Garrett [this message]
2014-07-07 16:02       ` Matthew Garrett
2014-07-07 18:00     ` Vidya Sagar
2014-07-07 21:12       ` Bjorn Helgaas
2014-07-08  5:07         ` Vidya Sagar
2014-07-09 18:20         ` vidya sagar
2014-07-11 22:44           ` Bjorn Helgaas
2014-07-14  4:35             ` vidya sagar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404748948.9762.29.camel@x230 \
    --to=matthew.garrett@nebula.com \
    --cc=bhelgaas@google.com \
    --cc=kthota@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=nagananda.chumbalkar@hp.com \
    --cc=rjw@rjwysocki.net \
    --cc=swarren@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.