From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Bjorn Andersson <bjorn@kryo.se>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status
Date: Wed, 09 Jul 2014 10:24:29 +0300 [thread overview]
Message-ID: <1404890669.16296.5.camel@iivanov-dev> (raw)
In-Reply-To: <CAJAp7Ogy3=tZvMAUojbf5sy8EMmQOT+imA3=TRVcGXXA_y7CtA@mail.gmail.com>
On Tue, 2014-07-08 at 16:43 -0700, Bjorn Andersson wrote:
> On Tue, Jul 8, 2014 at 4:20 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 07/07/14 18:26, Bjorn Andersson wrote:
<snip>
> [...]
> > Sad, the header file came back. I guess there isn't a way to put the
> > pinctrl driver inside the core mfd driver? Then we wouldn't need to
> > expose an "irq read line" function.
> >
>
> I continued my search and this needs to be accessed by gpio, mpp, adc,
> charger, bms and usb(?). So we have to expose it in some form.
>
> > Actually Abhijeet proposed such an API in 2011 but it didn't go
> > anywhere[1]. If we had that API we should be able to call
> > read_irq_line() from the pinctrl driver whenever we want to get the
> > state of the gpio, plus the API is generic. We're going to need that API
> > anyway for things like USB insertion detection so it might make sense to
> > add it sooner rather than later.
> >
> > [1]
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2011-April/048319.html
>
> From what I can see of this thread it was exposed as a way for drivers
> to be able to query if an interrupt handler was called on raising or
> falling edge. And based on the locking limitations of the
> implementation we couldn't have used it anyways.
>
> Our use case is different in that we're at any point in time
> interested in reading out the status of the irq line, as the only way
> of getting that status.
How about using extcon framework?
Regards,
Ivan
WARNING: multiple messages have this Message-ID (diff)
From: iivanov@mm-sol.com (Ivan T. Ivanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status
Date: Wed, 09 Jul 2014 10:24:29 +0300 [thread overview]
Message-ID: <1404890669.16296.5.camel@iivanov-dev> (raw)
In-Reply-To: <CAJAp7Ogy3=tZvMAUojbf5sy8EMmQOT+imA3=TRVcGXXA_y7CtA@mail.gmail.com>
On Tue, 2014-07-08 at 16:43 -0700, Bjorn Andersson wrote:
> On Tue, Jul 8, 2014 at 4:20 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> > On 07/07/14 18:26, Bjorn Andersson wrote:
<snip>
> [...]
> > Sad, the header file came back. I guess there isn't a way to put the
> > pinctrl driver inside the core mfd driver? Then we wouldn't need to
> > expose an "irq read line" function.
> >
>
> I continued my search and this needs to be accessed by gpio, mpp, adc,
> charger, bms and usb(?). So we have to expose it in some form.
>
> > Actually Abhijeet proposed such an API in 2011 but it didn't go
> > anywhere[1]. If we had that API we should be able to call
> > read_irq_line() from the pinctrl driver whenever we want to get the
> > state of the gpio, plus the API is generic. We're going to need that API
> > anyway for things like USB insertion detection so it might make sense to
> > add it sooner rather than later.
> >
> > [1]
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2011-April/048319.html
>
> From what I can see of this thread it was exposed as a way for drivers
> to be able to query if an interrupt handler was called on raising or
> falling edge. And based on the locking limitations of the
> implementation we couldn't have used it anyways.
>
> Our use case is different in that we're at any point in time
> interested in reading out the status of the irq line, as the only way
> of getting that status.
How about using extcon framework?
Regards,
Ivan
next prev parent reply other threads:[~2014-07-09 7:24 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 1:26 [PATCH 0/3] Qualcomm pm8xxx gpio driver Bjorn Andersson
2014-07-08 1:26 ` Bjorn Andersson
2014-07-08 1:26 ` Bjorn Andersson
[not found] ` <1404782785-1824-1-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-07-08 1:26 ` [PATCH 1/3] mfd: pm8921: Expose pm8xxx_read_irq_status Bjorn Andersson
2014-07-08 1:26 ` Bjorn Andersson
2014-07-08 1:26 ` Bjorn Andersson
2014-07-08 23:20 ` Stephen Boyd
2014-07-08 23:20 ` Stephen Boyd
2014-07-08 23:43 ` Bjorn Andersson
2014-07-08 23:43 ` Bjorn Andersson
2014-07-09 7:24 ` Ivan T. Ivanov [this message]
2014-07-09 7:24 ` Ivan T. Ivanov
2014-07-09 7:59 ` Linus Walleij
2014-07-09 7:59 ` Linus Walleij
2014-07-09 14:13 ` Bjorn Andersson
2014-07-09 14:13 ` Bjorn Andersson
2014-07-08 1:26 ` [PATCH 2/3] pinctrl: Device tree bindings for Qualcomm pm8xxx gpio block Bjorn Andersson
2014-07-08 1:26 ` Bjorn Andersson
2014-07-08 1:26 ` Bjorn Andersson
2014-07-09 8:53 ` Linus Walleij
2014-07-09 8:53 ` Linus Walleij
2014-07-09 21:18 ` Bjorn Andersson
2014-07-09 21:18 ` Bjorn Andersson
2014-07-10 9:53 ` Linus Walleij
2014-07-10 9:53 ` Linus Walleij
2014-07-12 1:56 ` Stephen Boyd
2014-07-12 1:56 ` Stephen Boyd
2014-07-14 13:58 ` Ivan T. Ivanov
2014-07-14 13:58 ` Ivan T. Ivanov
2014-07-14 21:20 ` Stephen Boyd
2014-07-14 21:20 ` Stephen Boyd
2014-07-15 6:35 ` Ivan T. Ivanov
2014-07-15 6:35 ` Ivan T. Ivanov
2014-07-16 0:23 ` Bjorn Andersson
2014-07-16 0:23 ` Bjorn Andersson
2014-07-16 8:18 ` Ivan T. Ivanov
2014-07-16 8:18 ` Ivan T. Ivanov
2014-07-14 13:24 ` Ivan T. Ivanov
2014-07-14 13:24 ` Ivan T. Ivanov
2014-07-08 1:26 ` [PATCH 3/3] pinctrl: Introduce pinctrl driver for Qualcomm pm8xxx Bjorn Andersson
2014-07-08 1:26 ` Bjorn Andersson
2014-07-08 1:26 ` Bjorn Andersson
[not found] ` <1404782785-1824-4-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-07-09 9:32 ` Linus Walleij
2014-07-09 9:32 ` Linus Walleij
2014-07-09 9:32 ` Linus Walleij
2014-07-14 22:48 ` Bjorn Andersson
2014-07-14 22:48 ` Bjorn Andersson
2014-07-23 8:45 ` Linus Walleij
2014-07-23 8:45 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404890669.16296.5.camel@iivanov-dev \
--to=iivanov@mm-sol.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=bjorn@kryo.se \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.