From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-omap@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] tty: serial: 8250-core: reorder serial8250_stop_rx() & serial8250_start_tx()
Date: Wed, 9 Jul 2014 19:49:35 +0200 [thread overview]
Message-ID: <1404928177-26554-5-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1404928177-26554-1-git-send-email-bigeasy@linutronix.de>
With the upcomming rs485 support it is required that
serial8250_stop_rx() is called from serial8250_start_tx(). With this
reordering there is no need for a forward declaration of the former
function.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/tty/serial/8250/8250_core.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 1a91a89..c7c3bf7 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -1306,6 +1306,21 @@ static void serial8250_stop_tx(struct uart_port *port)
pm_runtime_put_autosuspend(port->dev);
}
+static void serial8250_stop_rx(struct uart_port *port)
+{
+ struct uart_8250_port *up =
+ container_of(port, struct uart_8250_port, port);
+
+ pm_runtime_get_sync(port->dev);
+
+ up->ier &= ~UART_IER_RLSI;
+ up->port.read_status_mask &= ~UART_LSR_DR;
+ serial_port_out(port, UART_IER, up->ier);
+
+ pm_runtime_mark_last_busy(port->dev);
+ pm_runtime_put_autosuspend(port->dev);
+}
+
static void serial8250_start_tx(struct uart_port *port)
{
struct uart_8250_port *up =
@@ -1339,21 +1354,6 @@ static void serial8250_start_tx(struct uart_port *port)
pm_runtime_put_autosuspend(port->dev);
}
-static void serial8250_stop_rx(struct uart_port *port)
-{
- struct uart_8250_port *up =
- container_of(port, struct uart_8250_port, port);
-
- pm_runtime_get_sync(port->dev);
-
- up->ier &= ~UART_IER_RLSI;
- up->port.read_status_mask &= ~UART_LSR_DR;
- serial_port_out(port, UART_IER, up->ier);
-
- pm_runtime_mark_last_busy(port->dev);
- pm_runtime_put_autosuspend(port->dev);
-}
-
static void serial8250_enable_ms(struct uart_port *port)
{
struct uart_8250_port *up =
--
2.0.1
WARNING: multiple messages have this Message-ID (diff)
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] tty: serial: 8250-core: reorder serial8250_stop_rx() & serial8250_start_tx()
Date: Wed, 9 Jul 2014 19:49:35 +0200 [thread overview]
Message-ID: <1404928177-26554-5-git-send-email-bigeasy@linutronix.de> (raw)
In-Reply-To: <1404928177-26554-1-git-send-email-bigeasy@linutronix.de>
With the upcomming rs485 support it is required that
serial8250_stop_rx() is called from serial8250_start_tx(). With this
reordering there is no need for a forward declaration of the former
function.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
drivers/tty/serial/8250/8250_core.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 1a91a89..c7c3bf7 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -1306,6 +1306,21 @@ static void serial8250_stop_tx(struct uart_port *port)
pm_runtime_put_autosuspend(port->dev);
}
+static void serial8250_stop_rx(struct uart_port *port)
+{
+ struct uart_8250_port *up =
+ container_of(port, struct uart_8250_port, port);
+
+ pm_runtime_get_sync(port->dev);
+
+ up->ier &= ~UART_IER_RLSI;
+ up->port.read_status_mask &= ~UART_LSR_DR;
+ serial_port_out(port, UART_IER, up->ier);
+
+ pm_runtime_mark_last_busy(port->dev);
+ pm_runtime_put_autosuspend(port->dev);
+}
+
static void serial8250_start_tx(struct uart_port *port)
{
struct uart_8250_port *up =
@@ -1339,21 +1354,6 @@ static void serial8250_start_tx(struct uart_port *port)
pm_runtime_put_autosuspend(port->dev);
}
-static void serial8250_stop_rx(struct uart_port *port)
-{
- struct uart_8250_port *up =
- container_of(port, struct uart_8250_port, port);
-
- pm_runtime_get_sync(port->dev);
-
- up->ier &= ~UART_IER_RLSI;
- up->port.read_status_mask &= ~UART_LSR_DR;
- serial_port_out(port, UART_IER, up->ier);
-
- pm_runtime_mark_last_busy(port->dev);
- pm_runtime_put_autosuspend(port->dev);
-}
-
static void serial8250_enable_ms(struct uart_port *port)
{
struct uart_8250_port *up =
--
2.0.1
next prev parent reply other threads:[~2014-07-09 17:49 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 17:49 (unknown), Sebastian Andrzej Siewior
2014-07-09 17:49 ` No subject Sebastian Andrzej Siewior
2014-07-09 17:49 ` [PATCH 1/6] tty: serial: 8250 core: provide a function to export uart_8250_port Sebastian Andrzej Siewior
2014-07-09 17:49 ` Sebastian Andrzej Siewior
2014-07-10 14:30 ` Olivier Galibert
2014-07-10 14:30 ` Olivier Galibert
2014-07-16 8:22 ` Sebastian Andrzej Siewior
2014-07-16 8:22 ` Sebastian Andrzej Siewior
2014-07-09 17:49 ` [PATCH 2/6] tty: serial: 8250 core: allow to overwrite & export serial8250_startup() Sebastian Andrzej Siewior
2014-07-09 17:49 ` Sebastian Andrzej Siewior
2014-07-10 14:54 ` One Thousand Gnomes
2014-07-10 14:54 ` One Thousand Gnomes
2014-07-10 14:55 ` Sebastian Andrzej Siewior
2014-07-10 14:55 ` Sebastian Andrzej Siewior
2014-07-09 17:49 ` [PATCH 3/6] tty: serial: 8250 core: add runtime pm Sebastian Andrzej Siewior
2014-07-09 17:49 ` Sebastian Andrzej Siewior
2014-07-10 6:28 ` Tony Lindgren
2014-07-10 6:28 ` Tony Lindgren
2014-07-16 8:26 ` Sebastian Andrzej Siewior
2014-07-16 8:26 ` Sebastian Andrzej Siewior
2014-07-21 13:34 ` Mika Westerberg
2014-07-21 13:34 ` Mika Westerberg
2014-07-09 17:49 ` Sebastian Andrzej Siewior [this message]
2014-07-09 17:49 ` [PATCH 4/6] tty: serial: 8250-core: reorder serial8250_stop_rx() & serial8250_start_tx() Sebastian Andrzej Siewior
2014-07-09 17:49 ` [PATCH 5/6] tty: serial: 8250-core: add rs485 support Sebastian Andrzej Siewior
2014-07-09 17:49 ` Sebastian Andrzej Siewior
2014-07-09 19:01 ` Lennart Sorensen
2014-07-09 19:01 ` Lennart Sorensen
2014-07-10 15:55 ` Sebastian Andrzej Siewior
2014-07-10 15:55 ` Sebastian Andrzej Siewior
2014-07-10 14:52 ` One Thousand Gnomes
2014-07-10 14:52 ` One Thousand Gnomes
2014-07-09 17:49 ` [PATCH 6/6] tty: serial: Add 8250-core based omap driver Sebastian Andrzej Siewior
2014-07-09 17:49 ` Sebastian Andrzej Siewior
2014-07-10 7:09 ` Tony Lindgren
2014-07-10 7:09 ` Tony Lindgren
2014-07-10 15:47 ` Sebastian Andrzej Siewior
2014-07-10 15:47 ` Sebastian Andrzej Siewior
2014-07-10 16:03 ` Carlos Hernandez
2014-07-10 16:03 ` Carlos Hernandez
2014-07-10 16:14 ` menon.nishanth
2014-07-10 16:14 ` menon.nishanth at gmail.com
2014-07-11 6:41 ` Tony Lindgren
2014-07-11 6:41 ` Tony Lindgren
2014-07-16 12:11 ` Sebastian Andrzej Siewior
2014-07-16 12:11 ` Sebastian Andrzej Siewior
2014-07-16 12:32 ` Tony Lindgren
2014-07-16 12:32 ` Tony Lindgren
2014-07-16 13:00 ` Sekhar Nori
2014-07-16 13:00 ` Sekhar Nori
2014-08-08 11:05 ` Heikki Krogerus
2014-08-08 11:05 ` Heikki Krogerus
2014-07-09 17:58 ` [RFC v3] 8250-core based serial driver for OMAP Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404928177-26554-5-git-send-email-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.