From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
OSUOSL Drivers <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
hsweeten@visionengravers.com, dcb314@hotmail.com
Subject: Re: [PATCH] drivers/staging/comedi/drivers/ni_atmio16d.c: remove pointless condition
Date: Fri, 11 Jul 2014 12:43:12 +0000 [thread overview]
Message-ID: <1405082594.21735.1.camel@thorin> (raw)
In-Reply-To: <CANZNk82rsdbg+zQGQODmNMpScaHZiZ8MeooGWabWZPGwzErCyQ@mail.gmail.com>
Hi!
On Fre, 2014-07-11 at 15:30 +0300, Andrey Utkin wrote:
[...]
> Could you please substantiate this? I see that convert_arg has type
> "unsigned int" which may be 8 bytes on 64-bit platform. I haven't
At least in the x86_64 world, "unsigned int" has 32bit.
TTBOMK, it is similar on all other 64bit - otherwise there is no way to
address 32bit ("short int" is usually 16 bit).
Bernd
--
"I dislike type abstraction if it has no real reason. And saving
on typing is not a good reason - if your typing speed is the main
issue when you're coding, you're doing something seriously wrong."
- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
OSUOSL Drivers <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
hsweeten@visionengravers.com, dcb314@hotmail.com
Subject: Re: [PATCH] drivers/staging/comedi/drivers/ni_atmio16d.c: remove pointless condition
Date: Fri, 11 Jul 2014 14:43:12 +0200 [thread overview]
Message-ID: <1405082594.21735.1.camel@thorin> (raw)
In-Reply-To: <CANZNk82rsdbg+zQGQODmNMpScaHZiZ8MeooGWabWZPGwzErCyQ@mail.gmail.com>
Hi!
On Fre, 2014-07-11 at 15:30 +0300, Andrey Utkin wrote:
[...]
> Could you please substantiate this? I see that convert_arg has type
> "unsigned int" which may be 8 bytes on 64-bit platform. I haven't
At least in the x86_64 world, "unsigned int" has 32bit.
TTBOMK, it is similar on all other 64bit - otherwise there is no way to
address 32bit ("short int" is usually 16 bit).
Bernd
--
"I dislike type abstraction if it has no real reason. And saving
on typing is not a good reason - if your typing speed is the main
issue when you're coding, you're doing something seriously wrong."
- Linus Torvalds
next prev parent reply other threads:[~2014-07-11 12:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 6:39 [PATCH] drivers/staging/comedi/drivers/ni_stc.h: rename prototype parameter from 'register' to 'reg' Chris Peterson
2014-07-11 10:13 ` [PATCH] drivers/staging/comedi/drivers/ni_atmio16d.c: remove pointless condition Andrey Utkin
2014-07-11 10:13 ` Andrey Utkin
2014-07-11 12:01 ` Ian Abbott
2014-07-11 12:01 ` Ian Abbott
2014-07-11 12:30 ` Andrey Utkin
2014-07-11 12:30 ` Andrey Utkin
2014-07-11 12:43 ` Bernd Petrovitsch [this message]
2014-07-11 12:43 ` Bernd Petrovitsch
2014-07-11 13:11 ` Dan Carpenter
2014-07-11 13:11 ` Dan Carpenter
2014-07-11 14:32 ` [PATCH v2] From: Andrey Utkin <andrey.krieger.utkin@gmail.com> Ian Abbott
2014-07-11 14:32 ` Ian Abbott
2014-07-11 14:35 ` Ian Abbott
2014-07-11 14:35 ` Ian Abbott
2014-07-11 14:38 ` [PATCH v3] drivers/staging/comedi/drivers/ni_atmio16d.c: remove pointless condition Ian Abbott
2014-07-11 14:38 ` Ian Abbott
2014-07-11 14:39 ` Ian Abbott
2014-07-11 14:39 ` Ian Abbott
2014-07-12 0:39 ` Greg KH
2014-07-12 0:39 ` Greg KH
2014-07-11 15:34 ` Dan Carpenter
2014-07-11 15:34 ` Dan Carpenter
2014-07-11 17:06 ` Ian Abbott
2014-07-11 17:06 ` Ian Abbott
2014-07-11 17:22 ` Dan Carpenter
2014-07-11 17:22 ` Dan Carpenter
2014-07-11 17:54 ` Andrey Utkin
2014-07-11 17:54 ` Andrey Utkin
2014-07-11 19:40 ` Dan Carpenter
2014-07-11 19:40 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405082594.21735.1.camel@thorin \
--to=bernd@petrovitsch.priv.at \
--cc=abbotti@mev.co.uk \
--cc=andrey.krieger.utkin@gmail.com \
--cc=dcb314@hotmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.