* [PATCH] Staging:tidspbridge Fix checkpatch.pl warning char * array declaration might be better as static const
@ 2014-07-15 16:48 Adithya Krishnamurthy
2014-07-15 16:48 ` [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warning unnecessary whitespace before a quoted newline Adithya Krishnamurthy
0 siblings, 1 reply; 3+ messages in thread
From: Adithya Krishnamurthy @ 2014-07-15 16:48 UTC (permalink / raw)
To: omar.ramirez, gregkh, rashika.kheria, freemangordon,
dan.carpenter, ody.guru, devel, linux-kernel
Cc: Adithya Krishnamurthy
From: Adithya Krishnamurthy <linux.challenge1@gmail.com>
Fixed checkpatch "WARNING: char * array declaration might be better as static const"
Signed-off-by: Adithya Krishnamurthy <linux.challenge1@gmail.com>
---
drivers/staging/tidspbridge/core/io_sm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c
index 42f94e1..24bd962 100644
--- a/drivers/staging/tidspbridge/core/io_sm.c
+++ b/drivers/staging/tidspbridge/core/io_sm.c
@@ -1910,10 +1910,11 @@ int dump_dsp_stack(struct bridge_dev_context *bridge_context)
u32 offset_output;
u32 total_size;
u32 poll_cnt;
- const char *dsp_regs[] = {"EFR", "IERR", "ITSR", "NTSR",
+ static const char * const dsp_regs[] = {"EFR", "IERR", "ITSR", "NTSR",
"IRP", "NRP", "AMR", "SSR",
"ILC", "RILC", "IER", "CSR"};
- const char *exec_ctxt[] = {"Task", "SWI", "HWI", "Unknown"};
+ static const char * const exec_ctxt[] = {"Task", "SWI", "HWI",
+ "Unknown"};
struct bridge_drv_interface *intf_fxns;
struct dev_object *dev_object = bridge_context->dev_obj;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warning unnecessary whitespace before a quoted newline
2014-07-15 16:48 [PATCH] Staging:tidspbridge Fix checkpatch.pl warning char * array declaration might be better as static const Adithya Krishnamurthy
@ 2014-07-15 16:48 ` Adithya Krishnamurthy
2014-07-15 16:48 ` [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warining Unnecessary parentheses Adithya Krishnamurthy
0 siblings, 1 reply; 3+ messages in thread
From: Adithya Krishnamurthy @ 2014-07-15 16:48 UTC (permalink / raw)
To: omar.ramirez, gregkh, rashika.kheria, freemangordon,
dan.carpenter, ody.guru, devel, linux-kernel
Cc: Adithya Krishnamurthy
From: Adithya Krishnamurthy <linux.challenge1@gmail.com>
Fixed checkpatch "WARNING: unnecessary whitespace before a quoted newline"
Signed-off-by: Adithya Krishnamurthy <linux.challenge1@gmail.com>
---
drivers/staging/tidspbridge/core/tiomap3430.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c
index f63dd8f..0559ab6 100644
--- a/drivers/staging/tidspbridge/core/tiomap3430.c
+++ b/drivers/staging/tidspbridge/core/tiomap3430.c
@@ -536,7 +536,7 @@ static int bridge_brd_start(struct bridge_dev_context *dev_ctxt,
if ((unsigned int *)ul_dsp_clk_addr != NULL) {
/* Get the clock rate */
ul_dsp_clk_rate = dsp_clk_get_iva2_rate();
- dev_dbg(bridge, "%s: DSP clock rate (KHZ): 0x%x \n",
+ dev_dbg(bridge, "%s: DSP clock rate (KHZ): 0x%x\n",
__func__, ul_dsp_clk_rate);
(void)bridge_brd_write(dev_context,
(u8 *) &ul_dsp_clk_rate,
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warining Unnecessary parentheses
2014-07-15 16:48 ` [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warning unnecessary whitespace before a quoted newline Adithya Krishnamurthy
@ 2014-07-15 16:48 ` Adithya Krishnamurthy
0 siblings, 0 replies; 3+ messages in thread
From: Adithya Krishnamurthy @ 2014-07-15 16:48 UTC (permalink / raw)
To: omar.ramirez, gregkh, rashika.kheria, freemangordon,
dan.carpenter, ody.guru, devel, linux-kernel
Cc: Adithya Krishnamurthy
From: Adithya Krishnamurthy <linux.challenge1@gmail.com>
Fixed checkpatch "WARNING: Unnecessary parentheses"
Signed-off-by: Adithya Krishnamurthy <linux.challenge1@gmail.com>
---
drivers/staging/tidspbridge/dynload/cload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/tidspbridge/dynload/cload.c b/drivers/staging/tidspbridge/dynload/cload.c
index 83f2106..b306349 100644
--- a/drivers/staging/tidspbridge/dynload/cload.c
+++ b/drivers/staging/tidspbridge/dynload/cload.c
@@ -376,7 +376,7 @@ void dload_headers(struct dload_state *dlthis)
return;
}
/* Check for valid file format */
- if ((dlthis->dfile_hdr.df_doff_version != DOFF0)) {
+ if (dlthis->dfile_hdr.df_doff_version != DOFF0) {
dload_error(dlthis, "Bad DOFF version 0x%x",
dlthis->dfile_hdr.df_doff_version);
return;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-15 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-15 16:48 [PATCH] Staging:tidspbridge Fix checkpatch.pl warning char * array declaration might be better as static const Adithya Krishnamurthy
2014-07-15 16:48 ` [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warning unnecessary whitespace before a quoted newline Adithya Krishnamurthy
2014-07-15 16:48 ` [PATCH] Staging:tidspbridge Fix minor checkpatch.pl warining Unnecessary parentheses Adithya Krishnamurthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.