From: kiran.padwal@smartplayin.com
Cc: jackp@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
Andy Gross <agross@codeaurora.org>
Subject: RE: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers
Date: Thu, 17 Jul 2014 06:30:24 -0400 (EDT) [thread overview]
Message-ID: <1405593024.423213197@apps.rackspace.com> (raw)
In-Reply-To: <CA+neC=McWS8=iSi2XShJyvc85Aw4PSmF-osNpVgJv42d9or1WQ@mail.gmail.com>
Hi,
On Mon, Jun 30, 2014 at 9:33 PM, Andy Gross <agross@codeaurora.org> wrote:
> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>
> These drivers handles control and configuration of the HS
> and SS USB PHY transceivers. They are part of the driver
.
[snip]
.
> +#include <linux/usb/phy.h>
> +
> +/**
> + * USB QSCRATCH Hardware registers
> + */
unused define, can you please remove it
> +#define QSCRATCH_CTRL_REG (0x04)
> +#define QSCRATCH_GENERAL_CFG (0x08)
> +#define PHY_CTRL_REG (0x10)
> +#define PARAMETER_OVERRIDE_X_REG (0x14)
ditto
> +#define CHARGING_DET_CTRL_REG (0x18)
ditto
> +#define CHARGING_DET_OUTPUT_REG (0x1c)
ditto
> +#define ALT_INTERRUPT_EN_REG (0x20)
ditto
> +#define PHY_IRQ_STAT_REG (0x24)
ditto
> +#define CGCTL_REG (0x28)
> +
> +#define PHY_3P3_VOL_MIN 3050000 /* uV */
> +#define PHY_3P3_VOL_MAX 3300000 /* uV */
> +#define PHY_3P3_HPM_LOAD 16000 /* uA */
> +
.
[snip]
.
> +MODULE_ALIAS("platform:qcom-dwc3-ssphy");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("DesignWare USB3 QCOM SSPHY driver");
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Regards,
Kiran Padwal
WARNING: multiple messages have this Message-ID (diff)
From: kiran.padwal@smartplayin.com (kiran.padwal at smartplayin.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers
Date: Thu, 17 Jul 2014 06:30:24 -0400 (EDT) [thread overview]
Message-ID: <1405593024.423213197@apps.rackspace.com> (raw)
In-Reply-To: <CA+neC=McWS8=iSi2XShJyvc85Aw4PSmF-osNpVgJv42d9or1WQ@mail.gmail.com>
Hi,
On Mon, Jun 30, 2014 at 9:33 PM, Andy Gross <agross@codeaurora.org> wrote:
> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>
> These drivers handles control and configuration of the HS
> and SS USB PHY transceivers. They are part of the driver
.
[snip]
.
> +#include <linux/usb/phy.h>
> +
> +/**
> + * USB QSCRATCH Hardware registers
> + */
unused define, can you please remove it
> +#define QSCRATCH_CTRL_REG (0x04)
> +#define QSCRATCH_GENERAL_CFG (0x08)
> +#define PHY_CTRL_REG (0x10)
> +#define PARAMETER_OVERRIDE_X_REG (0x14)
ditto
> +#define CHARGING_DET_CTRL_REG (0x18)
ditto
> +#define CHARGING_DET_OUTPUT_REG (0x1c)
ditto
> +#define ALT_INTERRUPT_EN_REG (0x20)
ditto
> +#define PHY_IRQ_STAT_REG (0x24)
ditto
> +#define CGCTL_REG (0x28)
> +
> +#define PHY_3P3_VOL_MIN 3050000 /* uV */
> +#define PHY_3P3_VOL_MAX 3300000 /* uV */
> +#define PHY_3P3_HPM_LOAD 16000 /* uA */
> +
.
[snip]
.
> +MODULE_ALIAS("platform:qcom-dwc3-ssphy");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("DesignWare USB3 QCOM SSPHY driver");
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Regards,
Kiran Padwal
WARNING: multiple messages have this Message-ID (diff)
From: kiran.padwal@smartplayin.com
To: "Andy Gross" <agross@codeaurora.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
linux-arm-kernel@lists.infradead.org,
"Kumar Gala" <galak@codeaurora.org>,
jackp@codeaurora.org, linux-arm-msm@vger.kernel.org,
"Andy Gross" <agross@codeaurora.org>
Subject: RE: [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers
Date: Thu, 17 Jul 2014 06:30:24 -0400 (EDT) [thread overview]
Message-ID: <1405593024.423213197@apps.rackspace.com> (raw)
In-Reply-To: <CA+neC=McWS8=iSi2XShJyvc85Aw4PSmF-osNpVgJv42d9or1WQ@mail.gmail.com>
Hi,
On Mon, Jun 30, 2014 at 9:33 PM, Andy Gross <agross@codeaurora.org> wrote:
> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>
> These drivers handles control and configuration of the HS
> and SS USB PHY transceivers. They are part of the driver
.
[snip]
.
> +#include <linux/usb/phy.h>
> +
> +/**
> + * USB QSCRATCH Hardware registers
> + */
unused define, can you please remove it
> +#define QSCRATCH_CTRL_REG (0x04)
> +#define QSCRATCH_GENERAL_CFG (0x08)
> +#define PHY_CTRL_REG (0x10)
> +#define PARAMETER_OVERRIDE_X_REG (0x14)
ditto
> +#define CHARGING_DET_CTRL_REG (0x18)
ditto
> +#define CHARGING_DET_OUTPUT_REG (0x1c)
ditto
> +#define ALT_INTERRUPT_EN_REG (0x20)
ditto
> +#define PHY_IRQ_STAT_REG (0x24)
ditto
> +#define CGCTL_REG (0x28)
> +
> +#define PHY_3P3_VOL_MIN 3050000 /* uV */
> +#define PHY_3P3_VOL_MAX 3300000 /* uV */
> +#define PHY_3P3_HPM_LOAD 16000 /* uA */
> +
.
[snip]
.
> +MODULE_ALIAS("platform:qcom-dwc3-ssphy");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("DesignWare USB3 QCOM SSPHY driver");
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Regards,
Kiran Padwal
next prev parent reply other threads:[~2014-07-17 10:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 16:03 [Patch v7 0/3] DWC3 USB support for Qualcomm platform Andy Gross
2014-06-30 16:03 ` Andy Gross
2014-06-30 16:03 ` [Patch v7 1/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver Andy Gross
2014-06-30 16:03 ` Andy Gross
2014-06-30 16:52 ` Felipe Balbi
2014-06-30 16:52 ` Felipe Balbi
2014-06-30 16:52 ` Felipe Balbi
2014-07-18 2:10 ` Jingoo Han
2014-07-18 2:10 ` Jingoo Han
2014-06-30 16:03 ` [Patch v7 2/3] usb: phy: Add Qualcomm DWC3 HS/SS PHY drivers Andy Gross
2014-06-30 16:03 ` Andy Gross
2014-06-30 17:00 ` Felipe Balbi
2014-06-30 17:00 ` Felipe Balbi
2014-06-30 17:00 ` Felipe Balbi
[not found] ` <CA+neC=McWS8=iSi2XShJyvc85Aw4PSmF-osNpVgJv42d9or1WQ@mail.gmail.com>
2014-07-17 10:30 ` kiran.padwal [this message]
2014-07-17 10:30 ` kiran.padwal
2014-07-17 10:30 ` kiran.padwal at smartplayin.com
[not found] ` <1405593024.423213197-0ZYIasU8DW2IAIbY1eLdq9BPR1lH4CV8@public.gmane.org>
2014-07-17 18:28 ` Andy Gross
2014-07-17 18:28 ` Andy Gross
2014-07-17 18:28 ` Andy Gross
2014-06-30 16:03 ` [Patch v7 3/3] usb: dwc3: qcom: Add device tree binding Andy Gross
2014-06-30 16:03 ` Andy Gross
2014-06-30 17:37 ` Kumar Gala
2014-06-30 17:37 ` Kumar Gala
2014-07-01 5:04 ` Rob Herring
2014-07-01 5:04 ` Rob Herring
2014-07-01 18:01 ` Andy Gross
2014-07-01 18:01 ` Andy Gross
2014-07-01 19:47 ` Rob Herring
2014-07-01 19:47 ` Rob Herring
2014-07-02 8:43 ` Ivan T. Ivanov
2014-07-02 8:43 ` Ivan T. Ivanov
2014-07-02 12:48 ` Arnd Bergmann
2014-07-02 12:48 ` Arnd Bergmann
2014-07-02 15:54 ` Felipe Balbi
2014-07-02 15:54 ` Felipe Balbi
2014-07-02 15:54 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405593024.423213197@apps.rackspace.com \
--to=kiran.padwal@smartplayin.com \
--cc=agross@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=jackp@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.